Virtual modifier deprecation warning

matheusaaguiar · matheusaaguiar · commit 505eecf7b34e · 2025-11-19T13:34:05.000-03:00
diff --git a/libsolidity/analysis/SyntaxChecker.cpp b/libsolidity/analysis/SyntaxChecker.cpp
@@ -195,6 +195,14 @@ void SyntaxChecker::endVisit(ModifierDefinition const& _modifier)
 {
 	if (_modifier.isImplemented() && !m_placeholderFound)
 		m_errorReporter.syntaxError(2883_error, _modifier.body().location(), "Modifier body does not contain '_'.");
+
+	if (_modifier.markedVirtual())
+		m_errorReporter.warning(
+			8429_error,
+			_modifier.location(),
+			"Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9)."
+		);
+
 	m_placeholderFound = false;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -195,6 +195,14 @@ void SyntaxChecker::endVisit(ModifierDefinition const& _modifier)`
`195`	`195`	`{`
`196`	`196`	`if (_modifier.isImplemented() && !m_placeholderFound)`
`197`	`197`	`m_errorReporter.syntaxError(2883_error, _modifier.body().location(), "Modifier body does not contain '_'.");`
	`198`	`+`
	`199`	`+ if (_modifier.markedVirtual())`
	`200`	`+ m_errorReporter.warning(`
	`201`	`+ 8429_error,`
	`202`	`+ _modifier.location(),`
	`203`	`+ "Virtual modifiers are deprecated and scheduled for removal in the next breaking version (0.9)."`
	`204`	`+ );`
	`205`	`+`
`198`	`206`	`m_placeholderFound = false;`
`199`	`207`	`}`
`200`	`208`