Contract type comparison deprecation warning

matheusaaguiar · matheusaaguiar · commit 830a029221b4 · 2025-11-17T11:33:13.000-03:00
diff --git a/libsolidity/analysis/TypeChecker.cpp b/libsolidity/analysis/TypeChecker.cpp
@@ -1829,6 +1829,16 @@ void TypeChecker::endVisit(BinaryOperation const& _operation)
 				)
 			);
 	}
+	if (
+		TokenTraits::isCompareOp(_operation.getOperator()) &&
+		commonType->category() == Type::Category::Contract
+	)
+		m_errorReporter.warning(
+			9170_error,
+			_operation.location(),
+			"Comparison of variables of contract type is deprecated and scheduled for removal "
+			"in the next breaking version (0.9). Instead, use an explicit cast to address type."
+		);
 }
 
 Type const* TypeChecker::typeCheckTypeConversionAndRetrieveReturnType(

Original file line number	Diff line number	Diff line change
`@@ -1829,6 +1829,16 @@ void TypeChecker::endVisit(BinaryOperation const& _operation)`
`1829`	`1829`	`)`
`1830`	`1830`	`);`
`1831`	`1831`	`}`
	`1832`	`+ if (`
	`1833`	`+ TokenTraits::isCompareOp(_operation.getOperator()) &&`
	`1834`	`+ commonType->category() == Type::Category::Contract`
	`1835`	`+ )`
	`1836`	`+ m_errorReporter.warning(`
	`1837`	`+ 9170_error,`
	`1838`	`+ _operation.location(),`
	`1839`	`+ "Comparison of variables of contract type is deprecated and scheduled for removal "`
	`1840`	`+ "in the next breaking version (0.9). Instead, use an explicit cast to address type."`
	`1841`	`+ );`
`1832`	`1842`	`}`
`1833`	`1843`
`1834`	`1844`	`Type const* TypeChecker::typeCheckTypeConversionAndRetrieveReturnType(`