Merge pull request #12511 from ethereum/deterministic-test-order-in-trident-ext-test

hrkrshnn · web-flow · commit a7119699836b · 2022-01-11T12:28:10.000+05:30
Deterministic test order in Trident external test
diff --git a/test/externalTests/trident.sh b/test/externalTests/trident.sh
@@ -35,14 +35,15 @@ function test_fn {
     TS_NODE_TRANSPILE_ONLY=1 npx hardhat test --no-compile $(
         # TODO: We need to skip Migration.test.ts because it fails and makes other tests fail too.
         # Replace this with `yarn test` once https://github.com/sushiswap/trident/issues/283 is fixed.
-        find test/ -name "*.test.ts" ! -path "test/Migration.test.ts"
+        find test/ -name "*.test.ts" ! -path "test/Migration.test.ts" | LC_ALL=C sort
     )
 }
 
 function trident_test
 {
     local repo="https://github.com/sushiswap/trident"
     local ref_type=commit
+    # FIXME: Switch back to master branch when https://github.com/sushiswap/trident/issues/303 gets fixed.
     local ref="0cab5ae884cc9a41223d52791be775c3a053cb26" # master as of 2021-12-16
     local config_file="hardhat.config.ts"
     local config_var=config

Original file line number	Diff line number	Diff line change
`@@ -35,14 +35,15 @@ function test_fn {`
`35`	`35`	`TS_NODE_TRANSPILE_ONLY=1 npx hardhat test --no-compile $(`
`36`	`36`	`# TODO: We need to skip Migration.test.ts because it fails and makes other tests fail too.`
`37`	`37`	# Replace this with `yarn test` once https://github.com/sushiswap/trident/issues/283 is fixed.
`38`		`- find test/ -name "*.test.ts" ! -path "test/Migration.test.ts"`
	`38`	`+ find test/ -name "*.test.ts" ! -path "test/Migration.test.ts" \| LC_ALL=C sort`
`39`	`39`	`)`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`function trident_test`
`43`	`43`	`{`
`44`	`44`	`local repo="https://github.com/sushiswap/trident"`
`45`	`45`	`local ref_type=commit`
	`46`	`+ # FIXME: Switch back to master branch when https://github.com/sushiswap/trident/issues/303 gets fixed.`
`46`	`47`	`local ref="0cab5ae884cc9a41223d52791be775c3a053cb26" # master as of 2021-12-16`
`47`	`48`	`local config_file="hardhat.config.ts"`
`48`	`49`	`local config_var=config`