Emit deprecation warnings for abi coder v1, contract comparisons, memory-safe-assembly, send and transfer functions, and virtual modifiers.

Author: matheusaaguiar

Changelog.md

@@ -6,6 +6,11 @@ Language Features:
 Compiler Features:
 * ethdebug: Experimental support for instructions and source locations under EOF.
 * EVM: Set default EVM Version to `osaka`.
+* DocString Parser: Warn about deprecation of inline assembly special comment `memory-safe-assembly`.
+* Syntax Checker: Warn about deprecation of ABI coder v1.
+* Syntax Checker: Warn about deprecation of virtual modifiers.
+* Type Checker: Warn about deprecation of `send` and `transfer` functions on instances of `address`.
+* Type Checker: Warn about deprecation of comparisons between variables of contract types.
 
 Bugfixes:
 * Assembler: Fix not using a fixed-width type for IDs being assigned to subassemblies nested more than one level away, resulting in inconsistent `--asm-json` output between target architectures.

libsolidity/analysis/DocStringTagParser.cpp

@@ -206,11 +206,18 @@ bool DocStringTagParser::visit(InlineAssembly const& _assembly)
 							m_errorReporter.warning(
 								8544_error,
 								_assembly.location(),
-								"Inline assembly marked as memory safe using both a NatSpec tag and an assembly flag. "
-								"If you are not concerned with backwards compatibility, only use the assembly flag, "
+								"Inline assembly marked as memory safe using both a NatSpec tag and an assembly block annotation. "
+								"If you are not concerned with backwards compatibility, only use the assembly block annotation, "
 								"otherwise only use the NatSpec tag."
 							);
 						_assembly.annotation().markedMemorySafe = true;
+						m_errorReporter.warning(
+							2424_error,
+							_assembly.location(),
+							"Natspec memory-safe-assembly special comment for inline assembly is deprecated and "
+							"scheduled for removal. "
+							"Use the memory-safe block annotation instead."
+						);
 					}
 					else
 						m_errorReporter.warning(

libsolidity/analysis/SyntaxChecker.cpp

@@ -149,6 +149,16 @@ bool SyntaxChecker::visit(PragmaDirective const& _pragma)
 			);
 		else
 			m_sourceUnit->annotation().useABICoderV2 = (_pragma.literals()[1] == "v2");
+
+		if (
+			_pragma.literals().size() > 1 &&
+			_pragma.literals()[1] == "v1"
+		)
+			m_errorReporter.warning(
+				9511_error,
+				_pragma.location(),
+				"ABI coder v1 is deprecated and scheduled for removal. Use ABI coder v2 instead."
+			);
 	}
 	else if (_pragma.literals()[0] == "solidity")
 	{
@@ -184,6 +194,14 @@ void SyntaxChecker::endVisit(ModifierDefinition const& _modifier)
 {
 	if (_modifier.isImplemented() && !m_placeholderFound)
 		m_errorReporter.syntaxError(2883_error, _modifier.body().location(), "Modifier body does not contain '_'.");
+
+	if (_modifier.markedVirtual())
+		m_errorReporter.warning(
+			8429_error,
+			_modifier.location(),
+			"Virtual modifiers are deprecated and scheduled for removal."
+		);
+
 	m_placeholderFound = false;
 }
 

libsolidity/analysis/TypeChecker.cpp

@@ -1829,6 +1829,16 @@ void TypeChecker::endVisit(BinaryOperation const& _operation)
 				)
 			);
 	}
+	if (
+		TokenTraits::isCompareOp(_operation.getOperator()) &&
+		commonType->category() == Type::Category::Contract
+	)
+		m_errorReporter.warning(
+			9170_error,
+			_operation.location(),
+			"Comparison of variables of contract type is deprecated and scheduled for removal. "
+			"Use an explicit cast to address type and compare the addresses instead."
+		);
 }
 
 Type const* TypeChecker::typeCheckTypeConversionAndRetrieveReturnType(
@@ -3212,6 +3222,19 @@ bool TypeChecker::visit(MemberAccess const& _memberAccess)
 				if (contractType && contractType->isSuper())
 					requiredLookup = VirtualLookup::Super;
 			}
+
+		if (
+			funType->kind() == FunctionType::Kind::Send ||
+			funType->kind() == FunctionType::Kind::Transfer
+		)
+			m_errorReporter.warning(
+				9207_error,
+				_memberAccess.location(),
+				fmt::format(
+					"'{}' is deprecated and scheduled for removal. Use 'call{{value: <amount>}}(\"\")' instead.",
+					funType->kind() == FunctionType::Kind::Send ? "send" : "transfer"
+				)
+			);
 	}
 
 	annotation.requiredLookup = requiredLookup;

test/cmdlineTests/model_checker_targets_all_all_engines/err

@@ -1,3 +1,9 @@
+Warning: 'transfer' is deprecated and scheduled for removal. Use 'call{value: <amount>}("")' instead.
+  --> input.sol:10:3:
+   |
+10 | 		a.transfer(x);
+   | 		^^^^^^^^^^
+
 Warning: CHC: Underflow (resulting value less than 0) happens here.
 Counterexample:
 arr = []

test/cmdlineTests/model_checker_targets_all_bmc/err

@@ -1,3 +1,9 @@
+Warning: 'transfer' is deprecated and scheduled for removal. Use 'call{value: <amount>}("")' instead.
+  --> input.sol:10:3:
+   |
+10 | 		a.transfer(x);
+   | 		^^^^^^^^^^
+
 Warning: BMC: Condition is always true.
  --> input.sol:6:11:
   |

test/cmdlineTests/model_checker_targets_all_chc/err

@@ -1,3 +1,9 @@
+Warning: 'transfer' is deprecated and scheduled for removal. Use 'call{value: <amount>}("")' instead.
+  --> input.sol:10:3:
+   |
+10 | 		a.transfer(x);
+   | 		^^^^^^^^^^
+
 Warning: CHC: Underflow (resulting value less than 0) happens here.
 Counterexample:
 arr = []

test/cmdlineTests/model_checker_targets_assert_bmc/err

@@ -1,3 +1,9 @@
+Warning: 'transfer' is deprecated and scheduled for removal. Use 'call{value: <amount>}("")' instead.
+  --> input.sol:10:3:
+   |
+10 | 		a.transfer(x);
+   | 		^^^^^^^^^^
+
 Warning: BMC: Assertion violation happens here.
   --> input.sol:11:3:
    |

test/cmdlineTests/model_checker_targets_assert_chc/err

@@ -1,3 +1,9 @@
+Warning: 'transfer' is deprecated and scheduled for removal. Use 'call{value: <amount>}("")' instead.
+  --> input.sol:10:3:
+   |
+10 | 		a.transfer(x);
+   | 		^^^^^^^^^^
+
 Warning: CHC: Assertion violation happens here.
 Counterexample:
 arr = []

test/cmdlineTests/model_checker_targets_balance_bmc/err

@@ -1,3 +1,9 @@
+Warning: 'transfer' is deprecated and scheduled for removal. Use 'call{value: <amount>}("")' instead.
+  --> input.sol:10:3:
+   |
+10 | 		a.transfer(x);
+   | 		^^^^^^^^^^
+
 Warning: BMC: Insufficient funds happens here.
   --> input.sol:10:3:
    |