Skip to content

Commit f99c724

Browse files
authored
Merge pull request #16320 from argotorg/release-checklist-update-docker-requirements
Update Docker requirements on the release checklist
2 parents bdc1116 + 032d0bf commit f99c724

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

ReleaseChecklist.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
# Checklist for making a Solidity release
22

33
## Requirements
4-
- [ ] GitHub account with access to [solidity](https://github.com/argotorg/solidity), [solc-js](https://github.com/argotorg/solc-js),
4+
- GitHub account with access to [solidity](https://github.com/argotorg/solidity), [solc-js](https://github.com/argotorg/solc-js),
55
[solc-bin](https://github.com/argotorg/solc-bin), [solidity-website](https://github.com/argotorg/solidity-website).
6-
- [ ] DockerHub account with push rights to the [`solc` image](https://hub.docker.com/r/ethereum/solc).
7-
- [ ] Ubuntu/Debian dependencies of the Docker script: `docker-buildx`.
8-
- [ ] [npm Registry](https://www.npmjs.com) account added as a collaborator for the [`solc` package](https://www.npmjs.com/package/solc).
9-
- [ ] Access to the [solidity_lang Twitter account](https://twitter.com/solidity_lang).
10-
- [ ] [Reddit](https://www.reddit.com) account that is at least 10 days old with a minimum of 20 comment karma (`/r/ethereum` requirements).
6+
- Personal Access Token (PAT) with `write:packages` scope to access Github's container registry.
7+
You can generate one by visiting https://github.com/settings/tokens/new?scopes=write:packages.
8+
- Ubuntu/Debian dependencies of the Docker script: `docker-buildx`.
9+
- [npm Registry](https://www.npmjs.com) account added as a collaborator for the [`solc` package](https://www.npmjs.com/package/solc).
10+
- Access to the [solidity_lang Twitter account](https://twitter.com/solidity_lang).
11+
- [Reddit](https://www.reddit.com) account that is at least 10 days old with a minimum of 20 comment karma (`/r/ethereum` requirements).
1112

1213
## Full release
1314

scripts/docker_deploy_manual.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ fi
2525
# NOTE: Login to GHCR before running this script with a PAT:
2626
# echo $GHCR_TOKEN | docker login ghcr.io -u USERNAME --password-stdin
2727
#
28-
# Create a classic PAT with write:packages scope only visiting the following url:
28+
# Create a classic PAT with write:packages scope by visiting the following URL:
2929
# https://github.com/settings/tokens/new?scopes=write:packages
3030

3131
DIR=$(mktemp -d)

0 commit comments

Comments
 (0)