-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Open
Labels
ethdebuglow effortThere is not much implementation work to be done. The task is very easy or tiny.There is not much implementation work to be done. The task is very easy or tiny.medium impactDefault level of impactDefault level of impactmust haveSomething we consider an essential part of Solidity 1.0.Something we consider an essential part of Solidity 1.0.testing 🔨
Description
Abstract
We have tests in place that will check the solc output with respect to their conformity to the ethdebug schema: ethdebugSchemaTests/.
Right now we merely have two smoketests in there. We should run such tests on some subset (or all) of the tests in the repository like for AST or evmasm import.
Motivation
The schema is directly pulled from the ethdebug source to ensure
that we
- adapt to changes in the schema quickly and
- do not produce invalid output (validity with respect to schema).
Specification
It should be enough to rglob for test files ahead of test time and add them to the args in the test definition:
solidity/test/ethdebugSchemaTests/test_ethdebug_schema_conformity.py
Lines 17 to 18 in 6313134
| @pytest.fixture(params=["input_file.json", "input_file_eof.json"]) | |
| def solc_output(request, solc_path): |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
ethdebuglow effortThere is not much implementation work to be done. The task is very easy or tiny.There is not much implementation work to be done. The task is very easy or tiny.medium impactDefault level of impactDefault level of impactmust haveSomething we consider an essential part of Solidity 1.0.Something we consider an essential part of Solidity 1.0.testing 🔨