Fix processing logic in massive-replace-script to handle errors and update contract counter correctly (#2280)

Author: marcocastignoli

services/database/massive-replace-script/config-replace-creation-information.js

@@ -27,6 +27,8 @@ module.exports = {
           AND c.runtime_code_hash IS NOT NULL
           -- Exclude unsupported chains
           AND cd.chain_id NOT IN (3,4,5,28,43,50,69,77,99,300,420,534,570,592,842,1291,1433,1516,2017,2358,7701,9977,10242,10243,11111,12898,13381,16350,17069,26100,28528,32770,33101,33103,48899,57000,71401,78430,78431,78432,80001,84531,103090,167005,167006,202401,420420,420666,421611,421613,1127469,192837465,222000222,333000333,356256156,486217935,4216137055,7078815900)
+          -- -- Exclude failing RPC chains
+          -- AND cd.chain_id NOT IN (40,10200)
           AND sm.id >= $1
       ORDER BY sm.id ASC
       LIMIT $2
@@ -38,6 +40,7 @@ module.exports = {
     return {
       chainId: contract.chain_id.toString(),
       address: `0x${contract.address.toString("hex")}`,
+      transactionHash: `0x${contract.transaction_hash.toString("hex")}`,
       forceCompilation: false,
       forceRPCRequest: true,
       customReplaceMethod: "replace-creation-information",

services/database/massive-replace-script/massive-replace-script.ts

@@ -34,7 +34,7 @@ if (fs.existsSync(COUNTER_FILE)) {
   );
 }
 
-const N = 200; // Number of contracts to process at a time
+const N = 5; // Number of contracts to process at a time
 
 const POSTGRES_SCHEMA = process.env.POSTGRES_SCHEMA || "public";
 
@@ -117,7 +117,10 @@ async function processContract(
 
     console.log(`✅ Successfully processed contract ${address}:`, result);
   } catch (error) {
-    console.error(`❌ Failed to process contract ${address}:`, error);
+    console.error(
+      `❌ Failed to process contract ${address} at chain ${contract.chain_id}:`,
+      error,
+    );
     throw error;
   }
 }
@@ -155,37 +158,40 @@ async function processContract(
 
       verifiedContractCount = rowCount || 0;
 
+      let secondToWait = 2;
       // Process the batch in parallel
       try {
         const processingPromises = verifiedContracts.map((contract) =>
           processContract(contract, config),
         );
         await Promise.all(processingPromises);
-
-        // Update the counter file only after the batch successfully completes
-        if (verifiedContracts.length > 0) {
-          const lastProcessedId =
-            verifiedContracts[verifiedContracts.length - 1]
-              .verified_contract_id ||
-            verifiedContracts[verifiedContracts.length - 1].id;
-          CURRENT_VERIFIED_CONTRACT = parseInt(lastProcessedId) + 1;
-
-          // Use async write to avoid blocking
-          fs.writeFile(
-            COUNTER_FILE,
-            CURRENT_VERIFIED_CONTRACT.toString(),
-            "utf8",
-            (err) => {
-              if (err) {
-                console.error("Error writing counter file:", err);
-              }
-            },
-          );
-        }
       } catch (batchError) {
+        secondToWait = 5; // Increase wait time on error
         console.error("Error processing batch:", batchError);
       }
 
+      // Update the counter file only after the batch successfully completes
+
+      const lastProcessedId =
+        verifiedContracts[verifiedContracts.length - 1].verified_contract_id ||
+        verifiedContracts[verifiedContracts.length - 1].id;
+      CURRENT_VERIFIED_CONTRACT = parseInt(lastProcessedId) + 1;
+
+      // Use async write to avoid blocking
+      fs.writeFile(
+        COUNTER_FILE,
+        CURRENT_VERIFIED_CONTRACT.toString(),
+        "utf8",
+        (err) => {
+          if (err) {
+            console.error("Error writing counter file:", err);
+          }
+        },
+      );
+
+      console.log(`waiting ${secondToWait} seconds`);
+      await new Promise((resolve) => setTimeout(resolve, secondToWait * 1000));
+
       const endIterationTime = performance.now();
       const iterationTimeTaken = endIterationTime - startIterationTime;
       console.log(