Add tests for pre-0.4.11 solc cborAuxdata handling

Author: kuzdogan

packages/lib-sourcify/test/Compilation/SolidityCompilation.spec.ts

@@ -325,4 +325,119 @@ describe('SolidityCompilation', () => {
     const immutableRefs = compilation.immutableReferences;
     expect(immutableRefs).to.deep.equal({ '3': [{ length: 32, start: 608 }] });
   });
+
+  // Contracts before 0.4.12 don't have `auxdata` in `legacyAssembly`
+  // https://github.com/ethereum/sourcify/issues/2217
+  it('should handle legacy Solidity 0.4.11 contracts with auxdata correctly', async () => {
+    const contractPath = path.join(__dirname, '..', 'sources', 'pre-0.4.11');
+    const sources = {
+      'Multidrop.sol': {
+        content: fs.readFileSync(
+          path.join(contractPath, 'Multidrop.sol'),
+          'utf8',
+        ),
+      },
+    };
+
+    const solcJsonInput: SolidityJsonInput = {
+      language: 'Solidity',
+      sources,
+      settings: {
+        optimizer: {
+          enabled: false,
+          runs: 200,
+        },
+        outputSelection: {
+          '*': {
+            '*': ['*'],
+          },
+        },
+      },
+    };
+
+    const compilation = new SolidityCompilation(
+      solc,
+      '0.4.11+commit.68ef5810', // Solidity 0.4.11
+      solcJsonInput,
+      {
+        name: 'Multidrop',
+        path: 'Multidrop.sol',
+      },
+    );
+
+    await compilation.compile();
+    await compilation.generateCborAuxdataPositions();
+
+    // For Solidity 0.4.11, auxdata should be extracted from bytecode directly
+    // The auxdata positions should be calculated correctly even though legacyAssembly doesn't have .auxdata field
+    expect(compilation.runtimeBytecodeCborAuxdata).to.not.deep.equal({});
+    expect(compilation.creationBytecodeCborAuxdata).to.not.deep.equal({});
+
+    // Verify that auxdata positions are properly structured
+    if (Object.keys(compilation.runtimeBytecodeCborAuxdata).length > 0) {
+      expect(compilation.runtimeBytecodeCborAuxdata['1']).to.have.property(
+        'offset',
+      );
+      expect(compilation.runtimeBytecodeCborAuxdata['1']).to.have.property(
+        'value',
+      );
+      expect(compilation.runtimeBytecodeCborAuxdata['1'].value).to.match(
+        /^0x[a-fA-F0-9]+$/,
+      );
+    }
+
+    if (Object.keys(compilation.creationBytecodeCborAuxdata).length > 0) {
+      expect(compilation.creationBytecodeCborAuxdata['1']).to.have.property(
+        'offset',
+      );
+      expect(compilation.creationBytecodeCborAuxdata['1']).to.have.property(
+        'value',
+      );
+      expect(compilation.creationBytecodeCborAuxdata['1'].value).to.match(
+        /^0x[a-fA-F0-9]+$/,
+      );
+    }
+  });
+
+  it('should handle very old Solidity versions (< 0.4.7) with no auxdata', async () => {
+    const contractPath = path.join(__dirname, '..', 'sources', 'pre-0.4.11');
+    const sources = {
+      'Simple.sol': {
+        content: fs.readFileSync(path.join(contractPath, 'Simple.sol'), 'utf8'),
+      },
+    };
+
+    const solcJsonInput: SolidityJsonInput = {
+      language: 'Solidity',
+      sources,
+      settings: {
+        optimizer: {
+          enabled: false,
+          runs: 200,
+        },
+        outputSelection: {
+          '*': {
+            '*': ['*'],
+          },
+        },
+      },
+    };
+
+    const compilation = new SolidityCompilation(
+      solc,
+      '0.4.0+commit.acd334c9',
+      solcJsonInput,
+      {
+        name: 'Simple',
+        path: 'Simple.sol',
+      },
+    );
+
+    await compilation.compile();
+    await compilation.generateCborAuxdataPositions();
+
+    // For versions < 0.4.7, no auxdata should exist
+    expect(compilation.runtimeBytecodeCborAuxdata).to.deep.equal({});
+    expect(compilation.creationBytecodeCborAuxdata).to.deep.equal({});
+  });
 });

packages/lib-sourcify/test/sources/pre-0.4.11/Multidrop.sol

@@ -0,0 +1,57 @@
+pragma solidity ^0.4.0;
+
+contract ERC20Basic {
+    uint public totalSupply;
+
+    function balanceOf(address who) constant returns (uint);
+
+    function transfer(address to, uint value);
+
+    event Transfer(address indexed from, address indexed to, uint value);
+}
+
+contract ERC20 is ERC20Basic {
+    function allowance(address owner, address spender) constant returns (uint);
+
+    function transferFrom(address from, address to, uint value);
+
+    function approve(address spender, uint value);
+
+    event Approval(address indexed owner, address indexed spender, uint value);
+}
+
+contract Ownable {
+    address public owner;
+
+    function Ownable() {
+        owner = msg.sender;
+    }
+
+    modifier onlyOwner() {
+        if (msg.sender != owner) {
+            throw;
+        }
+        _;
+    }
+
+    function transferOwnership(address newOwner) onlyOwner {
+        if (newOwner != address(0)) {
+            owner = newOwner;
+        }
+    }
+}
+
+contract Multidrop is Ownable {
+    function multisend(
+        address _tokenAddr,
+        address[] dests,
+        uint256[] values
+    ) onlyOwner returns (uint256) {
+        uint256 i = 0;
+        while (i < dests.length) {
+            ERC20(_tokenAddr).transfer(dests[i], values[i]);
+            i += 1;
+        }
+        return (i);
+    }
+}

packages/lib-sourcify/test/sources/pre-0.4.11/Simple.sol

@@ -0,0 +1,13 @@
+pragma solidity ^0.4.0;
+
+contract Simple {
+    uint public value;
+    
+    function Simple() {
+        value = 42;
+    }
+    
+    function setValue(uint _value) {
+        value = _value;
+    }
+}