Refactor constructor arguments transformation to use ABI instead of Metadata (#2308)

Author: marcocastignoli

packages/lib-sourcify/src/Verification/Transformations.ts

@@ -2,13 +2,12 @@ import { AuxdataStyle } from '@ethereum-sourcify/bytecode-utils';
 import {
   ImmutableReferences,
   LinkReferences,
-  Metadata,
 } from '@ethereum-sourcify/compilers-types';
 import {
   CompiledContractCborAuxdata,
   StringMap,
 } from '../Compilation/CompilationTypes';
-import { AbiCoder, id as keccak256Str, Interface } from 'ethers';
+import { AbiCoder, id as keccak256Str, Interface, InterfaceAbi } from 'ethers';
 import { logError } from '../logger';
 
 const abiCoder = AbiCoder.defaultAbiCoder();
@@ -194,16 +193,15 @@ export function extractAbiEncodedConstructorArguments(
 export function extractConstructorArgumentsTransformation(
   populatedRecompiledBytecode: string,
   onchainCreationBytecode: string,
-  metadata: Metadata,
+  abi: InterfaceAbi,
 ) {
   const transformations: Transformation[] = [];
   const transformationValues: TransformationValues = {};
   const abiEncodedConstructorArguments = extractAbiEncodedConstructorArguments(
     populatedRecompiledBytecode,
     onchainCreationBytecode,
   );
-  const constructorAbiParamInputs = new Interface(metadata?.output?.abi).deploy
-    .inputs;
+  const constructorAbiParamInputs = new Interface(abi).deploy.inputs;
   if (abiEncodedConstructorArguments) {
     if (!constructorAbiParamInputs) {
       throw new Error(

packages/lib-sourcify/src/Verification/Verification.ts

@@ -492,7 +492,7 @@ export class Verification {
         extractConstructorArgumentsTransformation(
           matchBytecodesResult.populatedRecompiledBytecode,
           this.onchainCreationBytecode,
-          this.compilation.metadata,
+          this.compilation.contractCompilerOutput?.abi || [],
         );
       this.creationTransformations = [
         ...matchBytecodesResult.transformations,