fix PR comments

Author: marcocastignoli

package-lock.json

@@ -512,7 +512,7 @@ import { EtherscanUtils } from '@ethereum-sourcify/lib-sourcify';
 const etherscanResult = await EtherscanUtils.fetchFromEtherscan(
   1, // chainId
   '0x6B175474E89094C44Da98b954EedeAC495271d0F', // contract address
-  'YOUR_API_KEY', // optional API key
+  'YOUR_API_KEY', // API key
 );
 ```
 

packages/lib-sourcify/README.md

@@ -176,13 +176,13 @@ export const getVyperJsonInputFromSingleFileResult = (
 export const fetchFromEtherscan = async (
   chainId: number | string,
   address: string,
-  apiKey: string = '',
+  apiKey: string,
 ): Promise<EtherscanResult> => {
   const url = `https://api.etherscan.io/v2/api?chainid=${chainId}&module=contract&action=getsourcecode&address=${address}&apikey=`;
   const secretUrl = url + apiKey;
   const maskedUrl = url + (apiKey ? apiKey.slice(0, 6) + '...' : '');
 
-  let response: any;
+  let response: Response;
   logInfo('Fetching from Etherscan', {
     maskedUrl,
     chainId,

packages/lib-sourcify/src/utils/etherscan/etherscan-util.ts

@@ -43,6 +43,7 @@ describe('etherscan util (lib)', function () {
   const testChainId = 1;
   const testAddress = '0xB753548F6E010e7e680BA186F9Ca1BdAB2E90cf2';
   const sourcifyChain = makeChain(testChainId);
+  const testApiKey = '';
 
   this.afterEach(() => {
     nock.cleanAll();
@@ -54,11 +55,11 @@ describe('etherscan util (lib)', function () {
         sourcifyChain,
         testAddress,
         UNVERIFIED_CONTRACT_RESPONSE,
-        '',
+        testApiKey,
       );
 
       const error = await expect(
-        EtherscanUtils.fetchFromEtherscan(testChainId, testAddress),
+        EtherscanUtils.fetchFromEtherscan(testChainId, testAddress, testApiKey),
       ).to.be.rejectedWith(EtherscanImportError);
       expect((error as any).code).to.equal('etherscan_not_verified');
       expect(scope.isDone()).to.equal(true);
@@ -69,11 +70,11 @@ describe('etherscan util (lib)', function () {
         sourcifyChain,
         testAddress,
         INVALID_API_KEY_RESPONSE,
-        '',
+        testApiKey,
       );
 
       const error = await expect(
-        EtherscanUtils.fetchFromEtherscan(testChainId, testAddress),
+        EtherscanUtils.fetchFromEtherscan(testChainId, testAddress, testApiKey),
       ).to.be.rejectedWith(EtherscanImportError);
       expect((error as any).code).to.equal('etherscan_api_error');
       expect(scope.isDone()).to.equal(true);
@@ -84,11 +85,11 @@ describe('etherscan util (lib)', function () {
         sourcifyChain,
         testAddress,
         RATE_LIMIT_REACHED_RESPONSE,
-        '',
+        testApiKey,
       );
 
       const error = await expect(
-        EtherscanUtils.fetchFromEtherscan(testChainId, testAddress),
+        EtherscanUtils.fetchFromEtherscan(testChainId, testAddress, testApiKey),
       ).to.be.rejectedWith(EtherscanImportError);
       expect((error as any).code).to.equal('etherscan_rate_limit');
       expect(scope.isDone()).to.equal(true);
@@ -111,6 +112,7 @@ describe('etherscan util (lib)', function () {
         const result = await EtherscanUtils.fetchFromEtherscan(
           testChainId,
           testAddress,
+          testApiKey,
         );
         expect(result).to.deep.equal((response as any).result[0]);
         expect(scope.isDone()).to.equal(true);

packages/lib-sourcify/test/utils/etherscan-util.spec.ts

@@ -55,7 +55,6 @@
     "@ethereum-sourcify/lib-sourcify": "^2.2.2",
     "@google-cloud/cloud-sql-connector": "1.8.2",
     "@shazow/whatsabi": "0.22.2",
-    "@solidity-parser/parser": "0.20.2",
     "abitype": "1.0.8",
     "bunyan": "1.8.15",
     "chalk": "4.1.2",