Skip to content

Commit c4db7f3

Browse files
committed
fix(ci): main release ci should sp1up from latest tag
1 parent f83e147 commit c4db7f3

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

.github/workflows/release.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
pull_token: ${{ secrets.PULL_TOKEN }}
3434

3535
# If it's a nightly release, tag with the release time. If the tag is `main`, we want to use
36-
# `latest` as the tag name. Else, use the tag name as is.
36+
# `latest` as the tag name. else, use the tag name as is.
3737
- name: Compute release name and tag
3838
id: release_info
3939
run: |
@@ -220,6 +220,8 @@ jobs:
220220
fi
221221
222222
# Creates the release for this specific version
223+
# If this is for latest, this will override the files there, but not change the commit to the current main.
224+
# todo(n): change this to override the commit as well somehow.
223225
- name: Create release
224226
uses: softprops/action-gh-release@v2
225227
with:
@@ -272,7 +274,7 @@ jobs:
272274

273275
- name: "Install SP1"
274276
env:
275-
SP1UP_VERSION: ${{ github.ref_name }}
277+
SP1UP_VERSION: ${{ github.ref_name == 'main' && 'latest' || github.ref_name }}
276278
run: |
277279
cd sp1up
278280
chmod +x sp1up

0 commit comments

Comments
 (0)