ci: add integration tests

Author: Ariel Ben-Yehuda

.github/actions/rust-build/action.yml

@@ -16,7 +16,12 @@ runs:
     - uses: Swatinem/rust-cache@v2
     - name: Build
       shell: bash
-      run: if [ "${{ inputs.toolchain }}" != stable ]; then rm -fv Cargo.lock; fi && cargo build --all-features --verbose
+      run: |
+          if [ "${{ inputs.toolchain }}" != stable ]; then
+              rm -fv Cargo.lock
+          fi
+          cargo build --all-features --verbose
+          cargo build --all-features --verbose --example simple
     - name: Run tests
       shell: bash
       run: cargo test --all-features --verbose

.github/workflows/build-decoder.yml

@@ -3,12 +3,14 @@ on: [pull_request]
 
 jobs:
   build:
+    id: build
+    name: Build
     runs-on: ubuntu-latest
     strategy:
       matrix:
         toolchain:
+          - stable # Stable is first to test with Cargo.lock
           - "1.85" # Current MSRV due to Cargo MSRV feature
-          - stable
     env:
       RUST_BACKTRACE: 1
     steps:
@@ -17,5 +19,8 @@ jobs:
         uses: ./.github/actions/rust-build
         with:
           toolchain: ${{ matrix.toolchain }}
-
-
+      - name: Upload artifact for testing
+        uses: actions/upload-artifact@v4
+        with:
+          name: example-simple
+          path: ./target/debug/example/simple

.github/workflows/build.yml

@@ -1,2 +1,4 @@
 /target
 /decoder/target
+/tests/async-profiler
+/tests/profiles

.gitignore

@@ -31,6 +31,7 @@ tracing-subscriber = { version = "0.3", features = ["env-filter"] }
 tokio = { version = "1", features = ["test-util", "full"] }
 test-case = "3"
 rand = "0.9"
+humantime = "2"
 
 [[example]]
 name = 'simple'

Cargo.lock

@@ -3,7 +3,10 @@
 
 use async_profiler_agent::{
     profiler::ProfilerBuilder,
-    reporter::s3::{S3Reporter, S3ReporterConfig},
+    reporter::{
+        local::LocalReporter,
+        s3::{S3Reporter, S3ReporterConfig},
+    },
 };
 use std::time::Duration;
 
@@ -34,6 +37,14 @@ struct Args {
     bucket_owner: String,
     #[arg(long)]
     bucket: String,
+    #[arg(long)]
+    local: bool,
+    #[arg(long)]
+    #[clap(value_parser = humantime::parse_duration)]
+    duration: Option<Duration>,
+    #[arg(long, default_value = "30s")]
+    #[clap(value_parser = humantime::parse_duration)]
+    reporting_interval: Duration,
 }
 
 #[allow(unexpected_cfgs)]
@@ -56,23 +67,35 @@ async fn main_internal() -> Result<(), anyhow::Error> {
 
     let args = Args::parse();
 
-    let sdk_config = aws_config::defaults(BehaviorVersion::latest()).load().await;
-    let reporting_interval = Duration::from_secs(30);
+    let profiler = ProfilerBuilder::default();
 
-    let profiler = ProfilerBuilder::default()
-        .with_reporter(S3Reporter::new(S3ReporterConfig {
+    let profiler = if args.local {
+        profiler.with_reporter(LocalReporter::new(args.bucket))
+    } else {
+        let sdk_config = aws_config::defaults(BehaviorVersion::latest()).load().await;
+        profiler.with_reporter(S3Reporter::new(S3ReporterConfig {
             sdk_config: &sdk_config,
             bucket_owner: args.bucket_owner,
             bucket_name: args.bucket,
             profiling_group_name: args.profiling_group,
         }))
-        .with_reporting_interval(reporting_interval)
+    };
+
+    let profiler = profiler
+        .with_reporting_interval(args.reporting_interval)
         .build();
 
     tracing::info!("starting profiler");
     profiler.spawn()?;
     tracing::info!("profiler started");
 
-    slow::run().await;
+    if let Some(timeout) = args.duration {
+        tokio::time::timeout(timeout, slow::run())
+            .await
+            .unwrap_err();
+    } else {
+        slow::run().await;
+    }
+
     Ok(())
 }

Cargo.toml

@@ -0,0 +1,42 @@
+#!/bin/bash
+
+set -exuo pipefail
+
+git clone https://github.com/async-profiler/async-profiler
+(
+    cd async-profiler
+    git checkout 14c7e819b2054308da1bd980fe72137d2d0e0cf6
+    make -j16
+)
+export LD_LIBRARY_PATH="$PWD/async-profiler/build/lib"
+mkdir -p profiles
+rm -f profiles/*.jfr
+(
+    ./example-simple -- --local --bucket tests/profiles --bucket-owner 0 --profiling-group PG --duration 30s --reporting-interval 5s
+)
+(
+    for profile in profiles/*.jfr; do
+        short_sleeps_100=$(./pollcatch-decoder longpolls --stack-depth=10 "$profile" 100us | ( grep -c short_sleep_2 || true ))
+        short_sleeps_1000=$(./pollcatch-decoder longpolls --stack-depth=10 "$profile" 1000us | ( grep -c short_sleep_2 || true ))
+        long_sleeps_100=$(./pollcatch-decoder longpolls --stack-depth=10 "$profile" 100us | ( grep -c accidentally_slow_2 || true ))
+        long_sleeps_1000=$(./pollcatch-decoder longpolls --stack-depth=10 "$profile" 1000us | ( grep -c accidentally_slow_2 || true ))
+        # Long sleeps should occur in both the 100us and 1000us filters
+        if [ "$long_sleeps_100" -lt 1 ]; then
+            echo "No long sleeps in 100us"
+            exit 1
+        fi
+        if [ "$long_sleeps_1000" -lt 1 ]; then
+            echo "No long sleeps in 1000us"
+            exit 1
+        fi
+        # short sleeps should only occur in the 100us filter. Allow a small number of short sleeps if there was OS jank
+        if [ "$short_sleeps_100" -lt 5 ]; then
+            echo "No short sleeps in 100us"
+            exit 1
+        fi
+        if [ "$short_sleeps_1000" -gt 5 ]; then
+            echo "Too many short sleeps in 1000us"
+            exit 1
+        fi
+    done
+)