Use fmod instead of %

arifszn · arifszn · commit 4548850bf093 · 2022-02-11T22:56:36.000+06:00
diff --git a/src/Rules/CreditCard.php b/src/Rules/CreditCard.php
@@ -55,7 +55,7 @@ public function passes($attribute, $value)
                 $tmpNum *= 2;
                 
                 if ($tmpNum >= 10) {
-                    $sum += (($tmpNum % 10) + 1);
+                    $sum += (fmod($tmpNum, 10) + 1);
                 } else {
                     $sum += $tmpNum;
                 }
@@ -66,7 +66,7 @@ public function passes($attribute, $value)
             $shouldDouble = !$shouldDouble;
         }
 
-        return !!(($sum % 10) === 0 ? true : false);
+        return !!(fmod($sum, 10) === 0.0 ? true : false);
     }
 
     /**
diff --git a/src/Rules/DivisibleBy.php b/src/Rules/DivisibleBy.php
@@ -50,7 +50,7 @@ public function passes($attribute, $value)
     {
         $this->attribute = $attribute;
 
-        return (floatval($value) !== 0.0) && (floatval($value) % intval($this->number, 10) === 0);
+        return (floatval($value) !== 0.0) && (fmod(floatval($value), intval($this->number, 10)) === 0.0);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ public function passes($attribute, $value)`
`55`	`55`	`$tmpNum *= 2;`
`56`	`56`
`57`	`57`	`if ($tmpNum >= 10) {`
`58`		`- $sum += (($tmpNum % 10) + 1);`
	`58`	`+ $sum += (fmod($tmpNum, 10) + 1);`
`59`	`59`	`} else {`
`60`	`60`	`$sum += $tmpNum;`
`61`	`61`	`}`
`@@ -66,7 +66,7 @@ public function passes($attribute, $value)`
`66`	`66`	`$shouldDouble = !$shouldDouble;`
`67`	`67`	`}`
`68`	`68`
`69`		`- return !!(($sum % 10) === 0 ? true : false);`
	`69`	`+ return !!(fmod($sum, 10) === 0.0 ? true : false);`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public function passes($attribute, $value)`
`50`	`50`	`{`
`51`	`51`	`$this->attribute = $attribute;`
`52`	`52`
`53`		`- return (floatval($value) !== 0.0) && (floatval($value) % intval($this->number, 10) === 0);`
	`53`	`+ return (floatval($value) !== 0.0) && (fmod(floatval($value), intval($this->number, 10)) === 0.0);`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`/**`