ci(small): Allow manual Gemini invocation to override global disable flag (#9501)

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: arii <342438+arii@users.noreply.github.com>

Author: arii

.github/workflows/pr-enrichment.yml

@@ -34,7 +34,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
         with:
-          ref: refs/pull/${{ inputs.pr_number || github.event.pull_request.number }}/head
+          ref: refs/pull/${{ inputs.pr_number || github.event.pull_request.number || github.event.issue.number }}/head
           fetch-depth: 0
 
       - name: Setup Environment

scripts/decide-review-strategy.sh

@@ -23,6 +23,7 @@ set -e
 : "${QUALITY_GATE_BOT_USERNAMES:=github-actions[bot]}"
 # This variable is optional and may not be present for all event types.
 : "${COMMENT_BODY:=}"
+: "${GEMINI_ENABLE_PR_REVIEW:=true}"
 
 
 # --- Initial State ---
@@ -31,23 +32,23 @@ SKIP_REASON="no criteria met"
 
 # --- Main Logic ---
 
-# Check 0: Gemini Review Enablement
-if [[ "${GEMINI_ENABLE_PR_REVIEW:-true}" == "false" ]]; then
-  echo "::info::Gemini review is disabled via GEMINI_ENABLE_PR_REVIEW."
-  echo "needs-review=false" >> "$GITHUB_OUTPUT"
-  echo "skip-reason=Gemini review is disabled" >> "$GITHUB_OUTPUT"
-  exit 0
-fi
-
-# Check 1: Manual Override
+# Check 1: Manual Override (Highest Priority)
 # A manual trigger (e.g., a specific comment) always forces a review, bypassing all other checks.
-if [[ "$TRIGGER_EVENT" == "comment" && ( "$COMMENT_BODY" == *@gemini-bot* || "$COMMENT_BODY" == *@jules* ) ]]; then
-  echo "::info::Manual review triggered by comment. Bypassing all checks."
+if [[ "$TRIGGER_EVENT" == "comment" && ( "${COMMENT_BODY,,}" == *@gemini-bot* || "${COMMENT_BODY,,}" == *@jules* ) ]]; then
+  echo "::info::Manual review triggered by comment. Bypassing all checks and global toggles."
   echo "needs-review=true" >> "$GITHUB_OUTPUT"
   echo "skip-reason=" >> "$GITHUB_OUTPUT"
   exit 0
 fi
 
+# Check 1b: Global Toggle
+if [[ "$GEMINI_ENABLE_PR_REVIEW" == "false" ]]; then
+  echo "::info::Gemini review is disabled via GEMINI_ENABLE_PR_REVIEW."
+  echo "needs-review=false" >> "$GITHUB_OUTPUT"
+  echo "skip-reason=Gemini review is globally disabled" >> "$GITHUB_OUTPUT"
+  exit 0
+fi
+
 # Check 2: Comment Count Limit
 # Prevents reviews on PRs that are excessively noisy.
 COMMENT_COUNT=$(gh pr view "$PR_NUMBER" --json comments --jq '.comments | length')

tests/unit/decide-review-strategy.bats

@@ -7,7 +7,7 @@ setup() {
   # Reset all environment variables to a clean slate
   unset TRIGGER_EVENT ACTION_TYPE COMMENT_BODY PR_NUMBER BASE_SHA HEAD_SHA \
         PR_QUALITY_RESULT MAX_COMMENTS REVIEW_THROTTLE_MINUTES BOT_USERNAME \
-        QUALITY_GATE_BOT_USERNAMES MOCK_GH_COMMENTS_JSON
+        QUALITY_GATE_BOT_USERNAMES MOCK_GH_COMMENTS_JSON GEMINI_ENABLE_PR_REVIEW
 }
 
 @test "should trigger review on manual override" {
@@ -23,6 +23,18 @@ setup() {
   assert_output "skip-reason" ""
 }
 
+@test "should trigger review on case-insensitive manual override" {
+  export TRIGGER_EVENT="comment"
+  export ACTION_TYPE="created"
+  export COMMENT_BODY="@Gemini-Bot review"
+
+  run_script
+
+  [ "$status" -eq 0 ]
+  assert_output "needs-review" "true"
+  assert_output "skip-reason" ""
+}
+
 @test "should skip review when comment limit is exceeded" {
   export MAX_COMMENTS=1
   export MOCK_GH_COMMENTS_JSON='[{"body":"a"},{"body":"b"}]'
@@ -112,7 +124,20 @@ setup() {
 
   [ "$status" -eq 0 ]
   assert_output "needs-review" "false"
-  assert_output "skip-reason" "Gemini review is disabled"
+  assert_output "skip-reason" "Gemini review is globally disabled"
+}
+
+@test "should trigger review on manual override even if GEMINI_ENABLE_PR_REVIEW is false" {
+  export GEMINI_ENABLE_PR_REVIEW="false"
+  export TRIGGER_EVENT="comment"
+  export ACTION_TYPE="created"
+  export COMMENT_BODY="@gemini-bot review"
+
+  run_script
+
+  [ "$status" -eq 0 ]
+  assert_output "needs-review" "true"
+  assert_output "skip-reason" ""
 }
 
 # Helper function to assert the output of the script