CreateInWizard attribute that allows to filter out valid ScriptableObjects in the ScriptableObjectCreationWizard; minor improvements and refactor changes

Author: arimger

Assets/Editor Toolbox/Editor/ToolboxPropertyHandler.cs

@@ -7,7 +7,7 @@
 
 namespace Toolbox.Editor
 {
-    using Toolbox.Attributes;
+    using Toolbox.Attributes.Property;
     using Toolbox.Editor.Drawers;
 
     /// <summary>
@@ -90,7 +90,6 @@ internal class ToolboxPropertyHandler
         /// </summary>
         private ILabelProcessorAttribute labelProcessorAttribute;
 
-
         /// <summary>
         /// Constructor prepares all property-related data for custom drawing.
         /// </summary>

Assets/Editor Toolbox/Editor/Utilities/AssemblyUtilities.cs

@@ -0,0 +1,88 @@
+using System;
+using System.Collections.Generic;
+using System.Reflection;
+using UnityEditor;
+
+namespace Toolbox.Editor
+{
+    [InitializeOnLoad]
+    public static class AssemblyUtilities
+    {
+        private static readonly HashSet<string> projectAssemblyNames = new HashSet<string>();
+        private static readonly HashSet<string> internalAssemblyNames = new HashSet<string>()
+        {
+            "Bee.BeeDriver",
+            "ExCSS.Unity",
+            "Mono.Security",
+            "mscorlib",
+            "netstandard",
+            "Newtonsoft.Json",
+            "nunit.framework",
+            "ReportGeneratorMerged",
+            "Unrelated",
+            "SyntaxTree.VisualStudio.Unity.Bridge",
+            "SyntaxTree.VisualStudio.Unity.Messaging",
+        };
+
+        private static bool isCached;
+
+        static AssemblyUtilities()
+        {
+            isCached = false;
+        }
+
+        private static void CacheProjectAssemblies()
+        {
+            projectAssemblyNames.Clear();
+            var appDomain = AppDomain.CurrentDomain;
+            foreach (var assembly in appDomain.GetAssemblies())
+            {
+                if (assembly.IsDynamic)
+                {
+                    continue;
+                }
+
+                var assemblyName = assembly.GetName().Name;
+                if (assemblyName.StartsWith("System") ||
+                   assemblyName.StartsWith("Unity") ||
+                   assemblyName.StartsWith("UnityEditor") ||
+                   assemblyName.StartsWith("UnityEngine") ||
+                   internalAssemblyNames.Contains(assemblyName))
+                {
+                    continue;
+                }
+
+                projectAssemblyNames.Add(assembly.FullName);
+            }
+        }
+
+        public static bool IsProjectAssembly(Assembly assembly)
+        {
+            if (assembly == null)
+            {
+                return false;
+            }
+
+            return IsProjectAssembly(assembly.FullName);
+        }
+
+        public static bool IsProjectAssembly(string assemblyName)
+        {
+            return ProjectAssemblyNames.Contains(assemblyName);
+        }
+
+        public static HashSet<string> ProjectAssemblyNames
+        {
+            get
+            {
+                if (!isCached)
+                {
+                    CacheProjectAssemblies();
+                    isCached = true;
+                }
+
+                return projectAssemblyNames;
+            }
+        }
+    }
+}

Assets/Editor Toolbox/Editor/Utilities/AssemblyUtilities.cs.meta

@@ -15,15 +15,13 @@ public static class TypeUtilities
         internal static readonly Dictionary<int, TypesEditorCollection> editorCollections = new Dictionary<int, TypesEditorCollection>();
         internal static readonly Dictionary<string, Type> referenceTypesByNames = new Dictionary<string, Type>();
 
-
         internal static void ClearCache()
         {
             cachedCollections.Clear();
             editorCollections.Clear();
             referenceTypesByNames.Clear();
         }
 
-
         public static TypesCachedCollection GetCollection(Type parentType)
         {
             return GetCollection(new TypeConstraintContext(parentType));

Assets/Editor Toolbox/Editor/Utilities/TypeUtilities.cs

@@ -8,7 +8,9 @@
 
 namespace Toolbox.Editor.Wizards
 {
+    using Toolbox.Attributes;
     using Toolbox.Editor.Internal;
+
     using Editor = UnityEditor.Editor;
 
     /// <summary>
@@ -26,7 +28,9 @@ public TypeConstraintScriptableObject() : base(typeof(ScriptableObject), TypeSet
 
             public override bool IsSatisfied(Type type)
             {
-                return Attribute.IsDefined(type, typeof(CreateAssetMenuAttribute)) && base.IsSatisfied(type);
+                return AssemblyUtilities.IsProjectAssembly(type.Assembly) &&
+                    (Attribute.IsDefined(type, typeof(CreateInWizardAttribute)) || Attribute.IsDefined(type, typeof(CreateAssetMenuAttribute))) &&
+                    base.IsSatisfied(type);
             }
         }
 

Assets/Editor Toolbox/Editor/Wizards/ScriptableObjectCreationWizard.cs

@@ -0,0 +1,10 @@
+using System;
+using System.Diagnostics;
+
+namespace Toolbox.Attributes
+{
+    [AttributeUsage(AttributeTargets.Class, AllowMultiple = false)]
+    [Conditional("UNITY_EDITOR")]
+    public class CreateInWizardAttribute : Attribute
+    { }
+}

Assets/Editor Toolbox/README.md

@@ -1,4 +1,4 @@
-namespace Toolbox.Attributes
+namespace Toolbox.Attributes.Property
 {
     /// <summary>
     /// Temporary interface used to wrap all attributes used to override property labels.