added mocks for ns lookup

Author: Andy Newton

lib/nicinfo/domain.rb

@@ -112,7 +112,7 @@ def process json_data
       @entities = @common.process_entities @objectclass
       json_nses = NicInfo::get_nameservers json_data
       json_nses.each do |json_ns|
-        ns = Ns.new( @config )
+        ns = @config.factory.new_ns
         ns.process( json_ns )
         @nameservers << ns
       end if json_nses

lib/nicinfo/ns.rb

@@ -22,7 +22,7 @@
 module NicInfo
 
   def NicInfo.display_ns json_data, config, data_node
-    ns = Ns.new( config ).process( json_data )
+    ns = config.factory.new_ns.process( json_data )
     NicInfo::display_object_with_entities( ns, config, data_node )
   end
 
@@ -32,7 +32,7 @@ def NicInfo.display_nameservers json_data, config, data_node
       if ns_array.instance_of? Array
         display_array = Array.new
         ns_array.each do |ea|
-          ns = Ns.new( config ).process( ea )
+          ns = config.factory.new_ns.process( ea )
           display_array << ns
         end
         NicInfo::display_object_with_entities( display_array, config, data_node )

spec/recorded_responses/ns1_arin_net.txt

@@ -0,0 +1,11 @@
+HTTP/1.1 200 OK
+Server: nginx
+Date: Wed, 20 Dec 2017 00:07:49 GMT
+Content-Type: application/rdap+json;charset=ISO-8859-1
+Content-Length: 806
+Connection: keep-alive
+Set-Cookie: JSESSIONID=5C34B7329ADDD6C0341A5B54675ED407; Path=/; Secure; HttpOnly
+X-Frame-Options: DENY
+Strict-Transport-Security: max-age=15768000
+
+{"port43":"whois.verisign-grs.com","objectClassName":"nameserver","notices":[{"description":["Service subject to Terms of Use."],"links":[{"href":"http:\/\/rdap-pilot.verisignlabs.com\/terms_of_use","type":"text\/html"}],"title":"Terms of Use"}],"rdapConformance":["rdap_level_0"],"handle":"60625639~VRSN","ipAddresses":{"v6":["2001:500:13:0:0:0:0:108"],"v4":["199.212.0.108"]},"links":[{"rel":"self","href":"https:\/\/rdap-pilot.verisignlabs.com\/rdap\/v1\/nameserver\/NS1.ARIN.NET","type":"application\/rdap+json","value":"https:\/\/rdap-pilot.verisignlabs.com\/rdap\/v1\/nameserver\/NS1.ARIN.NET"}],"lang":"en-US","events":[{"eventAction":"registration","eventDate":"2007-10-09T12:45:17Z"},{"eventAction":"last changed","eventDate":"2014-06-13T18:33:47Z"}],"ldhName":"NS1.ARIN.NET","status":["active"]}

spec/webmock_spec.rb

@@ -90,7 +90,7 @@
     response = File.new( "spec/recorded_responses/ip_108_45_128_208.txt")
     stub_request(:get, "https://rdap.arin.net/registry/ip/108.45.128.208").to_return(response)
 
-    dir = File.join( @work_dir, "test_search_entity_200" )
+    dir = File.join( @work_dir, "test_lookup_ip_108_45_128_208_200" )
     logger = NicInfo::Logger.new
     logger.data_out = StringIO.new
     logger.message_out = StringIO.new
@@ -117,7 +117,7 @@
     response = File.new( "spec/recorded_responses/autnum_703.txt")
     stub_request(:get, "https://rdap.arin.net/registry/autnum/703").to_return(response)
 
-    dir = File.join( @work_dir, "test_search_entity_200" )
+    dir = File.join( @work_dir, "test_lookup_autnum_703_200" )
     logger = NicInfo::Logger.new
     logger.data_out = StringIO.new
     logger.message_out = StringIO.new
@@ -139,4 +139,31 @@
     expect( config.factory).to have_received(:new_autnum).once
     expect(a_request(:get, "https://rdap.arin.net/registry/autnum/703")).to have_been_made.once
   end
+
+  it 'should process an ns lookup' do
+    response = File.new( "spec/recorded_responses/ns1_arin_net.txt")
+    stub_request(:get, "https://rdap-pilot.verisignlabs.com/rdap/v1/nameserver/ns1.arin.net").to_return(response)
+
+    dir = File.join( @work_dir, "test_lookup_ns1_arin_net_200" )
+    logger = NicInfo::Logger.new
+    logger.data_out = StringIO.new
+    logger.message_out = StringIO.new
+    logger.message_level = NicInfo::MessageLevel::NO_MESSAGES
+    config = NicInfo::Config.new( dir )
+    config.logger=logger
+    config.config[ NicInfo::BOOTSTRAP ][ NicInfo::UPDATE_BSFILES ]=false
+
+    args = [ "ns1.arin.net" ]
+
+    allow( config.factory ).to receive(:new_error_code).and_call_original
+    allow( config.factory ).to receive(:new_notices).and_call_original
+    allow( config.factory ).to receive(:new_entity).and_call_original
+    allow( config.factory ).to receive(:new_ns).and_call_original
+    expect{ NicInfo::Main.new( args, config ).run }.to_not output.to_stdout
+    expect( config.factory).to_not have_received(:new_error_code)
+    expect( config.factory).to have_received(:new_notices).once
+    expect( config.factory).to_not have_received(:new_entity)
+    expect( config.factory).to have_received(:new_ns).once
+    expect(a_request(:get, "https://rdap-pilot.verisignlabs.com/rdap/v1/nameserver/ns1.arin.net")).to have_been_made.once
+  end
 end