Merge pull request #33 from aristanetworks/feature/remove-pytest-version-constraint

Remove pytest < 7.3 version constraint

Author: creid-arista

.github/workflows/build.yaml

@@ -7,7 +7,7 @@ on:
 
 jobs:
   test:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     strategy:
       matrix:
         python-version: ["3.7", "3.8", "3.9", "3.10", "3.11"]
@@ -29,12 +29,12 @@ jobs:
         run: |
           tox -s -e "py37,py38,py39,py310,py311"
 
-#      - name: Test Summary
-#        uses: test-summary/action@v1
-#        with:
-#          paths: |
-#            test-reports/*.xml
-#        if: always()
+  #      - name: Test Summary
+  #        uses: test-summary/action@v1
+  #        with:
+  #          paths: |
+  #            test-reports/*.xml
+  #        if: always()
 
   lint:
     runs-on: ubuntu-latest

Dockerfile

@@ -1,33 +1,33 @@
-FROM fedora:34 as base
+FROM fedora:34 AS base
 
 RUN dnf -y update && dnf clean all
 RUN dnf -y install python3.7 python3.8 python3.9 python3.10 python3.11 tox git && dnf clean all
 RUN python3 -m pip install --upgrade build twine mkdocs && dnf clean all
 
-FROM base as build
+FROM base AS build
 ADD . /src
 WORKDIR /src
 
 CMD ["tox"]
 
 # Recipes to run tox
-FROM build as run
+FROM build AS run
 RUN tox
 
-FROM scratch as results
+FROM scratch AS results
 COPY --from=run /src/test-reports /
 
 # Recipes to build the documentation
-FROM build as build_docs
+FROM build AS build_docs
 RUN pip3 install pyeapi pexpect
 RUN mkdocs build
 
-FROM scratch as docs
+FROM scratch AS docs
 COPY --from=build_docs /src/site /
 
 # Recipes to build the distribution package
-FROM build as build_package
+FROM build AS build_package
 RUN python3 -m build && twine check dist/*
 
-FROM scratch as package
+FROM scratch AS package
 COPY --from=build_package /src/dist/ /

Makefile

@@ -23,20 +23,19 @@ BUILD_DIR=$(CURDIR)/build
 all: package_docker
 ci: tox_docker
 
-# Any target that ends in a slash is a directory to be mkdir'd
-%/:
+$(BUILD_DIR)/:
 	mkdir -p $@
 
 tox_docker: |$(BUILD_DIR)/
 	rm -rf $(BUILD_DIR)/test-reports
-	docker buildx build . --target=results  --output=type=local,dest=$(BUILD_DIR)/test-reports && \
+	docker buildx build . --target=results --output=type=local,dest=$(BUILD_DIR)/test-reports && \
 		touch $(BUILD_DIR)/test-reports/*.xml
 
-mkdocs_docker: |$(BUILD_DIR)
-	DOCKER_BUILDKIT=1 docker build . --target=docs  --output=type=local,dest=$(BUILD_DIR)/docs
+mkdocs_docker: |$(BUILD_DIR)/
+	docker buildx build . --target=docs --output=type=local,dest=$(BUILD_DIR)/docs
 
 package_docker: |$(BUILD_DIR)/
-	DOCKER_BUILDKIT=1 docker build . --target=package --output=type=local,dest=$(BUILD_DIR)/dist
+	docker buildx build . --target=package --output=type=local,dest=$(BUILD_DIR)/dist
 
 clean:
 	rm -rf $(BUILD_DIR)

setup.cfg

@@ -38,10 +38,10 @@ package_dir=
 
 install_requires =
     pexpect >= 4.8.0
-    pyeapi>=0.8.4
-    pytest>=3.5.0,<7.3
-    six>=1.15
-    packaging>=22.0
+    pyeapi >= 0.8.4
+    pytest >= 3.5.0
+    six >= 1.15
+    packaging >= 22.0
 
 [options.packages.find]
 where=src

src/pytest_netdut/px.py

@@ -135,7 +135,7 @@ def is_at_prompt(self):
 
 
 class CLI(Shell):
-    def __init__(  # pylint: disable=dangerous-default-value,too-many-arguments
+    def __init__(  # pylint: disable=dangerous-default-value,too-many-arguments,too-many-positional-arguments
         self,
         url,
         username="admin",

tox.ini

@@ -5,7 +5,7 @@ envlist = py37,py38,py39,py310,py311,black,prospector,tmpblack
 
 [testenv]
 deps =
-    pytest < 7.3
+    pytest
     pytest-mock
 commands = pytest -v --junit-xml=test-reports/{envname}.xml --junit-prefix={envname} tests