Restore auto-resizing of the code console input prompts (jupyterlab#17819)

* Auto-resize the code console input prompts

* Add UI test

* Handle moving the prompt cell with code in it

* timeout

* try to improve the resize logic

* improve UX

* fix jittering

* integrity

* more integrity fixes

* fix promptCell

* fix package.json

* stabilize tests

* snapshot update

Author: jtpio

galata/test/jupyterlab/completer.test.ts-snapshots/completer-console-filter-jupyterlab-linux.png

@@ -72,3 +72,163 @@ test.describe('Console (terminal mode)', () => {
     await expect(executedCell).toContainText('4194304');
   });
 });
+
+test.describe('Console Input Auto-Resize', () => {
+  test.beforeEach(async ({ page }) => setupConsole(page));
+
+  test('Input prompt auto-resizes with multiple lines of text', async ({
+    page
+  }) => {
+    const codeConsoleInput = page.locator('.jp-CodeConsole-input');
+
+    const initialHeight = await codeConsoleInput.boundingBox();
+    expect(initialHeight).not.toBeNull();
+
+    const multiLineCode = `def hello_world():
+print("Hello")
+print("World")
+return "Done"`;
+
+    await page.keyboard.type(multiLineCode);
+
+    const afterTypingHeight = await codeConsoleInput.boundingBox();
+    expect(afterTypingHeight).not.toBeNull();
+    expect(afterTypingHeight!.height).toBeGreaterThan(initialHeight!.height);
+  });
+
+  test('Input prompt auto-resize works with paste operations', async ({
+    page
+  }) => {
+    const codeConsoleInput = page.locator('.jp-CodeConsole-input');
+
+    const initialHeight = await codeConsoleInput.boundingBox();
+    expect(initialHeight).not.toBeNull();
+
+    const pastedCode = `import numpy as np
+import pandas as pd
+
+data = pd.DataFrame({
+    'x': [1, 2, 3, 4, 5],
+    'y': [2, 4, 6, 8, 10]
+})
+
+print(data.head())`;
+
+    await page.evaluate(async code => {
+      await navigator.clipboard.writeText(code);
+    }, pastedCode);
+
+    await page.keyboard.press('ControlOrMeta+v');
+
+    const afterPasteHeight = await codeConsoleInput.boundingBox();
+    expect(afterPasteHeight).not.toBeNull();
+    expect(afterPasteHeight!.height).toBeGreaterThan(initialHeight!.height);
+  });
+
+  test('Input prompt maintains auto-resize height when moved from bottom to top', async ({
+    page
+  }) => {
+    const codeConsoleInput = page.locator('.jp-CodeConsole-input');
+
+    const pastedCode = `def complex_function():
+    for i in range(10):
+        if i % 2 == 0:
+            print(f"Even: {i}")
+        else:
+            print(f"Odd: {i}")
+    return "Completed"`;
+
+    await page.evaluate(async code => {
+      await navigator.clipboard.writeText(code);
+    }, pastedCode);
+
+    await page.keyboard.press('ControlOrMeta+v');
+
+    const heightAtBottom = await codeConsoleInput.boundingBox();
+    expect(heightAtBottom).not.toBeNull();
+
+    await page.getByLabel('Change Console Prompt Position').first().click();
+    await page.getByText('Prompt to top').click();
+
+    const heightAtTop = await codeConsoleInput.boundingBox();
+    expect(heightAtTop).not.toBeNull();
+    expect(heightAtTop!.height).toBeCloseTo(heightAtBottom!.height, 1);
+  });
+
+  test('Input prompt continues to auto-resize after code execution', async ({
+    page
+  }) => {
+    const codeConsoleInput = page.locator('.jp-CodeConsole-input');
+
+    const initialHeight = await codeConsoleInput.boundingBox();
+    expect(initialHeight).not.toBeNull();
+
+    const multiLineCode = `def test_function():
+    print("Line 1")
+    print("Line 2")
+    return "Done"`;
+
+    await page.keyboard.type(multiLineCode);
+
+    const heightBeforeExecution = await codeConsoleInput.boundingBox();
+    expect(heightBeforeExecution).not.toBeNull();
+    expect(heightBeforeExecution!.height).toBeGreaterThan(
+      initialHeight!.height
+    );
+
+    // Execute the code
+    await page.keyboard.press('Shift+Enter');
+
+    await page.locator('text=| Idle').waitFor();
+
+    // Check that the new empty input cell has shrunk back to original size
+    const heightAfterExecution = await codeConsoleInput.boundingBox();
+    expect(heightAfterExecution).not.toBeNull();
+    expect(heightAfterExecution!.height).toBe(initialHeight!.height);
+
+    // Type new multi-line code in the new prompt cell
+    const moreCode = `import os
+import sys
+print("Testing auto-resize")
+print("After execution")`;
+
+    await page.keyboard.type(moreCode);
+
+    const heightAfterTyping = await codeConsoleInput.boundingBox();
+    expect(heightAfterTyping).not.toBeNull();
+
+    // The input should have grown again for the new multi-line content
+    expect(heightAfterTyping!.height).toBeGreaterThan(
+      heightAfterExecution!.height
+    );
+  });
+
+  test('Input prompt shrinks when content is cleared', async ({ page }) => {
+    const codeConsoleInput = page.locator('.jp-CodeConsole-input');
+
+    const initialHeight = await codeConsoleInput.boundingBox();
+    expect(initialHeight).not.toBeNull();
+
+    const multiLineCode = `def multi_line_function():
+    print("This is line 1")
+    print("This is line 2")
+    print("This is line 3")
+    for i in range(5):
+        print(f"Loop iteration {i}")
+    return "Finished"`;
+
+    await page.keyboard.type(multiLineCode);
+
+    const expandedHeight = await codeConsoleInput.boundingBox();
+    expect(expandedHeight).not.toBeNull();
+    expect(expandedHeight!.height).toBeGreaterThan(initialHeight!.height);
+
+    // Clear the input using Ctrl+A followed by Delete
+    await page.keyboard.press('ControlOrMeta+a');
+    await page.keyboard.press('Delete');
+
+    const shrunkHeight = await codeConsoleInput.boundingBox();
+    expect(shrunkHeight).not.toBeNull();
+    expect(shrunkHeight!.height).toBe(initialHeight!.height);
+  });
+});

galata/test/jupyterlab/completer.test.ts-snapshots/completer-console-jupyterlab-linux.png

@@ -46,6 +46,7 @@
     "@jupyterlab/apputils": "^4.6.0",
     "@jupyterlab/cells": "^4.5.0",
     "@jupyterlab/codeeditor": "^4.5.0",
+    "@jupyterlab/codemirror": "^4.5.0",
     "@jupyterlab/coreutils": "^6.5.0",
     "@jupyterlab/nbformat": "^4.5.0",
     "@jupyterlab/observables": "^5.5.0",
@@ -61,7 +62,6 @@
     "@lumino/widgets": "^2.7.2"
   },
   "devDependencies": {
-    "@jupyterlab/codemirror": "^4.5.0",
     "@jupyterlab/testing": "^4.5.0",
     "@types/jest": "^29.2.0",
     "jest": "^29.2.0",