Sparc: Move H44/M44/L44 computation back to adjustFixupValue

Essentially revert the evaluateAsRelocatableImpl part from
f39696e. Ensure that absolute
relocation evaluation is in one place. SparcAsmBackend.cpp enables
better diagnostics if needed.

Author: MaskRay

llvm/lib/Target/Sparc/MCTargetDesc/SparcAsmBackend.cpp

@@ -68,6 +68,13 @@ static unsigned adjustFixupValue(unsigned Kind, uint64_t Value) {
   case ELF::R_SPARC_LO10:
     return Value & 0x3ff;
 
+  case ELF::R_SPARC_H44:
+    return (Value >> 22) & 0x3fffff;
+  case ELF::R_SPARC_M44:
+    return (Value >> 12) & 0x3ff;
+  case ELF::R_SPARC_L44:
+    return Value & 0xfff;
+
   case ELF::R_SPARC_HH22:
     return (Value >> 42) & 0x3fffff;
   case ELF::R_SPARC_HM10:

llvm/lib/Target/Sparc/MCTargetDesc/SparcMCExpr.cpp

@@ -141,26 +141,6 @@ bool SparcMCExpr::evaluateAsRelocatableImpl(MCValue &Res,
   if (!getSubExpr()->evaluateAsRelocatable(Res, Asm))
     return false;
 
-  if (Res.isAbsolute()) {
-    std::optional<int64_t> V;
-    auto C = (uint64_t)Res.getConstant();
-    switch (uint16_t(specifier)) {
-    case ELF::R_SPARC_H44:
-      V = (C >> 22) & 0x3fffff;
-      break;
-    case ELF::R_SPARC_M44:
-      V = (C >> 12) & 0x3ff;
-      break;
-    case ELF::R_SPARC_L44:
-      V = C & 0xfff;
-      break;
-    }
-    if (V) {
-      Res = MCValue::get(*V);
-      return true;
-    }
-  }
-
   Res.setSpecifier(specifier);
   return true;
 }