Skip to content

Commit 14e3a35

Browse files
boomanaiden154github-actions[bot]
authored andcommitted
Automerge: [MLIR][Python] Update Nanobind Warnings List for clang-cl on Windows
We recently moved over to compiling with clang-cl on Windows. This ended up causing a large increase in warnings, particularly due to how warnings are handled in nanobind. cd91d0f initially set -Wall -Wextra and -Wpedantic while fixing another issue, which is probably not what we want to do on third-party code. We also need to disable -Wmissing-field-initializers to get things clean in this configuration. Reviewers: makslevental, jpienaar, rkayaith Reviewed By: makslevental Pull Request: llvm/llvm-project#166828
2 parents f46e239 + e5ba3c6 commit 14e3a35

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

mlir/cmake/modules/AddMLIRPython.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -791,26 +791,26 @@ function(add_mlir_python_extension libname extname)
791791
get_property(NB_LIBRARY_TARGET_NAME TARGET ${libname} PROPERTY LINK_LIBRARIES)
792792
target_compile_options(${NB_LIBRARY_TARGET_NAME}
793793
PRIVATE
794-
-Wall -Wextra -Wpedantic
795794
-Wno-c++98-compat-extra-semi
796795
-Wno-cast-qual
797796
-Wno-covered-switch-default
798797
-Wno-deprecated-literal-operator
799798
-Wno-nested-anon-types
800799
-Wno-unused-parameter
801800
-Wno-zero-length-array
801+
-Wno-missing-field-initializers
802802
${eh_rtti_enable})
803803

804804
target_compile_options(${libname}
805805
PRIVATE
806-
-Wall -Wextra -Wpedantic
807806
-Wno-c++98-compat-extra-semi
808807
-Wno-cast-qual
809808
-Wno-covered-switch-default
810809
-Wno-deprecated-literal-operator
811810
-Wno-nested-anon-types
812811
-Wno-unused-parameter
813812
-Wno-zero-length-array
813+
-Wno-missing-field-initializers
814814
${eh_rtti_enable})
815815
endif()
816816

0 commit comments

Comments
 (0)