Skip to content

Commit 17e376e

Browse files
authored
[ATfE] Disable package tests on macOS (#327)
The package tests rely on CMake to extract the package, however the command used only supports tar and zip archives. Until an alternative solution is found to test the dmg archive produced on macOS, the package tests can instead be disabled to prevent a failure. The `test.sh` script will still attempt to build the `check-package-llvm-toolchain` target, so a dummy target is created to avoid an unrecognized target error.
1 parent 1524a58 commit 17e376e

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

arm-software/embedded/CMakeLists.txt

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -905,7 +905,16 @@ add_dependencies(check-llvm-toolchain check-${LLVM_TOOLCHAIN_C_LIBRARY})
905905
add_dependencies(check-llvm-toolchain check-compiler-rt)
906906
add_subdirectory(test)
907907
add_dependencies(check-llvm-toolchain check-llvm-toolchain-lit)
908-
add_subdirectory(packagetest)
908+
909+
# The package tests currently only support tar and zip, so don't
910+
# attempt to run them on other formats, such as dmg with macOS.
911+
# A dummy check-package-llvm-toolchain target is still
912+
# required for the test.sh script.
913+
if(package_filename_extension STREQUAL ".tar.xz" OR package_filename_extension STREQUAL ".zip")
914+
add_subdirectory(packagetest)
915+
else()
916+
add_custom_target(check-package-llvm-toolchain)
917+
endif()
909918

910919
if(LLVM_TOOLCHAIN_CROSS_BUILD_MINGW)
911920
find_program(MINGW_C_EXECUTABLE x86_64-w64-mingw32-gcc-posix REQUIRED)

0 commit comments

Comments
 (0)