Skip to content

Commit 22e8707

Browse files
Icohedrongithub-actions[bot]
Icohedron
authored and
github-actions[bot]
committed
Automerge: [DirectX] Update lifetime legalization to account for the removed size argument (#152791)
Fixes #152754 - Fixes the ArgOperand index in `DXILOpLowering.cpp` used to obtain the pointer operand of a lifetime intrinsic. - Updates the tests `llvm/test/CodeGen/DirectX/legalize-lifetimes-valver-1.5.ll`, `llvm/test/CodeGen/DirectX/legalize-lifetimes-valver-1.6.ll`, `llvm/test/CodeGen/DirectX/ShaderFlags/lifetimes-noint64op.ll`, and `llvm/test/tools/dxil-dis/lifetimes.ll` to use the new size-less lifetime intrinsic - Removes lifetime intrinsics from the test `llvm/test/CodeGen/DirectX/legalize-memset.ll` to be consistent with the corresponding memcpy test which does not have lifetime intrinsics. (Removal of lifetime intrinsics from tests like this was suggested here in the past: llvm/llvm-project#139173 (comment)) - Rewrites the lifetime legalization functions in the EmbedDXILPass to re-add the explicit size argument for DXIL
2 parents b1e89f4 + e13cb3e commit 22e8707

File tree

7 files changed

+84
-74
lines changed

7 files changed

+84
-74
lines changed

‎llvm/lib/Target/DirectX/DXILOpLowering.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -746,7 +746,7 @@ class OpLowerer {
746746
IRBuilder<> &IRB = OpBuilder.getIRB();
747747
return replaceFunction(F, [&](CallInst *CI) -> Error {
748748
IRB.SetInsertPoint(CI);
749-
Value *Ptr = CI->getArgOperand(1);
749+
Value *Ptr = CI->getArgOperand(0);
750750
assert(Ptr->getType()->isPointerTy() &&
751751
"Expected operand of lifetime intrinsic to be a pointer");
752752

‎llvm/lib/Target/DirectX/DXILWriter/DXILWriterPass.cpp‎

Lines changed: 67 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,15 @@
1313
#include "DXILWriterPass.h"
1414
#include "DXILBitcodeWriter.h"
1515
#include "llvm/ADT/DenseMap.h"
16+
#include "llvm/ADT/STLExtras.h"
1617
#include "llvm/ADT/StringRef.h"
1718
#include "llvm/Analysis/ModuleSummaryAnalysis.h"
1819
#include "llvm/IR/Constants.h"
20+
#include "llvm/IR/DerivedTypes.h"
1921
#include "llvm/IR/GlobalVariable.h"
2022
#include "llvm/IR/IntrinsicInst.h"
23+
#include "llvm/IR/Intrinsics.h"
24+
#include "llvm/IR/LLVMContext.h"
2125
#include "llvm/IR/Module.h"
2226
#include "llvm/IR/PassManager.h"
2327
#include "llvm/InitializePasses.h"
@@ -54,49 +58,81 @@ class WriteDXILPass : public llvm::ModulePass {
5458
};
5559

5660
static void legalizeLifetimeIntrinsics(Module &M) {
57-
for (Function &F : M) {
58-
Intrinsic::ID IID = F.getIntrinsicID();
59-
if (IID != Intrinsic::lifetime_start && IID != Intrinsic::lifetime_end)
61+
LLVMContext &Ctx = M.getContext();
62+
Type *I64Ty = IntegerType::get(Ctx, 64);
63+
Type *PtrTy = PointerType::get(Ctx, 0);
64+
Intrinsic::ID LifetimeIIDs[2] = {Intrinsic::lifetime_start,
65+
Intrinsic::lifetime_end};
66+
for (Intrinsic::ID &IID : LifetimeIIDs) {
67+
Function *F = M.getFunction(Intrinsic::getName(IID, {PtrTy}, &M));
68+
if (!F)
6069
continue;
6170

62-
// Lifetime intrinsics in LLVM 3.7 do not have the memory FnAttr
63-
F.removeFnAttr(Attribute::Memory);
64-
65-
// Lifetime intrinsics in LLVM 3.7 do not have mangled names
66-
F.setName(Intrinsic::getBaseName(IID));
67-
68-
// LLVM 3.7 Lifetime intrinics require an i8* operand, so we insert bitcasts
69-
// to ensure that is the case
70-
for (auto *User : make_early_inc_range(F.users())) {
71-
CallInst *CI = dyn_cast<CallInst>(User);
72-
assert(CI && "Expected user of a lifetime intrinsic function to be a "
73-
"lifetime intrinsic call");
74-
Value *PtrOperand = CI->getArgOperand(1);
75-
PointerType *PtrTy = cast<PointerType>(PtrOperand->getType());
71+
// Get or insert an LLVM 3.7-compliant lifetime intrinsic function of the
72+
// form `void @llvm.lifetime.[start/end](i64, ptr)` with the NoUnwind
73+
// attribute
74+
AttributeList Attr;
75+
Attr = Attr.addFnAttribute(Ctx, Attribute::NoUnwind);
76+
FunctionCallee LifetimeCallee = M.getOrInsertFunction(
77+
Intrinsic::getBaseName(IID), Attr, Type::getVoidTy(Ctx), I64Ty, PtrTy);
78+
79+
// Replace all calls to lifetime intrinsics with calls to the
80+
// LLVM 3.7-compliant version of the lifetime intrinsic
81+
for (User *U : make_early_inc_range(F->users())) {
82+
CallInst *CI = dyn_cast<CallInst>(U);
83+
assert(CI &&
84+
"Expected user of a lifetime intrinsic function to be a CallInst");
85+
86+
// LLVM 3.7 lifetime intrinics require an i8* operand, so we insert
87+
// a bitcast to ensure that is the case
88+
Value *PtrOperand = CI->getArgOperand(0);
89+
PointerType *PtrOpPtrTy = cast<PointerType>(PtrOperand->getType());
7690
Value *NoOpBitCast = CastInst::Create(Instruction::BitCast, PtrOperand,
77-
PtrTy, "", CI->getIterator());
78-
CI->setArgOperand(1, NoOpBitCast);
91+
PtrOpPtrTy, "", CI->getIterator());
92+
93+
// LLVM 3.7 lifetime intrinsics have an explicit size operand, whose value
94+
// we can obtain from the pointer operand which must be an AllocaInst (as
95+
// of https://github.com/llvm/llvm-project/pull/149310)
96+
AllocaInst *AI = dyn_cast<AllocaInst>(PtrOperand);
97+
assert(AI &&
98+
"The pointer operand of a lifetime intrinsic call must be an "
99+
"AllocaInst");
100+
std::optional<TypeSize> AllocSize =
101+
AI->getAllocationSize(CI->getDataLayout());
102+
assert(AllocSize.has_value() &&
103+
"Expected the allocation size of AllocaInst to be known");
104+
CallInst *NewCI = CallInst::Create(
105+
LifetimeCallee,
106+
{ConstantInt::get(I64Ty, AllocSize.value().getFixedValue()),
107+
NoOpBitCast},
108+
"", CI->getIterator());
109+
for (Attribute ParamAttr : CI->getParamAttributes(0))
110+
NewCI->addParamAttr(1, ParamAttr);
111+
112+
CI->eraseFromParent();
79113
}
114+
115+
F->eraseFromParent();
80116
}
81117
}
82118

83119
static void removeLifetimeIntrinsics(Module &M) {
84-
for (Function &F : make_early_inc_range(M)) {
85-
if (Intrinsic::ID IID = F.getIntrinsicID();
86-
IID != Intrinsic::lifetime_start && IID != Intrinsic::lifetime_end)
120+
Intrinsic::ID LifetimeIIDs[2] = {Intrinsic::lifetime_start,
121+
Intrinsic::lifetime_end};
122+
for (Intrinsic::ID &IID : LifetimeIIDs) {
123+
Function *F = M.getFunction(Intrinsic::getBaseName(IID));
124+
if (!F)
87125
continue;
88126

89-
for (User *U : make_early_inc_range(F.users())) {
90-
LifetimeIntrinsic *LI = dyn_cast<LifetimeIntrinsic>(U);
91-
assert(LI && "Expected user of lifetime intrinsic function to be "
92-
"a LifetimeIntrinsic instruction");
93-
BitCastInst *BCI = dyn_cast<BitCastInst>(LI->getArgOperand(1));
94-
assert(BCI && "Expected pointer operand of LifetimeIntrinsic to be a "
95-
"BitCastInst");
96-
LI->eraseFromParent();
127+
for (User *U : make_early_inc_range(F->users())) {
128+
CallInst *CI = dyn_cast<CallInst>(U);
129+
assert(CI && "Expected user of lifetime function to be a CallInst");
130+
BitCastInst *BCI = dyn_cast<BitCastInst>(CI->getArgOperand(1));
131+
assert(BCI && "Expected pointer operand of CallInst to be a BitCastInst");
132+
CI->eraseFromParent();
97133
BCI->eraseFromParent();
98134
}
99-
F.eraseFromParent();
135+
F->eraseFromParent();
100136
}
101137
}
102138

‎llvm/test/CodeGen/DirectX/ShaderFlags/lifetimes-noint64op.ll‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,16 @@ target triple = "dxil-pc-shadermodel6.7-library"
1515

1616
define void @lifetimes() #0 {
1717
%a = alloca [4 x i32], align 8
18-
call void @llvm.lifetime.start.p0(i64 16, ptr nonnull %a)
19-
call void @llvm.lifetime.end.p0(i64 16, ptr nonnull %a)
18+
call void @llvm.lifetime.start.p0(ptr nonnull %a)
19+
call void @llvm.lifetime.end.p0(ptr nonnull %a)
2020
ret void
2121
}
2222

2323
; Function Attrs: nounwind memory(argmem: readwrite)
24-
declare void @llvm.lifetime.start.p0(i64, ptr) #1
24+
declare void @llvm.lifetime.start.p0(ptr) #1
2525

2626
; Function Attrs: nounwind memory(argmem: readwrite)
27-
declare void @llvm.lifetime.end.p0(i64, ptr) #1
27+
declare void @llvm.lifetime.end.p0(ptr) #1
2828

2929
attributes #0 = { convergent norecurse nounwind "hlsl.export"}
3030
attributes #1 = { nounwind memory(argmem: readwrite) }

‎llvm/test/CodeGen/DirectX/legalize-lifetimes-valver-1.5.ll‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111
define void @test_legal_lifetime() {
1212
%accum.i.flat = alloca [1 x i32], align 4
1313
%gep = getelementptr i32, ptr %accum.i.flat, i32 0
14-
call void @llvm.lifetime.start.p0(i64 4, ptr nonnull %accum.i.flat)
14+
call void @llvm.lifetime.start.p0(ptr nonnull %accum.i.flat)
1515
store i32 0, ptr %gep, align 4
16-
call void @llvm.lifetime.end.p0(i64 4, ptr nonnull %accum.i.flat)
16+
call void @llvm.lifetime.end.p0(ptr nonnull %accum.i.flat)
1717
ret void
1818
}
1919

‎llvm/test/CodeGen/DirectX/legalize-lifetimes-valver-1.6.ll‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,22 +13,22 @@
1313
; CHECK-NEXT: [[ACCUM_I_FLAT:%.*]] = alloca [1 x i32], align 4
1414
; CHECK-NEXT: [[GEP:%.*]] = getelementptr i32, ptr [[ACCUM_I_FLAT]], i32 0
1515
; CHECK-SM63-NEXT: store [1 x i32] undef, ptr [[ACCUM_I_FLAT]], align 4
16-
; CHECK-SM66-NEXT: call void @llvm.lifetime.start.p0(i64 4, ptr nonnull [[ACCUM_I_FLAT]])
16+
; CHECK-SM66-NEXT: call void @llvm.lifetime.start.p0(ptr nonnull [[ACCUM_I_FLAT]])
1717
; CHECK-EMBED-NOT: bitcast
1818
; CHECK-EMBED-NOT: lifetime
1919
; CHECK-NEXT: store i32 0, ptr [[GEP]], align 4
2020
; CHECK-SM63-NEXT: store [1 x i32] undef, ptr [[ACCUM_I_FLAT]], align 4
21-
; CHECK-SM66-NEXT: call void @llvm.lifetime.end.p0(i64 4, ptr nonnull [[ACCUM_I_FLAT]])
21+
; CHECK-SM66-NEXT: call void @llvm.lifetime.end.p0(ptr nonnull [[ACCUM_I_FLAT]])
2222
; CHECK-EMBED-NOT: bitcast
2323
; CHECK-EMBED-NOT: lifetime
2424
; CHECK-NEXT: ret void
2525
;
2626
define void @test_legal_lifetime() {
2727
%accum.i.flat = alloca [1 x i32], align 4
2828
%gep = getelementptr i32, ptr %accum.i.flat, i32 0
29-
call void @llvm.lifetime.start.p0(i64 4, ptr nonnull %accum.i.flat)
29+
call void @llvm.lifetime.start.p0(ptr nonnull %accum.i.flat)
3030
store i32 0, ptr %gep, align 4
31-
call void @llvm.lifetime.end.p0(i64 4, ptr nonnull %accum.i.flat)
31+
call void @llvm.lifetime.end.p0(ptr nonnull %accum.i.flat)
3232
ret void
3333
}
3434

‎llvm/test/CodeGen/DirectX/legalize-memset.ll‎

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -5,92 +5,72 @@ define void @replace_float_memset_test() #0 {
55
; CHECK-LABEL: define void @replace_float_memset_test(
66
; CHECK-SAME: ) #[[ATTR0:[0-9]+]] {
77
; CHECK-NEXT: [[ACCUM_I_FLAT:%.*]] = alloca [2 x float], align 4
8-
; CHECK-NEXT: call void @llvm.lifetime.start.p0(i64 8, ptr nonnull [[ACCUM_I_FLAT]])
98
; CHECK-NEXT: [[GEP:%.*]] = getelementptr [2 x float], ptr [[ACCUM_I_FLAT]], i32 0, i32 0
109
; CHECK-NEXT: store float 0.000000e+00, ptr [[GEP]], align 4
1110
; CHECK-NEXT: [[GEP1:%.*]] = getelementptr [2 x float], ptr [[ACCUM_I_FLAT]], i32 0, i32 1
1211
; CHECK-NEXT: store float 0.000000e+00, ptr [[GEP1]], align 4
13-
; CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 8, ptr nonnull [[ACCUM_I_FLAT]])
1412
; CHECK-NEXT: ret void
1513
;
1614
%accum.i.flat = alloca [2 x float], align 4
17-
call void @llvm.lifetime.start.p0(i64 8, ptr nonnull %accum.i.flat)
1815
call void @llvm.memset.p0.i32(ptr nonnull align 4 dereferenceable(8) %accum.i.flat, i8 0, i32 8, i1 false)
19-
call void @llvm.lifetime.end.p0(i64 8, ptr nonnull %accum.i.flat)
2016
ret void
2117
}
2218

2319
define void @replace_half_memset_test() #0 {
2420
; CHECK-LABEL: define void @replace_half_memset_test(
2521
; CHECK-SAME: ) #[[ATTR0]] {
2622
; CHECK-NEXT: [[ACCUM_I_FLAT:%.*]] = alloca [2 x half], align 4
27-
; CHECK-NEXT: call void @llvm.lifetime.start.p0(i64 4, ptr nonnull [[ACCUM_I_FLAT]])
2823
; CHECK-NEXT: [[GEP:%.*]] = getelementptr [2 x half], ptr [[ACCUM_I_FLAT]], i32 0, i32 0
2924
; CHECK-NEXT: store half 0xH0000, ptr [[GEP]], align 2
3025
; CHECK-NEXT: [[GEP1:%.*]] = getelementptr [2 x half], ptr [[ACCUM_I_FLAT]], i32 0, i32 1
3126
; CHECK-NEXT: store half 0xH0000, ptr [[GEP1]], align 2
32-
; CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 4, ptr nonnull [[ACCUM_I_FLAT]])
3327
; CHECK-NEXT: ret void
3428
;
3529
%accum.i.flat = alloca [2 x half], align 4
36-
call void @llvm.lifetime.start.p0(i64 4, ptr nonnull %accum.i.flat)
3730
call void @llvm.memset.p0.i32(ptr nonnull align 4 dereferenceable(8) %accum.i.flat, i8 0, i32 4, i1 false)
38-
call void @llvm.lifetime.end.p0(i64 4, ptr nonnull %accum.i.flat)
3931
ret void
4032
}
4133

4234
define void @replace_double_memset_test() #0 {
4335
; CHECK-LABEL: define void @replace_double_memset_test(
4436
; CHECK-SAME: ) #[[ATTR0]] {
4537
; CHECK-NEXT: [[ACCUM_I_FLAT:%.*]] = alloca [2 x double], align 4
46-
; CHECK-NEXT: call void @llvm.lifetime.start.p0(i64 16, ptr nonnull [[ACCUM_I_FLAT]])
4738
; CHECK-NEXT: [[GEP:%.*]] = getelementptr [2 x double], ptr [[ACCUM_I_FLAT]], i32 0, i32 0
4839
; CHECK-NEXT: store double 0.000000e+00, ptr [[GEP]], align 8
4940
; CHECK-NEXT: [[GEP1:%.*]] = getelementptr [2 x double], ptr [[ACCUM_I_FLAT]], i32 0, i32 1
5041
; CHECK-NEXT: store double 0.000000e+00, ptr [[GEP1]], align 8
51-
; CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 16, ptr nonnull [[ACCUM_I_FLAT]])
5242
; CHECK-NEXT: ret void
5343
;
5444
%accum.i.flat = alloca [2 x double], align 4
55-
call void @llvm.lifetime.start.p0(i64 16, ptr nonnull %accum.i.flat)
5645
call void @llvm.memset.p0.i32(ptr nonnull align 4 dereferenceable(8) %accum.i.flat, i8 0, i32 16, i1 false)
57-
call void @llvm.lifetime.end.p0(i64 16, ptr nonnull %accum.i.flat)
5846
ret void
5947
}
6048

6149
define void @replace_int16_memset_test() #0 {
6250
; CHECK-LABEL: define void @replace_int16_memset_test(
6351
; CHECK-SAME: ) #[[ATTR0]] {
6452
; CHECK-NEXT: [[CACHE_I:%.*]] = alloca [2 x i16], align 2
65-
; CHECK-NEXT: call void @llvm.lifetime.start.p0(i64 4, ptr nonnull [[CACHE_I]])
6653
; CHECK-NEXT: [[GEP:%.*]] = getelementptr [2 x i16], ptr [[CACHE_I]], i32 0, i32 0
6754
; CHECK-NEXT: store i16 0, ptr [[GEP]], align 2
6855
; CHECK-NEXT: [[GEP1:%.*]] = getelementptr [2 x i16], ptr [[CACHE_I]], i32 0, i32 1
6956
; CHECK-NEXT: store i16 0, ptr [[GEP1]], align 2
70-
; CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 4, ptr nonnull [[CACHE_I]])
7157
; CHECK-NEXT: ret void
7258
;
7359
%cache.i = alloca [2 x i16], align 2
74-
call void @llvm.lifetime.start.p0(i64 4, ptr nonnull %cache.i)
7560
call void @llvm.memset.p0.i32(ptr nonnull align 2 dereferenceable(4) %cache.i, i8 0, i32 4, i1 false)
76-
call void @llvm.lifetime.end.p0(i64 4, ptr nonnull %cache.i)
7761
ret void
7862
}
7963

8064
define void @replace_int_memset_test() #0 {
8165
; CHECK-LABEL: define void @replace_int_memset_test(
8266
; CHECK-SAME: ) #[[ATTR0]] {
8367
; CHECK-NEXT: [[ACCUM_I_FLAT:%.*]] = alloca [1 x i32], align 4
84-
; CHECK-NEXT: call void @llvm.lifetime.start.p0(i64 4, ptr nonnull [[ACCUM_I_FLAT]])
8568
; CHECK-NEXT: [[GEP:%.*]] = getelementptr [1 x i32], ptr [[ACCUM_I_FLAT]], i32 0, i32 0
8669
; CHECK-NEXT: store i32 0, ptr [[GEP]], align 4
87-
; CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 4, ptr nonnull [[ACCUM_I_FLAT]])
8870
; CHECK-NEXT: ret void
8971
;
9072
%accum.i.flat = alloca [1 x i32], align 4
91-
call void @llvm.lifetime.start.p0(i64 4, ptr nonnull %accum.i.flat)
9273
call void @llvm.memset.p0.i32(ptr nonnull align 4 dereferenceable(8) %accum.i.flat, i8 0, i32 4, i1 false)
93-
call void @llvm.lifetime.end.p0(i64 4, ptr nonnull %accum.i.flat)
9474
ret void
9575
}
9676

@@ -101,25 +81,19 @@ define void @replace_int_memset_to_var_test() #0 {
10181
; CHECK-NEXT: [[I:%.*]] = alloca i32, align 4
10282
; CHECK-NEXT: store i32 1, ptr [[I]], align 4
10383
; CHECK-NEXT: [[I8_LOAD:%.*]] = load i32, ptr [[I]], align 4
104-
; CHECK-NEXT: call void @llvm.lifetime.start.p0(i64 4, ptr nonnull [[ACCUM_I_FLAT]])
10584
; CHECK-NEXT: [[GEP:%.*]] = getelementptr [1 x i32], ptr [[ACCUM_I_FLAT]], i32 0, i32 0
10685
; CHECK-NEXT: store i32 [[I8_LOAD]], ptr [[GEP]], align 4
107-
; CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 4, ptr nonnull [[ACCUM_I_FLAT]])
10886
; CHECK-NEXT: ret void
10987
;
11088
%accum.i.flat = alloca [1 x i32], align 4
11189
%i = alloca i8, align 4
11290
store i8 1, ptr %i
11391
%i8.load = load i8, ptr %i
114-
call void @llvm.lifetime.start.p0(i64 4, ptr nonnull %accum.i.flat)
11592
call void @llvm.memset.p0.i32(ptr nonnull align 4 dereferenceable(8) %accum.i.flat, i8 %i8.load, i32 4, i1 false)
116-
call void @llvm.lifetime.end.p0(i64 4, ptr nonnull %accum.i.flat)
11793
ret void
11894
}
11995

12096
attributes #0 = {"hlsl.export"}
12197

12298

123-
declare void @llvm.lifetime.end.p0(i64 immarg, ptr captures(none))
124-
declare void @llvm.lifetime.start.p0(i64 immarg, ptr captures(none))
12599
declare void @llvm.memset.p0.i32(ptr writeonly captures(none), i8, i32, i1 immarg)

‎llvm/test/tools/dxil-dis/lifetimes.ll‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,17 @@ define void @test_lifetimes() {
66
; CHECK-NEXT: [[ALLOCA:%.*]] = alloca [2 x i32], align 4
77
; CHECK-NEXT: [[GEP:%.*]] = getelementptr [2 x i32], [2 x i32]* [[ALLOCA]], i32 0, i32 0
88
; CHECK-NEXT: [[BITCAST:%.*]] = bitcast [2 x i32]* [[ALLOCA]] to i8*
9-
; CHECK-NEXT: call void @llvm.lifetime.start(i64 4, i8* nonnull [[BITCAST]])
9+
; CHECK-NEXT: call void @llvm.lifetime.start(i64 8, i8* nonnull [[BITCAST]])
1010
; CHECK-NEXT: store i32 0, i32* [[GEP]], align 4
1111
; CHECK-NEXT: [[BITCAST:%.*]] = bitcast [2 x i32]* [[ALLOCA]] to i8*
12-
; CHECK-NEXT: call void @llvm.lifetime.end(i64 4, i8* nonnull [[BITCAST]])
12+
; CHECK-NEXT: call void @llvm.lifetime.end(i64 8, i8* nonnull [[BITCAST]])
1313
; CHECK-NEXT: ret void
1414
;
1515
%a = alloca [2 x i32], align 4
1616
%gep = getelementptr [2 x i32], ptr %a, i32 0, i32 0
17-
call void @llvm.lifetime.start.p0(i64 4, ptr nonnull %a)
17+
call void @llvm.lifetime.start.p0(ptr nonnull %a)
1818
store i32 0, ptr %gep, align 4
19-
call void @llvm.lifetime.end.p0(i64 4, ptr nonnull %a)
19+
call void @llvm.lifetime.end.p0(ptr nonnull %a)
2020
ret void
2121
}
2222

@@ -29,10 +29,10 @@ define void @test_lifetimes() {
2929
; CHECK-DAG: declare void @llvm.lifetime.end(i64, i8* nocapture) [[LIFETIME_ATTRS]]
3030

3131
; Function Attrs: nounwind memory(argmem: readwrite)
32-
declare void @llvm.lifetime.end.p0(i64, ptr) #0
32+
declare void @llvm.lifetime.end.p0(ptr) #0
3333

3434
; Function Attrs: nounwind memory(argmem: readwrite)
35-
declare void @llvm.lifetime.start.p0(i64, ptr) #0
35+
declare void @llvm.lifetime.start.p0(ptr) #0
3636

3737
attributes #0 = { nounwind memory(argmem: readwrite) }
3838

0 commit comments

Comments
 (0)