[ATfE]: Enable sanitizer for ATfE as 2-stage pipeline (#464)

[ATfE]: Enable address sanitizer for ATfE as 2-stage pipeline

Author: vrukesh

arm-software/embedded/scripts/build_atfe_address_sanitizer.sh renamed to arm-software/embedded/scripts/build_atfe_sanitizer.sh

@@ -7,6 +7,9 @@
 
 # A bash script to build the Arm Toolchain for Embedded, with address sanitizer enabled.
 
+# Script implements 2-stage pipeline: first clang is built using arm-toolchain sources.
+# Then this clang is used to compile ATfE sanitizer build.
+#
 # The script creates a build of the toolchain in the 'build' directory, inside
 # the repository tree.
 
@@ -23,11 +26,23 @@ clang --version
 export CC=clang
 export CXX=clang++
 
-# Get processor count, to execute job in parallel threads
-PROCESSOR_COUNT=$(getconf _NPROCESSORS_ONLN)
+# Stage 1: Compile clang
+mkdir -p "${REPO_ROOT}"/build_llvm
+cd "${REPO_ROOT}"/build_llvm
 
-# Disable memory leaks detection of LeakSanitizer
-export ASAN_OPTIONS=detect_leaks=0
+cmake ../llvm -G Ninja \
+    -DLLVM_ENABLE_PROJECTS="clang;llvm;lld" \
+    -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind;compiler-rt" \
+    -DCMAKE_BUILD_TYPE=Release \
+    -DCLANG_DEFAULT_LINKER="lld"
+
+ninja
+
+echo "==> Stage 1: Completed clang build"
+
+# Stage 2: Compile ATfE with sanitizer
+export CC="${REPO_ROOT}/build_llvm/bin/clang"
+export CXX="${REPO_ROOT}/build_llvm/bin/clang++"
 
 if [[ ! -z "${FVP_INSTALL_DIR}" ]]; then
     EXTRA_CMAKE_ARGS="${EXTRA_CMAKE_ARGS} -DENABLE_FVP_TESTING=ON -DFVP_INSTALL_DIR=${FVP_INSTALL_DIR}"
@@ -36,6 +51,11 @@ fi
 mkdir -p "${REPO_ROOT}"/build
 cd "${REPO_ROOT}"/build
 
-cmake ../arm-software/embedded -GNinja -DFETCHCONTENT_QUIET=OFF -DCMAKE_BUILD_TYPE=Release -DLLVM_USE_SANITIZER="Address" -DLLVM_ENABLE_ASSERTIONS=ON ${EXTRA_CMAKE_ARGS}
+# Enable below flag to disable memory leaks detection of LeakSanitizer.
+# export ASAN_OPTIONS=detect_leaks=0
+
+cmake ../arm-software/embedded -GNinja -DFETCHCONTENT_QUIET=OFF -DCMAKE_C_COMPILER=$CC -DCMAKE_CXX_COMPILER=$CXX -DCMAKE_BUILD_TYPE=Release -DLLVM_USE_SANITIZER="Address;Undefined" -DLLVM_ENABLE_ASSERTIONS=ON ${EXTRA_CMAKE_ARGS}
+
+ninja package-llvm-toolchain
 
-ninja -j$PROCESSOR_COUNT package-llvm-toolchain
+echo "==> Stage 2: Completed sanitizer build"

arm-software/embedded/scripts/test_atfe_sanitizer.sh

@@ -18,9 +18,6 @@ set -vx
 SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
 REPO_ROOT=$( git -C "${SCRIPT_DIR}" rev-parse --show-toplevel )
 
-# Get processor count, to execute job in parallel threads
-PROCESSOR_COUNT=$(getconf _NPROCESSORS_ONLN)
-
 cd "${REPO_ROOT}"/build
 
 # If a test fails, lit will ordinarily return a non-zero result,
@@ -32,15 +29,15 @@ cd "${REPO_ROOT}"/build
 # Additionally setting the --xunit-xml-output option store the
 # results.
 export LIT_OPTS="--ignore-fail --xunit-xml-output=results.xml"
-ninja -j$PROCESSOR_COUNT check-all
+ninja check-all
 
 # The llvm-toolchain targets already set --xunit-xml-output so
 # only the --ignore-fail option is needed.
 # The picolibc tests do not use lit so do not support this option.
 # Command for each test is splitted across individual lines, to aid in debugging.
 export LIT_OPTS="--ignore-fail"
-ninja -j$PROCESSOR_COUNT check-compiler-rt-armv7m_hard_fpv5_d16_exn_rtti_unaligned_size
-ninja -j$PROCESSOR_COUNT check-picolibc-armv7m_hard_fpv5_d16_exn_rtti_unaligned_size
-ninja -j$PROCESSOR_COUNT check-cxx-armv7m_hard_fpv5_d16_exn_rtti_unaligned_size
-ninja -j$PROCESSOR_COUNT check-cxxabi-armv7m_hard_fpv5_d16_exn_rtti_unaligned_size
-ninja -j$PROCESSOR_COUNT check-unwind-armv7m_hard_fpv5_d16_exn_rtti_unaligned_size
+ninja check-compiler-rt-armv7m_hard_fpv5_d16_exn_rtti_unaligned_size
+ninja check-picolibc-armv7m_hard_fpv5_d16_exn_rtti_unaligned_size
+ninja check-cxx-armv7m_hard_fpv5_d16_exn_rtti_unaligned_size
+ninja check-cxxabi-armv7m_hard_fpv5_d16_exn_rtti_unaligned_size
+ninja check-unwind-armv7m_hard_fpv5_d16_exn_rtti_unaligned_size