[ATfE] v8-M library naming and selection issues for strict alignment builds. (#250)

We don’t have a -mno-unaligned-access specific variant for the v8M libraries. For v8-M with strict aligned access, it’s more appropriate to use the v7-M variants, as they include a version with strict alignment support. It was a deliberate decision to provide strict-alignment variants only for a subset of architectures.

To support this, both -mno-unaligned-access and -munaligned-access options must be passed into the multilib selection logic. This aligns with the approach in llvm/llvm-project#134099, which also considers the target architecture when determining the alignment access policy. Since Armv6-M does not support unaligned accesses, test changes are needed to reflect the updated behaviour when the target architecture is taken into account.

This patch fixes below issues.

1. The naming of the v8-M libraries should explicitly include
‘unaligned’ to reflect their behaviour.

2. When using -mno-unaligned-access, the multilib system should instead
select the v7-M variant.

3. Armv6m test changes are needed to reflect the updated behaviour when
the target architecture is taken into account.

(cherry picked from commit 8c3bbfc)

Author: simpal01

arm-software/embedded/arm-multilib/json/multilib.json

@@ -441,24 +441,24 @@
             "flags": "--target=thumbebv7m-unknown-none-eabi -mfpu=none -fno-exceptions -fno-rtti"
         },
         {
-            "variant": "armv8m.main_soft_nofp_exn_rtti",
-            "json": "armv8m.main_soft_nofp_exn_rtti.json",
-            "flags": "--target=thumbv8m.main-unknown-none-eabi -mfpu=none"
+            "variant": "armv8m.main_soft_nofp_exn_rtti_unaligned",
+            "json": "armv8m.main_soft_nofp_exn_rtti_unaligned.json",
+            "flags": "--target=thumbv8m.main-unknown-none-eabi -mfpu=none -munaligned-access"
         },
         {
-            "variant": "armv8m.main_soft_nofp",
-            "json": "armv8m.main_soft_nofp.json",
-            "flags": "--target=thumbv8m.main-unknown-none-eabi -mfpu=none -fno-exceptions -fno-rtti"
+            "variant": "armv8m.main_soft_nofp_unaligned",
+            "json": "armv8m.main_soft_nofp_unaligned.json",
+            "flags": "--target=thumbv8m.main-unknown-none-eabi -mfpu=none -fno-exceptions -fno-rtti -munaligned-access"
         },
         {
-            "variant": "armv8m.main_hard_fp_exn_rtti",
-            "json": "armv8m.main_hard_fp_exn_rtti.json",
-            "flags": "--target=thumbv8m.main-unknown-none-eabihf -mfpu=fpv5-sp-d16"
+            "variant": "armv8m.main_hard_fp_exn_rtti_unaligned",
+            "json": "armv8m.main_hard_fp_exn_rtti_unaligned.json",
+            "flags": "--target=thumbv8m.main-unknown-none-eabihf -mfpu=fpv5-sp-d16 -munaligned-access"
         },
         {
-            "variant": "armv8m.main_hard_fp",
-            "json": "armv8m.main_hard_fp.json",
-            "flags": "--target=thumbv8m.main-unknown-none-eabihf -mfpu=fpv5-sp-d16 -fno-exceptions -fno-rtti"
+            "variant": "armv8m.main_hard_fp_unaligned",
+            "json": "armv8m.main_hard_fp_unaligned.json",
+            "flags": "--target=thumbv8m.main-unknown-none-eabihf -mfpu=fpv5-sp-d16 -fno-exceptions -fno-rtti -munaligned-access"
         },
         {
             "variant": "armv8.1m.main_soft_nofp_nomve_exn_rtti",

arm-software/embedded/arm-multilib/json/variants/armv8m.main_hard_fp_exn_rtti.json renamed to arm-software/embedded/arm-multilib/json/variants/armv8m.main_hard_fp_exn_rtti_unaligned.json

@@ -1,15 +1,9 @@
-# RUN: %clang -print-multi-directory --target=armv6m-none-eabi -mfpu=none | FileCheck %s --check-prefix=CHECK-NOFP-EXN-RTTI-UNALIGNED
-# CHECK-NOFP-EXN-RTTI-UNALIGNED: arm-none-eabi/armv6m_soft_nofp_exn_rtti_unaligned{{$}}
-# CHECK-NOFP-EXN-RTTI-UNALIGNED-EMPTY:
-
+# RUN: %clang -print-multi-directory --target=armv6m-none-eabi -mfpu=none | FileCheck %s --check-prefix=CHECK-NOFP-EXN-RTTI
 # RUN: %clang -print-multi-directory --target=armv6m-none-eabi -mfpu=none -mno-unaligned-access | FileCheck %s --check-prefix=CHECK-NOFP-EXN-RTTI
 # CHECK-NOFP-EXN-RTTI: arm-none-eabi/armv6m_soft_nofp_exn_rtti{{$}}
 # CHECK-NOFP-EXN-RTTI-EMPTY:
 
-# RUN: %clang -print-multi-directory --target=armv6m-none-eabi -mfpu=none -fno-exceptions -fno-rtti | FileCheck %s --check-prefix=CHECK-NOFP-UNALIGNED
-# CHECK-NOFP-UNALIGNED: arm-none-eabi/armv6m_soft_nofp_unaligned{{$}}
-# CHECK-NOFP-UNALIGNED-EMPTY:
-
+# RUN: %clang -print-multi-directory --target=armv6m-none-eabi -mfpu=none -fno-exceptions -fno-rtti | FileCheck %s --check-prefix=CHECK-NOFP
 # RUN: %clang -print-multi-directory --target=armv6m-none-eabi -mfpu=none -fno-exceptions -fno-rtti -mno-unaligned-access | FileCheck %s --check-prefix=CHECK-NOFP
 # CHECK-NOFP: arm-none-eabi/armv6m_soft_nofp{{$}}
 # CHECK-NOFP-EMPTY:

arm-software/embedded/arm-multilib/json/variants/armv8m.main_hard_fp.json renamed to arm-software/embedded/arm-multilib/json/variants/armv8m.main_hard_fp_unaligned.json

@@ -1,12 +1,20 @@
 # RUN: %clang -print-multi-directory --target=armv8m.main-none-eabi -mfpu=none | FileCheck %s
-# CHECK: arm-none-eabi/armv8m.main_soft_nofp_exn_rtti{{$}}
+# CHECK: arm-none-eabi/armv8m.main_soft_nofp_exn_rtti_unaligned{{$}}
 # CHECK-EMPTY:
 
 # RUN: %clang -print-multi-directory --target=armv8m.main-none-eabihf -mfpu=fpv5-sp-d16 | FileCheck --check-prefix=HARD %s
-# HARD: arm-none-eabi/armv8m.main_hard_fp_exn_rtti{{$}}
+# HARD: arm-none-eabi/armv8m.main_hard_fp_exn_rtti_unaligned{{$}}
 # HARD-EMPTY:
 
 # Fallback to armv7m
+# RUN: %clang -print-multi-directory --target=armv8m.main-none-eabi -mfpu=none -mno-unaligned-access | FileCheck --check-prefix=NOFP %s
+# NOFP: arm-none-eabi/armv7m_soft_nofp_exn_rtti{{$}}
+# NOFP-EMPTY:
+
 # RUN: %clang -print-multi-directory --target=armv8m.main-none-eabi -mfpu=fpv5-sp-d16 | FileCheck --check-prefix=SOFTFP %s
 # SOFTFP: arm-none-eabi/armv7m_soft_fpv4_sp_d16_exn_rtti_unaligned{{$}}
 # SOFTFP-EMPTY:
+
+# RUN: %clang -print-multi-directory --target=armv8m.main-none-eabihf -mfpu=fpv5-sp-d16 -mno-unaligned-access | FileCheck --check-prefix=HARDFP %s
+# HARDFP: arm-none-eabi/armv7m_hard_fpv4_sp_d16_exn_rtti{{$}}
+# HARDFP-EMPTY: