Skip to content

Commit 31883bd

Browse files
rampitecgithub-actions[bot]
authored andcommitted
Automerge: [AMDGPU] gfx1250 does not need nop before VGPR dealloc (#153844)
This has no impact as the dealloc is now practically disabled.
2 parents 4b2f326 + 5d28284 commit 31883bd

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

llvm/lib/Target/AMDGPU/GCNSubtarget.h

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1799,11 +1799,7 @@ class GCNSubtarget final : public AMDGPUGenSubtargetInfo,
17991799

18001800
// \returns true if the subtarget has a hazard requiring an "s_nop 0"
18011801
// instruction before "s_sendmsg sendmsg(MSG_DEALLOC_VGPRS)".
1802-
bool requiresNopBeforeDeallocVGPRs() const {
1803-
// Currently all targets that support the dealloc VGPRs message also require
1804-
// the nop.
1805-
return true;
1806-
}
1802+
bool requiresNopBeforeDeallocVGPRs() const { return !GFX1250Insts; }
18071803

18081804
bool isDynamicVGPREnabled() const { return DynamicVGPR; }
18091805
unsigned getDynamicVGPRBlockSize() const {

0 commit comments

Comments
 (0)