Skip to content

Commit 41006c6

Browse files
philnik777github-actions[bot]
authored andcommitted
Automerge: [libc++][NFC] Use llvm.org/PR to link to bug reports (#156288)
We've built up quite a few links directly to github within the code base. We should instead use `llvm.org/PR<issue-number>` to link to bugs, since that is resilient to the bug tracker changing in the future. This is especially relevant for tests linking to bugs, since they will probably be there for decades to come. A nice side effect is that these links are significantly shorter than the GH links, making them much less of an eyesore. This patch also replaces a few links that linked to the old bugzilla instance on llvm.org.
2 parents 5a1fa9f + 34d4f0c commit 41006c6

File tree

207 files changed

+229
-238
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

207 files changed

+229
-238
lines changed

libcxx/CMakeLists.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -361,8 +361,7 @@ endif()
361361
if (NOT LIBCXX_ENABLE_RTTI AND LIBCXX_ENABLE_EXCEPTIONS)
362362
message(FATAL_ERROR "Libc++ cannot be built with exceptions enabled but RTTI"
363363
" disabled, since that configuration is broken. See"
364-
" https://github.com/llvm/llvm-project/issues/66117"
365-
" for details.")
364+
" https://llvm.org/PR66117 for details.")
366365
endif()
367366

368367
if (LIBCXX_ENABLE_ABI_LINKER_SCRIPT)

libcxx/docs/Modules.rst

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ Some of the current limitations
7272
* Clang:
7373
* Including headers after importing the ``std`` module may fail. This is
7474
hard to solve and there is a work-around by first including all headers
75-
`bug report <https://github.com/llvm/llvm-project/issues/61465>`__.
75+
`bug report <https://llvm.org/PR61465>`__.
7676

7777
Blockers
7878
~~~~~~~~
@@ -88,8 +88,7 @@ Blockers
8888

8989
* Clang
9090

91-
* Some concepts do not work properly
92-
`bug report <https://github.com/llvm/llvm-project/issues/62943>`__.
91+
* Some concepts do not work properly `bug report <https://llvm.org/PR61465>`__.
9392

9493

9594
Using in external projects

libcxx/docs/ReleaseNotes/22.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@ What's New in Libc++ 22.0.0?
3838
Implemented Papers
3939
------------------
4040

41-
- P2321R2: ``zip`` (`Github <https://github.com/llvm/llvm-project/issues/105169>`__) (The paper is partially
42-
implemented. ``zip_transform_view`` is implemented in this release)
43-
- P3168R2: Give ``std::optional`` Range Support (`Github <https://github.com/llvm/llvm-project/issues/105430>`__)
41+
- P2321R2: ``zip`` (`Github <https://llvm.org/PR105169>`__) (The paper is partially implemented. ``zip_transform_view``
42+
is implemented in this release)
43+
- P3168R2: Give ``std::optional`` Range Support (`Github <https://llvm.org/PR105430>`__)
4444

4545
Improvements and New Features
4646
-----------------------------

libcxx/docs/Status/Cxx17Papers.csv

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
"`P0013R1 <https://wg21.link/P0013R1>`__","Logical type traits rev 2","2015-10 (Kona)","|Complete|","3.8",""
2727
"","","","","",""
2828
"`P0024R2 <https://wg21.link/P0024R2>`__","The Parallelism TS Should be Standardized","2016-02 (Jacksonville)","|Partial|","",""
29-
"`P0226R1 <https://wg21.link/P0226R1>`__","Mathematical Special Functions for C++17","2016-02 (Jacksonville)","|In Progress|","","Progress is tracked `here <https://github.com/llvm/llvm-project/issues/99939>`__"
29+
"`P0226R1 <https://wg21.link/P0226R1>`__","Mathematical Special Functions for C++17","2016-02 (Jacksonville)","|In Progress|","","Progress is tracked `here <https://llvm.org/PR99939>`__"
3030
"`P0220R1 <https://wg21.link/P0220R1>`__","Adopt Library Fundamentals V1 TS Components for C++17","2016-02 (Jacksonville)","|Complete|","16",""
3131
"`P0218R1 <https://wg21.link/P0218R1>`__","Adopt the File System TS for C++17","2016-02 (Jacksonville)","|Complete|","7",""
3232
"`P0033R1 <https://wg21.link/P0033R1>`__","Re-enabling shared_from_this","2016-02 (Jacksonville)","|Complete|","3.9",""

libcxx/docs/Status/Cxx20Papers.csv

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"`P0777R1 <https://wg21.link/P0777R1>`__","Treating Unnecessary ``decay``\ ","2017-11 (Albuquerque)","|Complete|","7",""
1919
"","","","","",""
2020
"`P0122R7 <https://wg21.link/P0122R7>`__","<span>","2018-03 (Jacksonville)","|Complete|","7",""
21-
"`P0355R7 <https://wg21.link/P0355R7>`__","Extending chrono to Calendars and Time Zones","2018-03 (Jacksonville)","|Partial|","","See the `Github issue <https://github.com/llvm/llvm-project/issues/99982>`__ for detailed status"
21+
"`P0355R7 <https://wg21.link/P0355R7>`__","Extending chrono to Calendars and Time Zones","2018-03 (Jacksonville)","|Partial|","","See the `Github issue <https://llvm.org/PR99982>`__ for detailed status"
2222
"`P0551R3 <https://wg21.link/P0551R3>`__","Thou Shalt Not Specialize ``std``\ Function Templates!","2018-03 (Jacksonville)","|Complete|","11",""
2323
"`P0753R2 <https://wg21.link/P0753R2>`__","Manipulators for C++ Synchronized Buffered Ostream","2018-03 (Jacksonville)","","",""
2424
"`P0754R2 <https://wg21.link/P0754R2>`__","<version>","2018-03 (Jacksonville)","|Complete|","7",""

libcxx/include/__algorithm/simd_utils.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ template <class _Tp, size_t _Np>
123123
[[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI size_t __find_first_set(__simd_vector<_Tp, _Np> __vec) noexcept {
124124
using __mask_vec = __simd_vector<bool, _Np>;
125125

126-
// This has MSan disabled du to https://github.com/llvm/llvm-project/issues/85876
126+
// This has MSan disabled du to https://llvm.org/PR85876
127127
auto __impl = [&]<class _MaskT>(_MaskT) _LIBCPP_NO_SANITIZE("memory") noexcept {
128128
# if defined(_LIBCPP_BIG_ENDIAN)
129129
return std::min<size_t>(

libcxx/include/__atomic/atomic.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ struct atomic<_Tp> : __atomic_base<_Tp> {
350350
// &Context.getTargetInfo().getLongDoubleFormat() ==
351351
// &llvm::APFloat::x87DoubleExtended())
352352
// For more info
353-
// https://github.com/llvm/llvm-project/issues/68602
353+
// https://llvm.org/PR68602
354354
// https://reviews.llvm.org/D53965
355355
return !__is_fp80_long_double();
356356
# endif
@@ -367,7 +367,7 @@ struct atomic<_Tp> : __atomic_base<_Tp> {
367367
while (!__self.compare_exchange_weak(__old, __new, __m, memory_order_relaxed)) {
368368
# ifdef _LIBCPP_COMPILER_CLANG_BASED
369369
if constexpr (__is_fp80_long_double()) {
370-
// https://github.com/llvm/llvm-project/issues/47978
370+
// https://llvm.org/PR47978
371371
// clang bug: __old is not updated on failure for atomic<long double>::compare_exchange_weak
372372
// Note __old = __self.load(memory_order_relaxed) will not work
373373
std::__cxx_atomic_load_inplace(std::addressof(__self.__a_), std::addressof(__old), memory_order_relaxed);

libcxx/include/__configuration/abi.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,8 @@
111111
// We had some bugs where we use [[no_unique_address]] together with construct_at,
112112
// which causes UB as the call on construct_at could write to overlapping subobjects
113113
//
114-
// https://github.com/llvm/llvm-project/issues/70506
115-
// https://github.com/llvm/llvm-project/issues/70494
114+
// https://llvm.org/PR70506
115+
// https://llvm.org/PR70494
116116
//
117117
// To fix the bug we had to change the ABI of some classes to remove [[no_unique_address]] under certain conditions.
118118
// The macro below is used for all classes whose ABI have changed as part of fixing these bugs.

libcxx/include/__configuration/availability.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
//
7373
// We also allow users to force-disable availability markup via the `_LIBCPP_DISABLE_AVAILABILITY`
7474
// macro because that is the only way to work around a Clang bug related to availability
75-
// attributes: https://github.com/llvm/llvm-project/issues/134151.
75+
// attributes: https://llvm.org/PR134151.
7676
// Once that bug has been fixed, we should remove the macro.
7777
#if defined(_LIBCPP_BUILDING_LIBRARY) || defined(_LIBCXXABI_BUILDING_LIBRARY) || \
7878
!defined(_LIBCPP_COMPILER_CLANG_BASED) || defined(_LIBCPP_DISABLE_AVAILABILITY)
@@ -307,7 +307,7 @@
307307
// This controls the availability of the C++17 std::pmr library,
308308
// which is implemented in large part in the built library.
309309
//
310-
// TODO: Enable std::pmr markup once https://github.com/llvm/llvm-project/issues/40340 has been fixed
310+
// TODO: Enable std::pmr markup once https://llvm.org/PR40340 has been fixed
311311
// Until then, it is possible for folks to try to use `std::pmr` when back-deploying to targets that don't support
312312
// it and it'll be a load-time error, but we don't have a good alternative because the library won't compile if we
313313
// use availability annotations until that bug has been fixed.

libcxx/include/__iterator/bounded_iter.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,7 @@ struct __bounded_iter {
116116
// These operations check that the iterator is dereferenceable. Since the class invariant is
117117
// that the iterator is always within `[begin, end]`, we only need to check it's not pointing to
118118
// `end`. This is easier for the optimizer because it aligns with the `iter != container.end()`
119-
// checks that typical callers already use (see
120-
// https://github.com/llvm/llvm-project/issues/78829).
119+
// checks that typical callers already use (see https://llvm.org/PR78829).
121120
_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX14 reference operator*() const _NOEXCEPT {
122121
_LIBCPP_ASSERT_VALID_ELEMENT_ACCESS(
123122
__current_ != __end_, "__bounded_iter::operator*: Attempt to dereference an iterator at the end");

0 commit comments

Comments
 (0)