Skip to content

Commit 5f8bce4

Browse files
authored
[GlobalISel] Remove virtual from GISelValueTracking computeKnownBitsImpl. (#158558)
As far as I understand, GISelValueTracking::computeKnownBitsImpl does not need to be virtual, as no-one is specializing / overriding it, which means it is not necessary for the destructor either.
1 parent a50c11a commit 5f8bce4

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

llvm/include/llvm/CodeGen/GlobalISel/GISelValueTracking.h

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,15 +58,14 @@ class LLVM_ABI GISelValueTracking : public GISelChangeObserver {
5858

5959
public:
6060
GISelValueTracking(MachineFunction &MF, unsigned MaxDepth = 6);
61-
virtual ~GISelValueTracking() = default;
61+
~GISelValueTracking() = default;
6262

6363
const MachineFunction &getMachineFunction() const { return MF; }
6464

6565
const DataLayout &getDataLayout() const { return DL; }
6666

67-
virtual void computeKnownBitsImpl(Register R, KnownBits &Known,
68-
const APInt &DemandedElts,
69-
unsigned Depth = 0);
67+
void computeKnownBitsImpl(Register R, KnownBits &Known,
68+
const APInt &DemandedElts, unsigned Depth = 0);
7069

7170
unsigned computeNumSignBits(Register R, const APInt &DemandedElts,
7271
unsigned Depth = 0);

0 commit comments

Comments
 (0)