[Clang][NFC] Move temp variable back into the source (#137095)

shafik · web-flow · commit 72cc868c65b0 · 2025-04-24T08:15:25.000-07:00
Static analysis flagged this code b/c we are copying the temp variable
back in when we could move it instead.
diff --git a/clang/lib/Serialization/ASTReader.cpp b/clang/lib/Serialization/ASTReader.cpp
@@ -5980,7 +5980,7 @@ bool ASTReader::readASTFileControlBlock(
        }
       }
     }
-    Stream = SavedStream;
+    Stream = std::move(SavedStream);
   }
 
   // Scan for the UNHASHED_CONTROL_BLOCK_ID block.

Original file line number	Diff line number	Diff line change
`@@ -5980,7 +5980,7 @@ bool ASTReader::readASTFileControlBlock(`
`5980`	`5980`	`}`
`5981`	`5981`	`}`
`5982`	`5982`	`}`
`5983`		`- Stream = SavedStream;`
	`5983`	`+ Stream = std::move(SavedStream);`
`5984`	`5984`	`}`
`5985`	`5985`
`5986`	`5986`	`// Scan for the UNHASHED_CONTROL_BLOCK_ID block.`