Skip to content

Commit 73cb0b3

Browse files
charles-zablitNerixyz
authored andcommitted
Automerge: [lldb] add a warning if dirname is not in the PATH (#164494)
This patch adds a check in lldb's API test CMakeLists file to ensure that `dirname` is in the PATH, which is not obvious on Windows. --------- Co-authored-by: nerix <[email protected]>
2 parents f39599a + 1128d3b commit 73cb0b3

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

lldb/test/API/CMakeLists.txt

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,16 @@ else()
7474
endif()
7575
endif()
7676

77+
find_program(LLDB_DIRNAME_PATH dirname)
78+
if(LLDB_DIRNAME_PATH)
79+
message(STATUS "Found dirname: ${LLDB_DIRNAME_PATH}")
80+
else()
81+
message(STATUS "Could NOT find 'dirname'")
82+
message(WARNING
83+
"Many LLDB API tests require the GNU coreutils tools. Please make "
84+
"sure they are installed and in PATH.")
85+
endif()
86+
7787
if (TARGET clang)
7888
set(LLDB_DEFAULT_TEST_COMPILER "${LLVM_TOOLS_BINARY_DIR}/clang${CMAKE_EXECUTABLE_SUFFIX}")
7989
else()

0 commit comments

Comments
 (0)