Skip to content

Commit 7c5f1fa

Browse files
philnik777github-actions[bot]
authored andcommitted
Automerge: [libc++] Reject abilist if it contains an ABI tag (#139030)
We currently don't have any ABI tags in our dylib symbols, and this is unlikely to change in the future. By diagnosing this we avoid accidentally adding one through e.g. having `_LIBCPP_HIDE_FROM_ABI` on an exported symbol.
2 parents 6638c33 + e1ca2c5 commit 7c5f1fa

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

libcxx/utils/sym_diff.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,11 @@ def main():
8080
old_syms_list, _ = util.filter_stdlib_symbols(old_syms_list)
8181
new_syms_list, _ = util.filter_stdlib_symbols(new_syms_list)
8282

83+
for symbol in new_syms_list:
84+
if symbol["is_defined"] and 'B' in symbol["name"]:
85+
print(f"Symbol {symbol['name']} contains an ABI tag!")
86+
sys.exit(1)
87+
8388
added, removed, changed = diff.diff(old_syms_list, new_syms_list)
8489
if args.removed_only:
8590
added = {}

0 commit comments

Comments
 (0)