Skip to content

Commit 94e2ac4

Browse files
mikolaj-piroggithub-actions[bot]
authored andcommitted
Automerge: [X86] Remove rest of AMX-TRANSPOSE (#171906)
This is a followup to llvm/llvm-project#165556 I've missed some parts of amx-transpose during initial removal
2 parents 2d48d13 + 81a75b1 commit 94e2ac4

File tree

6 files changed

+4
-47
lines changed

6 files changed

+4
-47
lines changed

clang/test/CodeGen/X86/amx_tf32.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// RUN: %clang_cc1 %s -ffreestanding -triple=x86_64-unknown-unknown -target-feature +amx-tile -target-feature +amx-tf32 \
2-
// RUN: -target-feature +amx-transpose -emit-llvm -o - -Wall -Werror -pedantic -Wno-gnu-statement-expression | FileCheck %s
2+
// RUN: -emit-llvm -o - -Wall -Werror -pedantic -Wno-gnu-statement-expression | FileCheck %s
33

44
#include <immintrin.h>
55
#include <stddef.h>

clang/test/CodeGen/X86/amx_tf32_api.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// RUN: %clang_cc1 %s -flax-vector-conversions=none -ffreestanding -triple=x86_64-unknown-unknown \
2-
// RUN: -target-feature +amx-tf32 -target-feature +amx-transpose \
2+
// RUN: -target-feature +amx-tf32 \
33
// RUN: -target-feature +amx-bf16 -target-feature +avx512f \
44
// RUN: -emit-llvm -o - -Werror -pedantic | FileCheck %s
55

clang/test/CodeGen/X86/amx_tf32_errors.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// RUN: %clang_cc1 %s -ffreestanding -triple=x86_64-unknown-unknown \
2-
// RUN: -target-feature +amx-tf32 -target-feature +amx-transpose -verify
2+
// RUN: -target-feature +amx-tf32 -verify
33

44
#include <immintrin.h>
55
#include <stddef.h>
Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// RUN: %clang_cc1 %s -ffreestanding -triple=x86_64-unknown-unknown -target-feature +amx-tf32 -target-feature +amx-transpose -emit-llvm -o - -Wall -Werror -pedantic | FileCheck %s
1+
// RUN: %clang_cc1 %s -ffreestanding -triple=x86_64-unknown-unknown -target-feature +amx-tf32 -emit-llvm -o - -Wall -Werror -pedantic | FileCheck %s
22

33
void f_tilemul(short a)
44
{
@@ -8,11 +8,4 @@ void f_tilemul(short a)
88
"tmmultf32ps %%tmm6, %%tmm0, %%tmm7 \n\t"
99
"tilestored %%tmm7, 0(%%r12,%%r15,4) \n\t"
1010
::: "memory", "tmm0", "tmm6", "tmm7");
11-
12-
//CHECK: call void asm sideeffect "tileloadd 0(%rsi,%r13,4), %tmm0 \0A\09tileloadd 0(%rdx,%r14,4), %tmm6 \0A\09ttmmultf32ps %tmm6, %tmm0, %tmm7 \0A\09tilestored %tmm7, 0(%r12,%r15,4) \0A\09", "~{memory},~{tmm0},~{tmm6},~{tmm7},~{dirflag},~{fpsr},~{flags}"()
13-
__asm__ volatile ("tileloadd 0(%%rsi,%%r13,4), %%tmm0 \n\t"
14-
"tileloadd 0(%%rdx,%%r14,4), %%tmm6 \n\t"
15-
"ttmmultf32ps %%tmm6, %%tmm0, %%tmm7 \n\t"
16-
"tilestored %%tmm7, 0(%%r12,%%r15,4) \n\t"
17-
::: "memory", "tmm0", "tmm6", "tmm7");
1811
}

llvm/include/llvm/IR/IntrinsicsX86.td

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -5505,20 +5505,6 @@ let TargetPrefix = "x86" in {
55055505
[ImmArg<ArgIndex<0>>,
55065506
ImmArg<ArgIndex<1>>, ImmArg<ArgIndex<2>>]>;
55075507

5508-
// AMX-MORVS, AMX-TRANSPOSE
5509-
def int_x86_t2rpntlvwz0rs : ClangBuiltin<"__builtin_ia32_t2rpntlvwz0rs">,
5510-
Intrinsic<[], [llvm_i8_ty, llvm_ptr_ty, llvm_i64_ty],
5511-
[ImmArg<ArgIndex<0>>]>;
5512-
def int_x86_t2rpntlvwz0rst1 : ClangBuiltin<"__builtin_ia32_t2rpntlvwz0rst1">,
5513-
Intrinsic<[], [llvm_i8_ty, llvm_ptr_ty, llvm_i64_ty],
5514-
[ImmArg<ArgIndex<0>>]>;
5515-
def int_x86_t2rpntlvwz1rs : ClangBuiltin<"__builtin_ia32_t2rpntlvwz1rs">,
5516-
Intrinsic<[], [llvm_i8_ty, llvm_ptr_ty, llvm_i64_ty],
5517-
[ImmArg<ArgIndex<0>>]>;
5518-
def int_x86_t2rpntlvwz1rst1 : ClangBuiltin<"__builtin_ia32_t2rpntlvwz1rst1">,
5519-
Intrinsic<[], [llvm_i8_ty, llvm_ptr_ty, llvm_i64_ty],
5520-
[ImmArg<ArgIndex<0>>]>;
5521-
55225508
// AMX-AVX512
55235509
def int_x86_tcvtrowd2ps : ClangBuiltin<"__builtin_ia32_tcvtrowd2ps">,
55245510
Intrinsic<[llvm_v16f32_ty], [llvm_i8_ty, llvm_i32_ty],
@@ -5627,24 +5613,6 @@ let TargetPrefix = "x86" in {
56275613
llvm_x86amx_ty, llvm_x86amx_ty,
56285614
llvm_x86amx_ty], []>;
56295615

5630-
// AMX-MORVS, AMX-TRANSPOSE - internal intrinsics
5631-
def int_x86_t2rpntlvwz0rs_internal :
5632-
Intrinsic<[llvm_x86amx_ty, llvm_x86amx_ty],
5633-
[llvm_i16_ty, llvm_i16_ty, llvm_i16_ty, llvm_ptr_ty, llvm_i64_ty],
5634-
[IntrArgMemOnly, IntrReadMem]>;
5635-
def int_x86_t2rpntlvwz0rst1_internal :
5636-
Intrinsic<[llvm_x86amx_ty, llvm_x86amx_ty],
5637-
[llvm_i16_ty, llvm_i16_ty, llvm_i16_ty, llvm_ptr_ty, llvm_i64_ty],
5638-
[IntrArgMemOnly]>;
5639-
def int_x86_t2rpntlvwz1rs_internal :
5640-
Intrinsic<[llvm_x86amx_ty, llvm_x86amx_ty],
5641-
[llvm_i16_ty, llvm_i16_ty, llvm_i16_ty, llvm_ptr_ty, llvm_i64_ty],
5642-
[IntrArgMemOnly]>;
5643-
def int_x86_t2rpntlvwz1rst1_internal :
5644-
Intrinsic<[llvm_x86amx_ty, llvm_x86amx_ty],
5645-
[llvm_i16_ty, llvm_i16_ty, llvm_i16_ty, llvm_ptr_ty, llvm_i64_ty],
5646-
[IntrArgMemOnly]>;
5647-
56485616
def int_x86_tcvtrowd2ps_internal :
56495617
ClangBuiltin<"__builtin_ia32_tcvtrowd2ps_internal">,
56505618
Intrinsic<[llvm_v16f32_ty],

llvm/lib/Target/X86/X86LowerAMXType.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -163,10 +163,6 @@ std::pair<Value *, Value *> getShape(IntrinsicInst *II, unsigned OpNo) {
163163
case Intrinsic::x86_tileloadd64_internal:
164164
case Intrinsic::x86_tileloaddt164_internal:
165165
case Intrinsic::x86_tilestored64_internal:
166-
case Intrinsic::x86_t2rpntlvwz0rs_internal:
167-
case Intrinsic::x86_t2rpntlvwz0rst1_internal:
168-
case Intrinsic::x86_t2rpntlvwz1rs_internal:
169-
case Intrinsic::x86_t2rpntlvwz1rst1_internal:
170166
case Intrinsic::x86_tileloaddrs64_internal:
171167
case Intrinsic::x86_tileloaddrst164_internal: {
172168
Row = II->getArgOperand(0);

0 commit comments

Comments
 (0)