Skip to content

Commit 9a0fd22

Browse files
authored
Revert "[OpenMP] Implement omp_get_uid_from_device() / omp_get_device_from_uid()" (#168547)
Reverts llvm/llvm-project#164392 due to fortran issues
1 parent 75792d6 commit 9a0fd22

File tree

15 files changed

+2
-310
lines changed

15 files changed

+2
-310
lines changed

offload/include/OpenMP/omp.h

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,6 @@
3030

3131
extern "C" {
3232

33-
/// Definitions
34-
///{
35-
36-
#define omp_invalid_device -2
37-
38-
///}
39-
4033
/// Type declarations
4134
///{
4235

offload/include/omptarget.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,8 +270,6 @@ extern "C" {
270270
void ompx_dump_mapping_tables(void);
271271
int omp_get_num_devices(void);
272272
int omp_get_device_num(void);
273-
int omp_get_device_from_uid(const char *DeviceUid);
274-
const char *omp_get_uid_from_device(int DeviceNum);
275273
int omp_get_initial_device(void);
276274
void *omp_target_alloc(size_t Size, int DeviceNum);
277275
void omp_target_free(void *DevicePtr, int DeviceNum);

offload/libomptarget/OpenMP/API.cpp

Lines changed: 0 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ EXTERN void ompx_dump_mapping_tables() {
4040
using namespace llvm::omp::target::ompt;
4141
#endif
4242

43-
using GenericDeviceTy = llvm::omp::target::plugin::GenericDeviceTy;
44-
4543
void *targetAllocExplicit(size_t Size, int DeviceNum, int Kind,
4644
const char *Name);
4745
void targetFreeExplicit(void *DevicePtr, int DeviceNum, int Kind,
@@ -70,62 +68,6 @@ EXTERN int omp_get_device_num(void) {
7068
return HostDevice;
7169
}
7270

73-
static inline bool is_initial_device_uid(const char *DeviceUid) {
74-
return strcmp(DeviceUid, GenericPluginTy::getHostDeviceUid()) == 0;
75-
}
76-
77-
EXTERN int omp_get_device_from_uid(const char *DeviceUid) {
78-
TIMESCOPE();
79-
OMPT_IF_BUILT(ReturnAddressSetterRAII RA(__builtin_return_address(0)));
80-
81-
if (!DeviceUid) {
82-
DP("Call to omp_get_device_from_uid returning omp_invalid_device\n");
83-
return omp_invalid_device;
84-
}
85-
if (is_initial_device_uid(DeviceUid)) {
86-
DP("Call to omp_get_device_from_uid returning initial device number %d\n",
87-
omp_get_initial_device());
88-
return omp_get_initial_device();
89-
}
90-
91-
int DeviceNum = omp_invalid_device;
92-
93-
auto ExclusiveDevicesAccessor = PM->getExclusiveDevicesAccessor();
94-
for (const DeviceTy &Device : PM->devices(ExclusiveDevicesAccessor)) {
95-
const char *Uid = Device.RTL->getDevice(Device.RTLDeviceID).getDeviceUid();
96-
if (Uid && strcmp(DeviceUid, Uid) == 0) {
97-
DeviceNum = Device.DeviceID;
98-
break;
99-
}
100-
}
101-
102-
DP("Call to omp_get_device_from_uid returning %d\n", DeviceNum);
103-
return DeviceNum;
104-
}
105-
106-
EXTERN const char *omp_get_uid_from_device(int DeviceNum) {
107-
TIMESCOPE();
108-
OMPT_IF_BUILT(ReturnAddressSetterRAII RA(__builtin_return_address(0)));
109-
110-
if (DeviceNum == omp_invalid_device) {
111-
DP("Call to omp_get_uid_from_device returning nullptr\n");
112-
return nullptr;
113-
}
114-
if (DeviceNum == omp_get_initial_device()) {
115-
DP("Call to omp_get_uid_from_device returning initial device UID\n");
116-
return GenericPluginTy::getHostDeviceUid();
117-
}
118-
119-
auto DeviceOrErr = PM->getDevice(DeviceNum);
120-
if (!DeviceOrErr)
121-
FATAL_MESSAGE(DeviceNum, "%s", toString(DeviceOrErr.takeError()).c_str());
122-
123-
const char *Uid =
124-
DeviceOrErr->RTL->getDevice(DeviceOrErr->RTLDeviceID).getDeviceUid();
125-
DP("Call to omp_get_uid_from_device returning %s\n", Uid);
126-
return Uid;
127-
}
128-
12971
EXTERN int omp_get_initial_device(void) {
13072
TIMESCOPE();
13173
OMPT_IF_BUILT(ReturnAddressSetterRAII RA(__builtin_return_address(0)));

offload/libomptarget/exports

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ VERS1.0 {
4040
omp_get_mapped_ptr;
4141
omp_get_num_devices;
4242
omp_get_device_num;
43-
omp_get_device_from_uid;
44-
omp_get_uid_from_device;
4543
omp_get_initial_device;
4644
omp_target_alloc;
4745
omp_target_free;

offload/test/api/omp_device_uid.c

Lines changed: 0 additions & 76 deletions
This file was deleted.

openmp/device/include/DeviceTypes.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,6 @@ template <typename T> using Constant = __gpu_constant T;
2121
template <typename T> using Local = __gpu_local T;
2222
template <typename T> using Global = __gpu_local T;
2323

24-
// See definition in OpenMP (omp.h.var/omp_lib.(F90|h).var)
25-
#define omp_invalid_device -2
26-
2724
enum omp_proc_bind_t {
2825
omp_proc_bind_false = 0,
2926
omp_proc_bind_true = 1,

openmp/device/include/Interface.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -130,10 +130,6 @@ int omp_get_num_devices(void);
130130

131131
int omp_get_device_num(void);
132132

133-
int omp_get_device_from_uid(const char *DeviceUid);
134-
135-
const char *omp_get_uid_from_device(int DeviceNum);
136-
137133
int omp_get_num_teams(void);
138134

139135
int omp_get_team_num();

openmp/device/src/State.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -403,12 +403,6 @@ int omp_get_num_devices(void) { return config::getNumDevices(); }
403403

404404
int omp_get_device_num(void) { return config::getDeviceNum(); }
405405

406-
int omp_get_device_from_uid(const char *DeviceUid) {
407-
return omp_invalid_device;
408-
}
409-
410-
const char *omp_get_uid_from_device(int DeviceNum) { return nullptr; }
411-
412406
int omp_get_num_teams(void) { return mapping::getNumberOfBlocksInKernel(); }
413407

414408
int omp_get_team_num() { return mapping::getBlockIdInKernel(); }

openmp/runtime/src/dllexports

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -544,8 +544,6 @@ kmp_set_disp_num_buffers 890
544544
omp_get_devices_all_allocator 819
545545
omp_get_memspace_num_resources 820
546546
omp_get_submemspace 821
547-
omp_get_device_from_uid 822
548-
omp_get_uid_from_device 823
549547
%ifndef stub
550548
__kmpc_set_default_allocator
551549
__kmpc_get_default_allocator

openmp/runtime/src/include/omp.h.var

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -536,11 +536,6 @@
536536

537537
/* OpenMP 5.2 */
538538
extern int __KAI_KMPC_CONVENTION omp_in_explicit_task(void);
539-
#define omp_invalid_device -2
540-
541-
/* OpenMP 6.0 */
542-
extern int __KAI_KMPC_CONVENTION omp_get_device_from_uid(const char *DeviceUid);
543-
extern const char * __KAI_KMPC_CONVENTION omp_get_uid_from_device(int DeviceNum);
544539

545540
/* LLVM Extensions */
546541
extern void *llvm_omp_target_dynamic_shared_alloc(void);

0 commit comments

Comments
 (0)