Automerge: Fix the formatting script: do not try to update a GitHub PR without checking for should_update_gh (#159276)

joker-eph · github-actions[bot] · commit 9a3cd1d54b5b · 2025-09-26T20:15:02.000Z
diff --git a/llvm/utils/git/code-format-helper.py b/llvm/utils/git/code-format-helper.py
@@ -173,7 +173,8 @@ def run(self, changed_files: List[str], args: FormatArgs) -> bool:
                 f":warning: The {self.friendly_name} failed without printing "
                 "a diff. Check the logs for stderr output. :warning:"
             )
-            self.update_pr(comment_text, args, create_new=False)
+            if should_update_gh:
+                self.update_pr(comment_text, args, create_new=False)
             return False
 
 

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,8 @@ def run(self, changed_files: List[str], args: FormatArgs) -> bool:`
`173`	`173`	`f":warning: The {self.friendly_name} failed without printing "`
`174`	`174`	`"a diff. Check the logs for stderr output. :warning:"`
`175`	`175`	`)`
`176`		`- self.update_pr(comment_text, args, create_new=False)`
	`176`	`+ if should_update_gh:`
	`177`	`+ self.update_pr(comment_text, args, create_new=False)`
`177`	`178`	`return False`
`178`	`179`
`179`	`180`