Skip to content

Commit ea8994b

Browse files
authored
[flang][cuda] Remove TODO for descriptor with addendum (#155012)
Addendum is allocated as part of the descriptor so there is no need for extra care.
1 parent ffe3768 commit ea8994b

File tree

2 files changed

+0
-14
lines changed

2 files changed

+0
-14
lines changed

flang-rt/lib/cuda/allocatable.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,6 @@ int RTDEF(CUFAllocatableAllocateSync)(Descriptor &desc, int64_t *stream,
4444
int RTDEF(CUFAllocatableAllocate)(Descriptor &desc, int64_t *stream,
4545
bool *pinned, bool hasStat, const Descriptor *errMsg,
4646
const char *sourceFile, int sourceLine) {
47-
if (desc.HasAddendum()) {
48-
Terminator terminator{sourceFile, sourceLine};
49-
// TODO: This require a bit more work to set the correct type descriptor
50-
// address
51-
terminator.Crash(
52-
"not yet implemented: CUDA descriptor allocation with addendum");
53-
}
5447
// Perform the standard allocation.
5548
int stat{RTNAME(AllocatableAllocate)(
5649
desc, stream, hasStat, errMsg, sourceFile, sourceLine)};

flang-rt/lib/cuda/pointer.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,6 @@ RT_EXT_API_GROUP_BEGIN
2525
int RTDEF(CUFPointerAllocate)(Descriptor &desc, int64_t *stream, bool *pinned,
2626
bool hasStat, const Descriptor *errMsg, const char *sourceFile,
2727
int sourceLine) {
28-
if (desc.HasAddendum()) {
29-
Terminator terminator{sourceFile, sourceLine};
30-
// TODO: This require a bit more work to set the correct type descriptor
31-
// address
32-
terminator.Crash(
33-
"not yet implemented: CUDA descriptor allocation with addendum");
34-
}
3528
// Perform the standard allocation.
3629
int stat{
3730
RTNAME(PointerAllocate)(desc, hasStat, errMsg, sourceFile, sourceLine)};

0 commit comments

Comments
 (0)