Skip to content

Commit f4538cb

Browse files
[CI] Only invoke ninja for runtimes build if runtimes are specified (#156969)
Otherwise we end up running ninja without any targets specified which just builds the rest of the default enabled targets. This shouldn't have too much impact, but can involve building extra things that we don't need. This also makes the monolithic-windows.sh script consistent with the monolithic-windows.sh script.
1 parent 91952f1 commit f4538cb

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

.ci/monolithic-windows.sh

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,8 @@ start-group "ninja"
5656
# Targets are not escaped as they are passed as separate arguments.
5757
ninja -C "${BUILD_DIR}" -k 0 ${targets} |& tee ninja.log
5858

59-
start-group "ninja runtimes"
60-
61-
ninja -C "${BUILD_DIR}" -k 0 ${runtimes_targets} |& tee ninja_runtimes.log
59+
if [[ "${runtime_targets}" != "" ]]; then
60+
start-group "ninja runtimes"
61+
62+
ninja -C "${BUILD_DIR}" -k 0 ${runtimes_targets} |& tee ninja_runtimes.log
63+
fi

0 commit comments

Comments
 (0)