Use _LIBCPP_LIBC_NEWLIB instead of _NEWLIB_VERSION #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use _LIBCPP_LIBC_NEWLIB instead of _NEWLIB_VERSION in the downstream change to enable fstream independently from filesystem to align with the new way of specifying the C library in use woth libcxx, see llvm/llvm-project#147956 Downstream issue: arm#375
|
This pull review modifies files outside of the |
pawosm-arm
approved these changes
Nov 25, 2025
Contributor
pawosm-arm
left a comment
pawosm-arm
left a comment
There was a problem hiding this comment.
I'm not an expert in newlib and its surroundings, but if it makes unblock you, then so be it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use _LIBCPP_LIBC_NEWLIB instead of _NEWLIB_VERSION in the downstream change to enable fstream independently from filesystem to align with the new way of specifying the C library in use woth libcxx, see llvm/llvm-project#147956
Downstream issue: #375