Skip to content

Use _LIBCPP_LIBC_NEWLIB instead of _NEWLIB_VERSION #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2025
+5 −5
Merged

Use _LIBCPP_LIBC_NEWLIB instead of _NEWLIB_VERSION #624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libcxx/include/fstream
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ typedef basic_fstream<wchar_t> wfstream;
# include <__config>

// Downstream issue: #375 (Enable fstream independently of filesystem)
# if _LIBCPP_HAS_FILESYSTEM && _LIBCPP_HAS_LOCALIZATION || defined(_NEWLIB_VERSION)
# if _LIBCPP_HAS_FILESYSTEM && _LIBCPP_HAS_LOCALIZATION || defined(_LIBCPP_LIBC_NEWLIB)

# include <__algorithm/max.h>
# include <__assert>
Expand Down
2 changes: 1 addition & 1 deletion libcxx/src/ios.instantiations.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ template class _LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS basic_ostringstream<char
template class _LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS basic_istringstream<char>;

// Downstream issue: #375 (Enable fstream independently of filesystem)
#if _LIBCPP_HAS_FILESYSTEM || defined(_NEWLIB_VERSION)
#if _LIBCPP_HAS_FILESYSTEM || defined(_LIBCPP_LIBC_NEWLIB)
template class _LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS basic_ifstream<char>;
template class _LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS basic_ofstream<char>;
template class _LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS basic_filebuf<char>;
Expand Down
2 changes: 1 addition & 1 deletion libcxx/src/ostream.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include <__config>

// Downstream issue: #375 (Enable fstream independently of filesystem)
#if _LIBCPP_HAS_FILESYSTEM || defined(_NEWLIB_VERSION)
#if _LIBCPP_HAS_FILESYSTEM || defined(_LIBCPP_LIBC_NEWLIB)
# include <fstream>
#endif
#include <ostream>
Expand Down
4 changes: 2 additions & 2 deletions libcxx/test/support/platform_support.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
# include <fcntl.h> // _O_EXCL, ...
# include <sys/stat.h> // _S_IREAD, ...
// Downstream issue: #375 (Enable fstream independently of filesystem)
#elif defined(_NEWLIB_VERSION)
#elif defined(_LIBCPP_LIBC_NEWLIB)
// No need to include extra headers for the get_temp_file_name() implementation
// below: tmpnam() is defined in <stdio.h>
#elif __has_include(<unistd.h>)
Expand Down Expand Up @@ -75,7 +75,7 @@ inline std::string get_temp_file_name() {
abort();
}
// Downstream issue: #375 (Enable fstream independently of filesystem)
#elif defined(_NEWLIB_VERSION)
#elif defined(_LIBCPP_LIBC_NEWLIB)
char tmp_name[L_tmpnam];
char *ret = tmpnam(tmp_name);
if (ret == NULL) {
Expand Down
Loading