fix: mutating hook for binoculars panicking on nil pointer dereference (#294)

dejanzele · web-flow · commit bda0e290f144 · 2023-12-04T12:43:55.000+01:00
* fix mutating hook for binoculars panicking on nil pointer dereference

* lint fixes for binoculars webhook
diff --git a/api/install/v1alpha1/binoculars_webhook.go b/api/install/v1alpha1/binoculars_webhook.go
@@ -68,7 +68,10 @@ func (r *Binoculars) Default() {
 	}
 
 	// prometheus
-	if r.Spec.Prometheus.ScrapeInterval == nil {
-		r.Spec.Prometheus.ScrapeInterval = &metav1.Duration{Duration: time.Second * 10}
+	if r.Spec.Prometheus != nil && r.Spec.Prometheus.Enabled {
+		if r.Spec.Prometheus.ScrapeInterval == nil {
+			r.Spec.Prometheus.ScrapeInterval = &metav1.Duration{Duration: time.Second * 10}
+		}
 	}
+
 }

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,10 @@ func (r *Binoculars) Default() {`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`// prometheus`
`71`		`- if r.Spec.Prometheus.ScrapeInterval == nil {`
`72`		`- r.Spec.Prometheus.ScrapeInterval = &metav1.Duration{Duration: time.Second * 10}`
	`71`	`+ if r.Spec.Prometheus != nil && r.Spec.Prometheus.Enabled {`
	`72`	`+ if r.Spec.Prometheus.ScrapeInterval == nil {`
	`73`	`+ r.Spec.Prometheus.ScrapeInterval = &metav1.Duration{Duration: time.Second * 10}`
	`74`	`+ }`
`73`	`75`	`}`
	`76`	`+`
`74`	`77`	`}`