Skip to content

Commit 08c198a

Browse files
authored
chore: update go to v1.25 (#4499)
#### What type of PR is this? Chore #### What this PR does / why we need it: Update Go version to v1.25, this version introduces a couple of performance optimizations which would benefit Armada components, especially the scheduler. `golang.org/x/tools/cmd/goimports` needed to be bumped to `v0.38.0` so it contains a version of `golang.org/x/tools` which is compatible with go1.25. `github.com/go-swagger/go-swagger/cmd/swagger` needed to be bumped to `v0.33.1` due to above reason. `go.uber.org/mock/mockgen` needed to be bumped to `v0.6.0` due to above reason. `github.com/golangci/golangci-lint/cmd/golangci-lint` needed to be bumped to `v2.5.0` due to above reason. More info on `x/tools` compatibility issues here golang/go#74462 All code changes are auto-generated from: * `go run github.com/magefile/[email protected] -v proto` * `go run github.com/magefile/[email protected] -v generate` Signed-off-by: Dejan Zele Pejchev <[email protected]>
1 parent 8218a0b commit 08c198a

33 files changed

+238
-118
lines changed

.github/actions/setup-go-cache/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ inputs:
55
description: "Prefix for the cache key"
66
required: true
77
go-version:
8-
description: "Version of Go. Default 1.24"
8+
description: "Version of Go. Default 1.25"
99
required: false
10-
default: "1.24"
10+
default: "1.25"
1111
cache-tools:
1212
description: "True/false flag to cache tools"
1313
required: false

.goreleaser.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ env:
1919
# To use a builder other than "default", set this variable.
2020
# Necessary for, e.g., GitHub actions cache integration.
2121
- DOCKER_BUILDX_BUILDER={{ if index .Env "DOCKER_BUILDX_BUILDER" }}{{ .Env.DOCKER_BUILDX_BUILDER }}{{ else }}default{{ end }}
22-
- GOVERSION={{ if index .Env "GOVERSION" }}{{ .Env.GOVERSION }}{{ else }}go1.24{{ end }}
22+
- GOVERSION={{ if index .Env "GOVERSION" }}{{ .Env.GOVERSION }}{{ else }}go1.25{{ end }}
2323

2424
builds:
2525
- env: [CGO_ENABLED=0]

docs/developer_guide.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ For more information about Armada's design, see the following pages:
7272

7373
Before you can start using Armada, you first need to install the following items:
7474

75-
- [`Go`](https://go.dev/doc/install) (version 1.23 or later)
75+
- [`Go`](https://go.dev/doc/install) (version 1.25 or later)
7676
- `gcc` (for Windows, [see `tdm-gcc`](https://jmeubank.github.io/tdm-gcc/))
7777
- [`mage`](https://magefile.org/)
7878
- [`docker`](https://docs.docker.com/get-docker/)

go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
module github.com/armadaproject/armada
22

3-
go 1.24
3+
go 1.25
44

5-
toolchain go1.24.1
5+
toolchain go1.25.3
66

77
require (
88
github.com/apache/pulsar-client-go v0.14.0

internal/lookout/gen/models/filter.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/lookout/gen/models/group.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/lookout/gen/models/job.go

Lines changed: 23 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/lookout/gen/models/order.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/lookout/gen/models/run.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/lookout/gen/restapi/operations/get_health.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)