[fix] [Lookout UI] fix cancellations and reprioritisations (#4588)

2225364 broke cancelling and
reprioritising jobs on the Lookout UI as it adds the authorization
header twice. This fixes it by removing the second addition (the fetch
function in API clients provided by `useApiClients()` already performs
this job).

Author: mauriceyap

internal/lookoutui/src/services/lookout/useCancelJobs.ts

@@ -3,7 +3,6 @@ import { useMutation } from "@tanstack/react-query"
 import { getErrorMessage } from "../../common/utils"
 import { getConfig } from "../../config"
 import { Job, JobId } from "../../models/lookoutModels"
-import { appendAuthorizationHeaders, useGetAccessToken } from "../../oidcAuth"
 
 import { useApiClients } from "../apiClients"
 
@@ -45,7 +44,6 @@ function createJobBatches(jobs: Job[], batchSize: number): Map<string, Map<strin
 export const useCancelJobs = () => {
   const config = getConfig()
   const { submitApi } = useApiClients()
-  const getAccessToken = useGetAccessToken()
 
   return useMutation<UpdateJobsResponse, string, CancelJobsVariables>({
     mutationFn: async ({ jobs, reason }: CancelJobsVariables) => {
@@ -63,28 +61,19 @@ export const useCancelJobs = () => {
         const maxJobsPerRequest = 10000
         const chunks = createJobBatches(jobs, maxJobsPerRequest)
 
-        const accessToken = await getAccessToken()
-
         const apiResponsePromises = []
         for (const [queue, jobSetMap] of chunks) {
           for (const [jobSet, batches] of jobSetMap) {
             for (const batch of batches) {
-              const headers = new Headers()
-              if (accessToken) {
-                appendAuthorizationHeaders(headers, accessToken)
-              }
               apiResponsePromises.push({
-                promise: submitApi.cancelJobs(
-                  {
-                    body: {
-                      jobIds: batch,
-                      queue: queue,
-                      jobSetId: jobSet,
-                      reason: reason,
-                    },
+                promise: submitApi.cancelJobs({
+                  body: {
+                    jobIds: batch,
+                    queue: queue,
+                    jobSetId: jobSet,
+                    reason: reason,
                   },
-                  { headers },
-                ),
+                }),
                 jobIds: batch,
               })
             }

internal/lookoutui/src/services/lookout/useReprioritizeJobs.ts

@@ -4,7 +4,6 @@ import _ from "lodash"
 import { getErrorMessage } from "../../common/utils"
 import { getConfig } from "../../config"
 import { Job, JobId } from "../../models/lookoutModels"
-import { appendAuthorizationHeaders, useGetAccessToken } from "../../oidcAuth"
 
 import { useApiClients } from "../apiClients"
 
@@ -48,7 +47,6 @@ function createJobBatches(jobs: Job[], batchSize: number): Map<string, Map<strin
 
 export const useReprioritizeJobs = () => {
   const { submitApi } = useApiClients()
-  const getAccessToken = useGetAccessToken()
 
   return useMutation<UpdateJobsResponse, string, ReprioritizeJobsVariables>({
     mutationFn: async ({ jobs, newPriority }: ReprioritizeJobsVariables) => {
@@ -65,28 +63,19 @@ export const useReprioritizeJobs = () => {
 
         const chunks = createJobBatches(jobs, maxJobsPerRequest)
 
-        const accessToken = await getAccessToken()
-
         const apiResponsePromises = []
         for (const [queue, jobSetMap] of chunks) {
           for (const [jobSet, batches] of jobSetMap) {
             for (const batch of batches) {
-              const headers = new Headers()
-              if (accessToken) {
-                appendAuthorizationHeaders(headers, accessToken)
-              }
               apiResponsePromises.push({
-                promise: submitApi.reprioritizeJobs(
-                  {
-                    body: {
-                      jobIds: batch,
-                      queue: queue,
-                      jobSetId: jobSet,
-                      newPriority: newPriority,
-                    },
+                promise: submitApi.reprioritizeJobs({
+                  body: {
+                    jobIds: batch,
+                    queue: queue,
+                    jobSetId: jobSet,
+                    newPriority: newPriority,
                   },
-                  { headers },
-                ),
+                }),
                 jobIds: batch,
               })
             }