Skip to content

Commit e5ae56a

Browse files
committed
minor fixes
1 parent 6ec31a1 commit e5ae56a

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

cmd/scheduleringester/main.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,12 @@ import (
44
"fmt"
55
"os"
66

7-
"github.com/armadaproject/armada/internal/common/logging"
8-
97
"github.com/spf13/pflag"
108
"github.com/spf13/viper"
119

12-
"github.com/armadaproject/armada/internal/scheduleringester"
13-
1410
"github.com/armadaproject/armada/internal/common"
11+
"github.com/armadaproject/armada/internal/common/logging"
12+
"github.com/armadaproject/armada/internal/scheduleringester"
1513
)
1614

1715
const CustomConfigLocation string = "config"

internal/executor/application.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import (
1919
"github.com/armadaproject/armada/internal/common/cluster"
2020
"github.com/armadaproject/armada/internal/common/etcdhealth"
2121
"github.com/armadaproject/armada/internal/common/healthmonitor"
22-
log "github.com/armadaproject/armada/internal/common/logging"
2322
common_metrics "github.com/armadaproject/armada/internal/common/metrics"
2423
"github.com/armadaproject/armada/internal/common/task"
2524
"github.com/armadaproject/armada/internal/common/util"
@@ -195,8 +194,7 @@ func setupExecutorApiComponents(
195194

196195
failedPodChecker, err := failedpodchecks.NewPodRetryChecker(config.Kubernetes.FailedPodChecks)
197196
if err != nil {
198-
log.Errorf("Failed to create job event reporter: %s", err)
199-
os.Exit(-1)
197+
ctx.Fatalf("Config error in failed pod checks: %s", err)
200198
}
201199

202200
eventReporter, stopReporter := reporter.NewJobEventReporter(eventSender, clock.RealClock{}, 200)

0 commit comments

Comments
 (0)