fix: split cache into separate restore and save actions for save-always support

Author: arman-bd

.github/workflows/_test.yml

@@ -108,21 +108,20 @@ jobs:
         echo "CXX=ccache g++" >> $GITHUB_ENV
       shell: bash
 
-    - name: Cache vcpkg packages (Windows)
+    - name: Restore vcpkg cache (Windows)
       if: runner.os == 'Windows'
-      id: cache-vcpkg
-      uses: actions/cache@v4
+      id: cache-vcpkg-restore
+      uses: actions/cache/restore@v4
       with:
         path: |
           C:/vcpkg/installed
           C:/vcpkg/packages
         key: vcpkg-nghttp2-zlib-${{ runner.os }}-v3
         restore-keys: |
           vcpkg-nghttp2-zlib-${{ runner.os }}-
-        save-always: true
 
     - name: Setup vcpkg (Windows)
-      if: runner.os == 'Windows' && steps.cache-vcpkg.outputs.cache-hit != 'true'
+      if: runner.os == 'Windows' && steps.cache-vcpkg-restore.outputs.cache-hit != 'true'
       run: |
         # Use pre-installed vcpkg on GitHub runners
         if [ -d "C:/vcpkg" ]; then
@@ -140,7 +139,7 @@ jobs:
       shell: bash
 
     - name: Install dependencies via vcpkg (Windows)
-      if: runner.os == 'Windows' && steps.cache-vcpkg.outputs.cache-hit != 'true'
+      if: runner.os == 'Windows' && steps.cache-vcpkg-restore.outputs.cache-hit != 'true'
       run: |
         export VCPKG_ROOT="C:/vcpkg"
         export PATH="$VCPKG_ROOT:$PATH"
@@ -154,15 +153,14 @@ jobs:
         echo "C:/vcpkg" >> $GITHUB_PATH
       shell: bash
 
-    - name: Cache vendor dependencies
+    - name: Restore vendor cache
       id: cache-vendor
-      uses: actions/cache@v4
+      uses: actions/cache/restore@v4
       with:
         path: vendor
         key: vendor-${{ runner.os }}-${{ hashFiles('scripts/setup_vendors.sh') }}-v7
         restore-keys: |
           vendor-${{ runner.os }}-
-        save-always: true
 
     - name: Setup vendor dependencies
       if: steps.cache-vendor.outputs.cache-hit != 'true'
@@ -178,16 +176,16 @@ jobs:
         du -sh vendor/ 2>/dev/null || echo "Cannot get vendor size"
       shell: bash
 
-    - name: Cache Python build artifacts
-      uses: actions/cache@v4
+    - name: Restore Python build cache
+      id: cache-python-build
+      uses: actions/cache/restore@v4
       with:
         path: |
           build/
           *.egg-info/
         key: python-build-${{ runner.os }}-${{ matrix.python-version }}-${{ hashFiles('setup.py', 'pyproject.toml', 'src/**/*.c', 'src/**/*.cpp', 'src/**/*.h') }}
         restore-keys: |
           python-build-${{ runner.os }}-${{ matrix.python-version }}-
-        save-always: true
 
     - name: Install package
       run: pip install -e ".[dev]"
@@ -213,3 +211,29 @@ jobs:
         file: ./coverage.xml
         token: ${{ secrets.CODECOV_TOKEN }}
         fail_ci_if_error: false
+
+    # Save caches even if tests fail (using always())
+    - name: Save vcpkg cache (Windows)
+      if: always() && runner.os == 'Windows' && steps.cache-vcpkg-restore.outputs.cache-hit != 'true'
+      uses: actions/cache/save@v4
+      with:
+        path: |
+          C:/vcpkg/installed
+          C:/vcpkg/packages
+        key: vcpkg-nghttp2-zlib-${{ runner.os }}-v3
+
+    - name: Save vendor cache
+      if: always() && steps.cache-vendor.outputs.cache-hit != 'true'
+      uses: actions/cache/save@v4
+      with:
+        path: vendor
+        key: vendor-${{ runner.os }}-${{ hashFiles('scripts/setup_vendors.sh') }}-v7
+
+    - name: Save Python build cache
+      if: always()
+      uses: actions/cache/save@v4
+      with:
+        path: |
+          build/
+          *.egg-info/
+        key: python-build-${{ runner.os }}-${{ matrix.python-version }}-${{ hashFiles('setup.py', 'pyproject.toml', 'src/**/*.c', 'src/**/*.cpp', 'src/**/*.h') }}