wip

Author: arman-bd

.github/workflows/_benchmark.yml

@@ -32,7 +32,7 @@ jobs:
 
     - name: Install system dependencies (macOS)
       if: runner.os == 'macOS'
-      run: brew install cmake ninja openssl@3 libnghttp2
+      run: brew install cmake ninja libnghttp2
 
     - name: Cache vendor dependencies
       uses: actions/cache@v4

.github/workflows/_test.yml

@@ -88,7 +88,7 @@ jobs:
     - name: Install dependencies via vcpkg (Windows)
       if: runner.os == 'Windows'
       run: |
-        vcpkg install openssl:x64-windows nghttp2:x64-windows zlib:x64-windows --clean-after-build
+        vcpkg install nghttp2:x64-windows zlib:x64-windows --clean-after-build
       shell: bash
 
     - name: Cache vendor dependencies

README.md

@@ -20,9 +20,9 @@ pip install httpmorph
 
 ### Requirements
 
-- Python 3.7+
-- macOS or Linux (Windows support in progress)
-- OpenSSL/BoringSSL
+- Python 3.8+
+- Windows, macOS, or Linux
+- BoringSSL (built automatically from source)
 - libnghttp2 (for HTTP/2)
 
 ## Quick Start
@@ -142,17 +142,17 @@ httpmorph aims for high compatibility with Python's `requests` library:
 
 | Feature | Status |
 |---------|--------|
-| GET, POST, PUT, DELETE, HEAD, PATCH, OPTIONS |  Supported |
-| JSON request/response |  Supported |
-| Form data & file uploads |  Supported |
-| Custom headers |  Supported |
-| Authentication |  Supported |
-| Cookies & sessions |  Supported |
-| Redirects with history |  Supported |
-| Timeout control |  Supported |
-| SSL verification |  Supported |
-| Streaming responses |  Supported |
-| Exception hierarchy |  Supported |
+| GET, POST, PUT, DELETE, HEAD, PATCH, OPTIONS | Supported |
+| JSON request/response | Supported |
+| Form data & file uploads | Supported |
+| Custom headers | Supported |
+| Authentication | Supported |
+| Cookies & sessions | Supported |
+| Redirects with history | Supported |
+| Timeout control | Supported |
+| SSL verification | Supported |
+| Streaming responses | Supported |
+| Exception hierarchy | Supported |
 
 ## Response Object
 
@@ -218,54 +218,85 @@ Benchmarks show httpmorph matching or exceeding the performance of curl and othe
 
 | Platform | Status |
 |----------|--------|
-| macOS (Intel & Apple Silicon) | Fully supported |
-| Linux (x86_64, ARM64) | Fully supported |
-| Windows | In progress |
+| Windows | ✅ Fully supported |
+| macOS (Intel & Apple Silicon) | ✅ Fully supported |
+| Linux (x86_64, ARM64) | ✅ Fully supported |
 
-Windows support is actively being developed. Follow the [GitHub issues](https://github.com/anthropics/httpmorph/issues) for updates.
+All platforms use **BoringSSL** (Google's fork of OpenSSL) for consistent TLS behavior and advanced fingerprinting capabilities.
 
 ## Building from Source
 
-### macOS
+httpmorph uses **BoringSSL** (built from source) on all platforms for consistent TLS fingerprinting.
 
+### Prerequisites
+
+**Windows:**
+```bash
+# Install build tools
+choco install cmake golang nasm visualstudio2022buildtools -y
+
+# Or install manually:
+# - Visual Studio 2019+ (with C++ tools)
+# - CMake 3.15+
+# - Go 1.18+
+# - NASM (for BoringSSL assembly optimizations)
+```
+
+**macOS:**
 ```bash
 # Install dependencies
-brew install openssl@3 libnghttp2
+brew install cmake ninja libnghttp2
+```
 
-# Build and install
-python setup.py build_ext --inplace
-pip install -e .
+**Linux:**
+```bash
+# Ubuntu/Debian
+sudo apt-get install cmake ninja-build libssl-dev pkg-config autoconf automake libtool
+
+# Fedora/RHEL
+sudo dnf install cmake ninja-build openssl-devel pkg-config autoconf automake libtool
 ```
 
-### Linux
+### Build Steps
 
 ```bash
-# Install dependencies (Ubuntu/Debian)
-sudo apt-get install libssl-dev libnghttp2-dev
+# 1. Clone the repository
+git clone https://github.com/yourusername/httpmorph.git
+cd httpmorph
 
-# Or (Fedora/RHEL)
-sudo dnf install openssl-devel libnghttp2-devel
+# 2. Build vendor dependencies (BoringSSL, nghttp2, zlib)
+./scripts/setup_vendors.sh  # On Windows: bash scripts/setup_vendors.sh
 
-# Build and install
+# 3. Build Python extensions
 python setup.py build_ext --inplace
-pip install -e .
+
+# 4. Install in development mode
+pip install -e ".[dev]"
 ```
 
+**Note:** The first build takes 5-10 minutes as it compiles BoringSSL from source. Subsequent builds are much faster (~30 seconds) as the vendor libraries are cached.
+
 ## Development
 
 ```bash
-# Clone repository
+# Clone and setup (includes building BoringSSL)
 git clone https://github.com/yourusername/httpmorph.git
 cd httpmorph
+./scripts/setup_vendors.sh
 
 # Install development dependencies
 pip install -e ".[dev]"
 
 # Run tests
-pytest tests/
+pytest tests/ -v
 
 # Run with coverage
 pytest tests/ --cov=httpmorph --cov-report=html
+
+# Run specific test markers
+pytest tests/ -m "not slow"           # Skip slow tests
+pytest tests/ -m integration          # Only integration tests
+pytest tests/ -m fingerprint          # Only fingerprinting tests
 ```
 
 ## Architecture
@@ -310,10 +341,6 @@ Run the test suite:
 pytest tests/ -v
 ```
 
-## License
-
-[License information to be added]
-
 ## Acknowledgments
 
 - Built on BoringSSL (Google)

include/boringssl_compat.h

@@ -0,0 +1,42 @@
+/**
+ * boringssl_compat.h - Windows compatibility layer for BoringSSL
+ *
+ * This header must be included before any BoringSSL headers on Windows
+ * to avoid conflicts with Windows Cryptography API (wincrypt.h) macros.
+ */
+
+#ifndef BORINGSSL_COMPAT_H
+#define BORINGSSL_COMPAT_H
+
+#ifdef _WIN32
+
+/* Windows headers included by Python.h may define these macros
+ * which conflict with BoringSSL type names. Undefine them before
+ * including BoringSSL headers. */
+#ifdef X509_NAME
+#undef X509_NAME
+#endif
+
+#ifdef X509_CERT_PAIR
+#undef X509_CERT_PAIR
+#endif
+
+#ifdef X509_EXTENSIONS
+#undef X509_EXTENSIONS
+#endif
+
+#ifdef PKCS7_SIGNER_INFO
+#undef PKCS7_SIGNER_INFO
+#endif
+
+#ifdef OCSP_REQUEST
+#undef OCSP_REQUEST
+#endif
+
+#ifdef OCSP_RESPONSE
+#undef OCSP_RESPONSE
+#endif
+
+#endif /* _WIN32 */
+
+#endif /* BORINGSSL_COMPAT_H */

scripts/setup_vendors.sh

@@ -40,60 +40,70 @@ echo "Detected OS: $OS"
 echo ""
 
 #
-# 1. BoringSSL / OpenSSL
+# 1. BoringSSL
 #
-echo "==> Setting up SSL library..."
+echo "==> Setting up BoringSSL..."
 
-# On Windows, use vcpkg's OpenSSL instead of building BoringSSL
-if [ "$OS" = "Windows" ] && [ -n "$VCPKG_ROOT" ] && [ -d "$VCPKG_ROOT/installed/x64-windows" ]; then
-    echo "✓ Using vcpkg's OpenSSL (Windows)"
-    echo "  Location: $VCPKG_ROOT/installed/x64-windows"
-else
-    # On Linux/macOS, build BoringSSL
-    if [ ! -d "boringssl" ]; then
-        echo "Cloning BoringSSL..."
-        git clone --depth 1 https://boringssl.googlesource.com/boringssl
-    fi
+# Build BoringSSL on all platforms (including Windows)
+if [ ! -d "boringssl" ]; then
+    echo "Cloning BoringSSL..."
+    git clone --depth 1 https://boringssl.googlesource.com/boringssl
+fi
 
-    cd boringssl
+cd boringssl
 
-    # Check if already built
-    if [ ! -f "build/ssl/libssl.a" ]; then
-        echo "Building BoringSSL..."
+# Check if already built (Windows uses .lib files instead of .a)
+if [ "$OS" = "Windows" ]; then
+    SSL_LIB_FILE="build/ssl/ssl.lib"
+else
+    SSL_LIB_FILE="build/ssl/libssl.a"
+fi
 
-        # BoringSSL requires CMake and Go
-        if ! command -v cmake &> /dev/null; then
-            echo "ERROR: cmake not found. Please install cmake."
-            exit 1
-        fi
+if [ ! -f "$SSL_LIB_FILE" ]; then
+    echo "Building BoringSSL..."
 
-        if ! command -v go &> /dev/null; then
-            echo "WARNING: go not found. BoringSSL will build without some tests."
-        fi
+    # BoringSSL requires CMake and Go
+    if ! command -v cmake &> /dev/null; then
+        echo "ERROR: cmake not found. Please install cmake."
+        exit 1
+    fi
+
+    if ! command -v go &> /dev/null; then
+        echo "WARNING: go not found. BoringSSL will build without some tests."
+    fi
 
-        mkdir -p build
-        cd build
+    mkdir -p build
+    cd build
 
+    # Platform-specific CMake configuration
+    if [ "$OS" = "Windows" ]; then
+        # Use Visual Studio generator on Windows for proper .lib output
+        cmake -DCMAKE_BUILD_TYPE=Release \
+              -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
+              -DBUILD_SHARED_LIBS=OFF \
+              ..
+        cmake --build . --config Release
+    else
         cmake -DCMAKE_BUILD_TYPE=Release \
               -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
               ..
         make -j$(nproc 2>/dev/null || sysctl -n hw.ncpu 2>/dev/null || echo 4)
+    fi
 
-        echo "✓ BoringSSL built successfully"
+    echo "✓ BoringSSL built successfully"
 
-        # Clean up .git directory to save cache space
-        cd "$VENDOR_DIR/boringssl"
-        if [ -d ".git" ]; then
-            echo "Cleaning up .git directory to save cache space..."
-            rm -rf .git
-        fi
-    else
-        echo "✓ BoringSSL already built"
+    # Clean up .git directory to save cache space
+    cd "$VENDOR_DIR/boringssl"
+    if [ -d ".git" ]; then
+        echo "Cleaning up .git directory to save cache space..."
+        rm -rf .git
     fi
-
-    cd "$VENDOR_DIR"
+else
+    echo "✓ BoringSSL already built"
 fi
 
+cd "$VENDOR_DIR"
+
 #
 # 2. liburing (Linux only)
 #
@@ -203,11 +213,7 @@ echo "Vendor Setup Complete!"
 echo "================================"
 echo ""
 echo "Built libraries:"
-if [ "$OS" = "Windows" ] && [ -n "$VCPKG_ROOT" ] && [ -d "$VCPKG_ROOT/installed/x64-windows" ]; then
-    echo "  ✓ OpenSSL:    $VCPKG_ROOT/installed/x64-windows (vcpkg)"
-else
-    echo "  ✓ BoringSSL:  $VENDOR_DIR/boringssl/build"
-fi
+echo "  ✓ BoringSSL:  $VENDOR_DIR/boringssl/build"
 if [ "$OS" = "Linux" ]; then
     echo "  ✓ liburing:   $VENDOR_DIR/liburing/install"
 fi