Skip to content

Commit d0c9b1a

Browse files
committed
[FIX] Pass TEST_HTTPBIN_HOST secret to CI test workflows
Add TEST_HTTPBIN_HOST environment variable to CI workflows to fix test failures. Changes: - Add TEST_HTTPBIN_HOST to workflow secrets in _test.yml - Pass TEST_HTTPBIN_HOST to test environment in _test.yml - Pass TEST_HTTPBIN_HOST from ci.yml to _test.yml workflow Impact: - Edge case security tests can now access httpmorph-bin test server in CI - Buffer reallocation tests can run in CI environment - Fixes collection errors: "TEST_HTTPBIN_HOST environment variable is not set" Related: - Works together with previous commit making dotenv import optional - TEST_HTTPBIN_HOST must be configured as repository secret in GitHub
1 parent be9d4ed commit d0c9b1a

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

.github/workflows/_test.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ on:
1818
secrets:
1919
TEST_PROXY_URL:
2020
required: false
21+
TEST_HTTPBIN_HOST:
22+
required: false
2123
CODECOV_TOKEN:
2224
required: false
2325

@@ -234,6 +236,7 @@ jobs:
234236
pytest tests/ -v --cov=httpmorph --cov-report=xml -m "not proxy"
235237
env:
236238
TEST_PROXY_URL: ${{ secrets.TEST_PROXY_URL }}
239+
TEST_HTTPBIN_HOST: ${{ secrets.TEST_HTTPBIN_HOST }}
237240

238241
- name: Upload coverage
239242
if: matrix.os == inputs.primary-os && matrix.python-version == inputs.primary-python

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ jobs:
2828
primary-python: ${{ needs.load-config.outputs.primary-python }}
2929
secrets:
3030
TEST_PROXY_URL: ${{ secrets.TEST_PROXY_URL }}
31+
TEST_HTTPBIN_HOST: ${{ secrets.TEST_HTTPBIN_HOST }}
3132
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
3233

3334
# ============================================================

0 commit comments

Comments
 (0)