Skip to content

Fix brace expansion in AIC8800 bluetooth service check across board configs #8548

@coderabbitai

Description

@coderabbitai

Problem

The post_family_tweaks__enable_aic8800_bluetooth_service() function in several board configuration files uses brace expansion with test -f, which causes the test command to fail because it receives multiple arguments instead of one.

Affected Files

  • config/boards/kickpik2b.csc
  • config/boards/radxa-cubie-a5e.csc
  • config/boards/radxa-zero3.csc

Current Problematic Code

if chroot_sdcard test -f {/lib/,/usr/lib/,/etc/}systemd/system/aic-bluetooth.service; then

Solution

Replace with explicit OR checks:

if chroot_sdcard test -f /lib/systemd/system/aic-bluetooth.service || \
   chroot_sdcard test -f /usr/lib/systemd/system/aic-bluetooth.service || \
   chroot_sdcard test -f /etc/systemd/system/aic-bluetooth.service; then

Context

This issue was identified during review of PR #8511 but deferred to a separate PR to keep changes focused.

References:

Requested by: @leggewie

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions