fix(system): improve overlayfs module config handling and status check

- Always generate clean overlayroot.conf instead of relying on .dpkg-new
- Fix status command to run overlayroot-chroot with 'true' to avoid hang
- Remove unnecessary apt purge from remove command

Signed-off-by: Igor Pecovnik <igor@armbian.com>

Author: igorpecovnik

tools/modules/system/module_overlayfs.sh

@@ -25,29 +25,32 @@ function module_overlayfs() {
 
 	case "$1" in
 		"${commands[0]}")
-			pkg_install -o Dpkg::Options::="--force-confold" overlayroot cryptsetup cryptsetup-bin
-			[[ ! -f /etc/overlayroot.conf ]] && cp /etc/overlayroot.conf.dpkg-new /etc/overlayroot.conf
-			sed -i "s/^overlayroot=.*/overlayroot=\"tmpfs\"/" /etc/overlayroot.conf
+			pkg_install --reinstall -o Dpkg::Options::="--force-confold" overlayroot
+			cat > /etc/overlayroot.conf <<-EOT
+			# overlayroot config - managed by configng
+			overlayroot_cfgdisk="disabled"
+			overlayroot="tmpfs"
+			EOT
 			rm -f /etc/update-motd.d/97-overlayroot
+
 			if $DIALOG --title " Reboot required " --yes-button "Reboot" --no-button "Cancel" --yesno \
 			"A reboot is required to apply the changes. Shall we reboot now?" 7 34; then
 			reboot
 			fi
 		;;
 		"${commands[1]}")
 			overlayroot-chroot rm /etc/overlayroot.conf > /dev/null 2>&1
-			pkg_remove overlayroot cryptsetup cryptsetup-bin
 			if $DIALOG --title " Reboot required " --yes-button "Reboot" --no-button "Cancel" --yesno \
 			"A reboot is required to apply the changes. Shall we reboot now?" 7 34; then
 			reboot
 			fi
 		;;
 		"${commands[2]}")
-			if command -v overlayroot-chroot > /dev/null 2>&1; then
-				return 0
-			else
-				return 1
-			fi
+			overlayroot-chroot true > /dev/null 2>&1
+			case $? in
+				0) return 0 ;;
+				*) return 1 ;;
+			esac
 		;;
 		"${commands[3]}")
 			echo -e "\nUsage: ${module_options["module_overlayfs,feature"]} <command>"