refactor: standardize ghost and mysql docker modules

Refactor Ghost and MySQL modules to match uptime-kuma structure:

- Use docker.io instead of docker-ce
- Move container/image queries to top with proper docker filters
- Remove redundant queries in each case block
- Add error suppression to docker commands
- Fix image query to use proper name:tag format
- Improve variable quoting throughout
- Add container startup wait loops
- Remove unnecessary docker pull steps

For Ghost module specifically:
- Fix purge command "page not found" error
- Use full image tag (ghost:6) instead of just ID
- Suppress output in remove/purge commands

Signed-off-by: Igor Pecovnik <igor@armbian.com>

Author: igorpecovnik

tests/ghost.conf

@@ -0,0 +1,10 @@
+ENABLED=true
+RELEASE="noble"
+TESTNAME="Ghost install"
+
+testcase() {(
+	set -e
+	./bin/armbian-config --api module_ghost purge
+	./bin/armbian-config --api module_ghost install
+	./bin/armbian-config --api module_ghost status
+)}

tools/modules/software/module_ghost.sh

@@ -18,91 +18,94 @@ function module_ghost () {
 	local title="ghost"
 	local condition=$(which "$title" 2>/dev/null)
 
-	if pkg_installed docker-ce; then
-		local container=$(docker container ls -a | mawk '/(^|[[:space:]])ghost([[:space:]]|$)/{print $1}')
-		local image=$(docker image ls -a | mawk '/(^|[[:space:]])ghost([[:space:]]|$)/{print $1":"$2}')
-	fi
-
-	GHOST_BASE="${SOFTWARE_FOLDER}/ghost"
+	pkg_installed docker.io || module_docker install
+	local container=$(docker container ls -a --filter "name=ghost" --format '{{.ID}}')
+	local image=$(docker image ls -a --format '{{.Repository}}:{{.Tag}}' | grep '^ghost:' | head -1)
 
 	local commands
 	IFS=' ' read -r -a commands <<< "${module_options["module_ghost,example"]}"
 
-	case $1 in
-	"${commands[0]}")
+	GHOST_BASE="${SOFTWARE_FOLDER}/ghost"
 
-		# instatall mysql if not installed
-		if ! module_mysql status; then
-			module_mysql install
-		fi
+	case "$1" in
+		"${commands[0]}")
+			# Install mysql if not installed
+			if ! module_mysql status; then
+				module_mysql install
+			fi
+
+			# Exit if ghost is already running
+			if [[ "${container}" && "${image}" ]]; then
+				echo "Ghost container is already installed and running."
+				exit 0
+			fi
 
-		# exit if ghost is already running
-		if module_ghost status; then
-			exit 0
-		fi
+			MYSQL_USER="${2:-armbian}"
+			MYSQL_PASSWORD="${3:-armbian}"
 
-		MYSQL_USER="${2:-armbian}"
-		MYSQL_PASSWORD="${3:-armbian}"
+			[[ -d "$GHOST_BASE" ]] || mkdir -p "$GHOST_BASE" || { echo "Couldn't create storage directory: $GHOST_BASE"; exit 1; }
+			docker run -d \
+				--name ghost \
+				--net=lsio \
+				--restart unless-stopped \
+				-e database__client=mysql \
+				-e database__connection__host="mysql" \
+				-e database__connection__user="${MYSQL_USER}" \
+				-e database__connection__password="${MYSQL_PASSWORD}" \
+				-e database__connection__database="ghost" \
+				-p "${module_options["module_ghost,port"]}:2368" \
+				-e url="http://$LOCALIPADD:${module_options["module_ghost,port"]}" \
+				-v "$GHOST_BASE:/var/lib/ghost/content" \
+				ghost:6
 
-		[[ -d "$GHOST_BASE" ]] || mkdir -p "$GHOST_BASE" || { echo "Couldn't create storage directory: $GHOST_BASE"; exit 1; }
-		docker pull ghost:5-alpine
-		docker run -d \
-			--name ghost \
-			--net=lsio \
-			--restart unless-stopped \
-			-e database__client=mysql \
-			-e database__connection__host="mysql" \
-			-e database__connection__user="${MYSQL_USER}" \
-			-e database__connection__password="${MYSQL_PASSWORD}" \
-			-e database__connection__database="ghost" \
-			-p ${module_options["module_ghost,port"]}:2368 \
-			-e url=http://$LOCALIPADD:${module_options["module_ghost,port"]} \
-			-v "$GHOST_BASE:/var/lib/ghost/content" \
-			ghost:6
+			# Wait for container to start
+			for i in $(seq 1 20); do
+				state="$(docker inspect -f '{{.State.Status}}' ghost 2>/dev/null || true)"
+				if [[ "$state" == "running" ]]; then
+					break
+				fi
+				sleep 3
+				if [[ $i -eq 20 ]]; then
+					echo -e "\nTimed out waiting for ${title} to start, consult logs (\`docker logs ghost\`)"
+					exit 1
+				fi
+			done
 		;;
-	"${commands[1]}")
-			if pkg_installed docker-ce; then
-				local container=$(docker container ls -a | mawk '/(^|[[:space:]])ghost([[:space:]]|$)/{print $1}')
-				local image=$(docker image ls -a | mawk '/(^|[[:space:]])ghost([[:space:]]|$)/{print $1":"$2}')
-			fi
+		"${commands[1]}")
 			if [[ "${container}" ]]; then
-				docker container rm -f "$container" >/dev/null
-			fi
-			if [[ "${image}" ]]; then
-				docker image rm "$image" >/dev/null
+				docker container rm -f "$container" >/dev/null 2>&1
 			fi
 		;;
-	"${commands[2]}")
+		"${commands[2]}")
 			${module_options["module_ghost,feature"]} ${commands[1]}
+			if [[ "${image}" ]]; then
+				docker image rm "$image" >/dev/null 2>&1 || true
+			fi
 			if [[ -n "${GHOST_BASE}" && "${GHOST_BASE}" != "/" ]]; then
 				rm -rf "${GHOST_BASE}"
 			fi
 		;;
-	"${commands[3]}")
-			if pkg_installed docker-ce; then
-				local container=$(docker container ls -a | mawk '/(^|[[:space:]])ghost([[:space:]]|$)/{print $1}')
-				local image=$(docker image ls -a | mawk '/(^|[[:space:]])ghost([[:space:]]|$)/{print $1":"$2}')
-			fi
+		"${commands[3]}")
 			if [[ "${container}" && "${image}" ]]; then
 				return 0
 			else
 				return 1
 			fi
 		;;
-	"${commands[4]}")
-		echo -e "\nUsage: ${module_options["module_ghost,feature"]} <command>"
-		echo -e "Commands:  ${module_options["module_ghost,example"]}"
-		echo "Available commands:"
-		echo -e "\tinstall\t- Install $title."
-		echo -e "\t         Optionally accepts arguments:"
-		echo -e "\t         db_host db_user db_pass db_name url"
-		echo -e "\tremove\t- Remove $title."
-		echo -e "\tpurge\t- Purge $title image and data."
-		echo -e "\tstatus\t- Show container status."
-		echo
+		"${commands[4]}")
+			echo -e "\nUsage: ${module_options["module_ghost,feature"]} <command>"
+			echo -e "Commands:  ${module_options["module_ghost,example"]}"
+			echo "Available commands:"
+			echo -e "\tinstall\t- Install $title."
+			echo -e "\t         Optionally accepts arguments:"
+			echo -e "\t         db_user db_pass"
+			echo -e "\tremove\t- Remove $title."
+			echo -e "\tpurge\t- Purge $title data folder."
+			echo -e "\tstatus\t- Installation status $title."
+			echo
 		;;
-	*)
-			module_ghost "${commands[4]}"
+		*)
+			${module_options["module_ghost,feature"]} ${commands[4]}
 		;;
 	esac
 }

tools/modules/software/module_mysql.sh

@@ -10,60 +10,59 @@ module_options+=(
 	["module_mysql,port"]="3306"
 	["module_mysql,arch"]="x86-64 arm64"
 )
+
 #
 # Module mysql
 #
 function module_mysql () {
 	local title="mysql"
 	local condition=$(which "$title" 2>/dev/null)
 
-	if pkg_installed docker-ce; then
-		local container=$(docker container ls -a | mawk '/mysql?( |$)/{print $1}')
-		local image=$(docker image ls -a | mawk '/mysql?( |$)/{print $1":"$2}')
-	fi
+	pkg_installed docker.io || module_docker install
+	local container=$(docker container ls -a --filter "name=mysql" --format '{{.ID}}')
+	local image=$(docker image ls -a --format '{{.Repository}} {{.ID}}' | grep '^mysql ' | awk '{print $2}')
 
 	local commands
 	IFS=' ' read -r -a commands <<< "${module_options["module_mysql,example"]}"
 
 	MYSQL_BASE="${SOFTWARE_FOLDER}/mysql"
 
-	case $1 in
+	case "$1" in
 		"${commands[0]}")
-
-			if module_mysql status; then
-			echo "deb"
-			exit 0
+			# Exit if mysql is already running
+			if [[ "${container}" && "${image}" ]]; then
+				echo "MySQL container is already installed."
+				exit 0
 			fi
 
-			pkg_installed docker-ce || module_docker install
-			# get parameters or fallback to dialog
 			MYSQL_ROOT_PASSWORD="${2:-armbian}"
 			MYSQL_DATABASE="${3:-armbian}"
 			MYSQL_USER="${4:-armbian}"
 			MYSQL_PASSWORD="${5:-armbian}"
 
 			[[ -d "$MYSQL_BASE" ]] || mkdir -p "$MYSQL_BASE" || { echo "Couldn't create storage directory: $MYSQL_BASE"; exit 1; }
 
-			docker pull mysql:lts
 			docker run -d \
 				--name mysql \
 				--net=lsio \
-				-e MYSQL_ROOT_PASSWORD="${MYSQL_ROOT_PASSWORD:-armbian}" \
-				-e MYSQL_DATABASE="${MYSQL_DATABASE:-armbian}" \
-				-e MYSQL_USER="${MYSQL_USER:-armbian}" \
-				-e MYSQL_PASSWORD="${MYSQL_PASSWORD:-armbian}" \
+				-e MYSQL_ROOT_PASSWORD="${MYSQL_ROOT_PASSWORD}" \
+				-e MYSQL_DATABASE="${MYSQL_DATABASE}" \
+				-e MYSQL_USER="${MYSQL_USER}" \
+				-e MYSQL_PASSWORD="${MYSQL_PASSWORD}" \
 				-v "${MYSQL_BASE}:/var/lib/mysql" \
-				-p 3306:3306 \
+				-p "${module_options["module_mysql,port"]}:3306" \
 				--restart unless-stopped \
 				mysql:lts
 
+			# Wait for MySQL to be ready
 			until docker exec mysql \
 				env MYSQL_PWD="$MYSQL_ROOT_PASSWORD" \
 				mysql -uroot -e "SELECT 1;" &>/dev/null; do
 				echo "⏳ Waiting for MySQL to accept connections..."
 				sleep 2
 			done
 
+			# Create additional databases
 			MYSQL_DATABASES=("ghost") # Add any additional databases you want to create here
 			for MYSQL_DATABASE in "${MYSQL_DATABASES[@]}"; do
 				echo "⏳ Creating database: $MYSQL_DATABASE and granting privileges..."
@@ -72,17 +71,18 @@ function module_mysql () {
 				env MYSQL_PWD="$MYSQL_ROOT_PASSWORD" \
 				mysql -uroot <<-EOF
 					CREATE DATABASE IF NOT EXISTS \`$MYSQL_DATABASE\`;
-					GRANT ALL PRIVILEGES ON \`$MYSQL_DATABASE\`.* TO '$MYSQL_USER'@'%';
+					GRANT ALL PRIVILEGES ON \`$MYSQL_DATABASE\`.* TO '${MYSQL_USER}'@'%';
 					FLUSH PRIVILEGES;
 				EOF
 			done
 		;;
 		"${commands[1]}")
 			if [[ "${container}" ]]; then
-				docker container rm -f "$container" >/dev/null
+				echo "Removing container: $container"
+				docker container rm -f "$container"
 			fi
 			if [[ "${image}" ]]; then
-				docker image rm "$image" >/dev/null
+				docker image rm "$image"
 			fi
 		;;
 		"${commands[2]}")
@@ -92,10 +92,6 @@ function module_mysql () {
 			fi
 		;;
 		"${commands[3]}")
-			if pkg_installed docker-ce; then
-				local container=$(docker container ls -a | mawk '/mysql?( |$)/{print $1}')
-				local image=$(docker image ls -a | mawk '/mysql?( |$)/{print $1":"$2}')
-			fi
 			if [[ "${container}" && "${image}" ]]; then
 				return 0
 			else
@@ -107,8 +103,8 @@ function module_mysql () {
 			echo -e "Commands:  ${module_options["module_mysql,example"]}"
 			echo "Available commands:"
 			echo -e "\tinstall\t- Install $title."
-			echo -e "\t          Optionally accepts arguments:"
-			echo -e "\t          root_password database user user_password"
+			echo -e "\t         Optionally accepts arguments:"
+			echo -e "\t         root_password database user user_password"
 			echo -e "\tremove\t- Remove $title."
 			echo -e "\tpurge\t- Purge $title data folder."
 			echo -e "\tstatus\t- Installation status $title."