add golangci-lint configuration and improve error handling in consumers

Author: Armin

.github/workflows/go.yml

@@ -21,6 +21,14 @@ jobs:
       with:
         go-version: '1.25'
 
+    - name: Install golangci-lint
+      uses: golangci/golangci-lint-action@v3
+      with:
+        version: v1.55.2
+
+    - name: Lint
+      run: golangci-lint run ./...
+
     - name: Build
       run: go build -v ./...
 

.golangci.yml

@@ -0,0 +1,44 @@
+version: 2
+
+run:
+  timeout: 5m
+  tests: true
+  issues-exit-code: 1
+
+linters:
+  enable:
+    - errcheck
+    - govet
+    - bodyclose
+    - errorlint
+    - sloglint
+    - sqlclosecheck
+
+linters-settings:
+  revive:
+    severity: warning
+    rules:
+      - name: exported
+        severity: warning
+  gocritic:
+    enabled-checks:
+      - ifElseChain
+      - sloppyReassign
+      - unnecessaryDefer
+  gofmt:
+    simplify: true
+
+issues:
+  exclude-rules:
+    - path: "_test\\.go"
+      linters:
+        - errcheck
+        - dupl
+    - path: "docs/.*"
+      linters:
+        - gofmt
+        - revive
+  max-same-issues: 0
+
+output:
+  format: colored-line-number

cmd/api/main.go

@@ -59,7 +59,10 @@ func CreateHermesAndIVRQueue() {
 		panic(err)
 	}
 
-	defer ch.Close()
+	defer func() {
+		_ = ch.Close()
+		_ = conn.Close()
+	}()
 
 	if err = ch.ExchangeDeclare(config.SmsExchange, "direct", true, false, false, false, amqp091.Table{}); err != nil {
 		panic(err)

internal/sms/consumer.go

@@ -22,7 +22,9 @@ func StartConsumers(ctx context.Context) error {
 		10,
 		func(ctx context.Context, evt amqp091.Delivery) error {
 			defer func() {
-				evt.Ack(false)
+				if err := evt.Ack(false); err != nil {
+					app.Logger.Error("ack failed", "err", err)
+				}
 			}()
 			var message model.SMS
 			if err := json.Unmarshal(evt.Body, &message); err != nil {
@@ -50,7 +52,9 @@ func StartConsumers(ctx context.Context) error {
 		10,
 		func(ctx context.Context, evt amqp091.Delivery) error {
 			defer func() {
-				evt.Ack(false)
+				if err := evt.Ack(false); err != nil {
+					app.Logger.Error("ack failed", "err", err)
+				}
 			}()
 			var message model.SMS
 			if err := json.Unmarshal(evt.Body, &message); err != nil {

pkg/circuitbreaker/circuitbreaker.go

@@ -50,8 +50,7 @@ func (cb *Breaker) Allow() error {
 	defer cb.mu.Unlock()
 
 	now := time.Now()
-	switch cb.state {
-	case StateOpen:
+	if cb.state == StateOpen {
 		if now.Before(cb.reopenDeadline) {
 			return ErrOpen
 		}

pkg/queue/worker_consumer.go

@@ -90,7 +90,11 @@ func MakeConsumerWithWorkers(
 		}
 
 		go func() {
-			defer conn.Conn.Close()
+			defer func() {
+				if err := conn.Conn.Close(); err != nil {
+					slog.Error("cannot close amqp connection", "err", err)
+				}
+			}()
 			var workerIndex int
 			for {
 				if workerIndex > workerCount-1 {