fix: update error handling to use error name instead of constructor name for better clarity

Author: arnabrahman

packages/event-handler/src/appsync-graphql/AppSyncGraphQLResolver.ts

@@ -398,7 +398,7 @@ class AppSyncGraphQLResolver extends Router {
   #formatErrorResponse(error: unknown) {
     if (error instanceof Error) {
       return {
-        error: `${error.constructor.name} - ${error.message}`,
+        error: `${error.name} - ${error.message}`,
       };
     }
     return {

packages/event-handler/src/appsync-graphql/ExceptionHandlerRegistry.ts

@@ -56,7 +56,7 @@ class ExceptionHandlerRegistry {
    * @param error - The error instance for which to resolve an exception handler.
    */
   public resolve(error: Error): ExceptionHandler | undefined {
-    const errorName = error.constructor.name;
+    const errorName = error.name;
     this.#logger.debug(`Looking for exception handler for error: ${errorName}`);
 
     const handlerOptions = this.handlers.get(errorName);

packages/event-handler/tests/unit/appsync-graphql/AppSyncGraphQLResolver.test.ts

@@ -10,9 +10,24 @@ import {
 import type { ErrorClass } from '../../../src/types/appsync-graphql.js';
 import { onGraphqlEventFactory } from '../../helpers/factories.js';
 
-class ValidationError extends Error {}
-class NotFoundError extends Error {}
-class DatabaseError extends Error {}
+class ValidationError extends Error {
+  constructor(message: string, options?: ErrorOptions) {
+    super(message, options);
+    this.name = 'ValidationError';
+  }
+}
+class NotFoundError extends Error {
+  constructor(message: string, options?: ErrorOptions) {
+    super(message, options);
+    this.name = 'NotFoundError';
+  }
+}
+class DatabaseError extends Error {
+  constructor(message: string, options?: ErrorOptions) {
+    super(message, options);
+    this.name = 'DatabaseError';
+  }
+}
 
 describe('Class: AppSyncGraphQLResolver', () => {
   beforeEach(() => {

packages/event-handler/tests/unit/appsync-graphql/ExceptionHandlerRegistry.test.ts

@@ -6,7 +6,12 @@ describe('Class: ExceptionHandlerRegistry', () => {
   class MockExceptionHandlerRegistry extends ExceptionHandlerRegistry {
     public declare handlers: Map<string, ExceptionHandlerOptions>;
   }
-  class CustomError extends Error {}
+  class CustomError extends Error {
+    constructor(message: string) {
+      super(message);
+      this.name = 'CustomError';
+    }
+  }
 
   const getRegistry = () =>
     new MockExceptionHandlerRegistry({ logger: console });