Stop calling zend_error() during RSHUTDOWN

arnaud-lb · arnaud-lb · commit 1ea1f3d39b4c · 2020-07-04T15:52:02.000+02:00
diff --git a/memprof.c b/memprof.c
@@ -787,7 +787,9 @@ static void memprof_disable()
 	allocs_set = (Pvoid_t) NULL;
 
 	if (!memprof_dumped) {
-		zend_error(E_WARNING, "Memprof profiling was enabled, but no profile was dumped. Did you forget to call one of memprof_dump_callgrind(), memprof_dump_pprof(), or memprof_dump_array() ?");
+		// Calling this during RSHUTDOWN breaks zend_deactivate_modules(), which
+		// causes corruption of global state.
+		// zend_error(E_WARNING, "Memprof profiling was enabled, but no profile was dumped. Did you forget to call one of memprof_dump_callgrind(), memprof_dump_pprof(), or memprof_dump_array() ?");
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -787,7 +787,9 @@ static void memprof_disable()`
`787`	`787`	`allocs_set = (Pvoid_t) NULL;`
`788`	`788`
`789`	`789`	`if (!memprof_dumped) {`
`790`		`- zend_error(E_WARNING, "Memprof profiling was enabled, but no profile was dumped. Did you forget to call one of memprof_dump_callgrind(), memprof_dump_pprof(), or memprof_dump_array() ?");`
	`790`	`+ // Calling this during RSHUTDOWN breaks zend_deactivate_modules(), which`
	`791`	`+ // causes corruption of global state.`
	`792`	`+ // zend_error(E_WARNING, "Memprof profiling was enabled, but no profile was dumped. Did you forget to call one of memprof_dump_callgrind(), memprof_dump_pprof(), or memprof_dump_array() ?");`
`791`	`793`	`}`
`792`	`794`	`}`
`793`	`795`